missing .data.shared_align placement in vmlinux

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mike Frysinger
Date: Friday, May 21, 2010 - 1:58 pm

am i missing something or does the .data.shared_align section lack
definition in vmlinux.lds.h and all arch vmlinux.lds.S files ?

with the recent change "net: remove time limit in process_backlog()",
the softnet_data variable changed from "DEFINE_PER_CPU()" to
"DEFINE_PER_CPU_ALIGNED()" which moved it from the .data section to
the .data.shared_align section.  i'm not saying this patch is wrong,
just that is what caused me to notice this larger problem.  no one
else in the kernel is using this aligned macro variant, so i imagine
that's why no one has noticed yet.

since .data.shared_align isnt declared in any vmlinux files that i can
see, the linker just places it last.  this "just works" for most
people, but when building a ROM kernel on Blackfin systems, it causes
section overlap errors:
bfin-uclinux-ld.real: section .init.data [00000000202e06b8 ->
00000000202e48b7] overlaps section .data.shared_aligned
[00000000202e06b8 -> 00000000202e0723]
i imagine other arches which support the ROM config option and thus do
funky placement would see similar issues ...

on x86, it is stuck in a dedicated section:
  [ 8] .data             PROGBITS        ffffffff810ec000 2ec000
0303a8 00  WA  0   0 4096
  [ 9] .data.shared_alig PROGBITS        ffffffff8111c3c0 31c3c0
0000c8 00  WA  0   0 64

the ifdef forest in asm-generic/percpu.h is beyond a quick glance &
fix, so i leave it up to someone else ;)
-mike
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
missing .data.shared_align placement in vmlinux, Mike Frysinger, (Fri May 21, 1:58 pm)
Re: missing .data.shared_align placement in vmlinux, Sam Ravnborg, (Wed Aug 4, 4:56 am)
Re: missing .data.shared_align placement in vmlinux, Mike Frysinger, (Wed Aug 4, 11:12 am)
Re: missing .data.shared_align placement in vmlinux, Sam Ravnborg, (Wed Aug 4, 1:28 pm)
Re: missing .data.shared_align placement in vmlinux, Sam Ravnborg, (Wed Aug 4, 1:40 pm)
Re: missing .data.shared_align placement in vmlinux, Jeremy Fitzhardinge, (Wed Aug 4, 10:14 pm)
Re: missing .data.shared_align placement in vmlinux, Mike Frysinger, (Thu Aug 26, 12:19 am)
Re: missing .data.shared_align placement in vmlinux, Mike Frysinger, (Fri Aug 27, 11:00 pm)