> This looks unsafe. What protect child->mm if ptrace() races with SIGKILL ?
quoted text
> 
> Of course, I do not blame this patch, the code was copied from arch/, but
> I think we need another patch which checks ->mm != NULL under task_lock()
> on top of this one?

Agreed, unless things are somehow different on nommu so there aren't such
races.  But, as you mention, this is a long-standing issue that is entirely 
unrelated to the cleanup here and should not delay merging this patch.


Thanks,
Roland
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/