Re: [BUG] SLOB breaks Crypto

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Herbert Xu
Date: Tuesday, May 18, 2010 - 6:51 pm

On Tue, May 18, 2010 at 09:32:54PM +0200, Adrian-Ken Rueegsegger wrote:

I've added the following patch.  Thanks!

commit 18eb8ea6ee4cc9ed39b45f95b734f523bcfb586b
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Wed May 19 11:50:58 2010 +1000

    crypto: shash - Remove usage of CRYPTO_MINALIGN
    
    The macro CRYPTO_MINALIGN is not meant to be used directly.  This
    patch replaces it with crypto_tfm_ctx_alignment.
    
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/shash.c b/crypto/shash.c
index 91f7b9d..22fd943 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -37,7 +37,7 @@ static int shash_setkey_unaligned(struct crypto_shash *tfm, const u8 *key,
 	u8 *buffer, *alignbuffer;
 	int err;
 
-	absize = keylen + (alignmask & ~(CRYPTO_MINALIGN - 1));
+	absize = keylen + (alignmask & ~(crypto_tfm_ctx_alignment() - 1));
 	buffer = kmalloc(absize, GFP_KERNEL);
 	if (!buffer)
 		return -ENOMEM;

-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[BUG] SLOB breaks Crypto, michael-dev, (Mon Mar 15, 6:39 am)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Thu Mar 18, 9:30 am)
Re: [BUG] SLOB breaks Crypto, michael-dev, (Thu Mar 18, 2:24 pm)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Thu Mar 18, 5:33 pm)
Re: [BUG] SLOB breaks Crypto, Adrian-Ken Rueegsegger, (Fri May 14, 7:50 am)
Re: [BUG] SLOB breaks Crypto, Geert Uytterhoeven, (Mon May 17, 9:17 am)
Re: [BUG] SLOB breaks Crypto, Adrian-Ken Rueegsegger, (Mon May 17, 2:50 pm)
Re: [BUG] SLOB breaks Crypto, Matt Mackall, (Mon May 17, 3:37 pm)
Re: [BUG] SLOB breaks Crypto, Adrian-Ken Rueegsegger, (Tue May 18, 1:17 am)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Tue May 18, 3:27 am)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Tue May 18, 7:02 am)
Re: [BUG] SLOB breaks Crypto, Matt Mackall, (Tue May 18, 12:06 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Tue May 18, 12:25 pm)
Re: [BUG] SLOB breaks Crypto, Adrian-Ken Rueegsegger, (Tue May 18, 12:32 pm)
Re: [BUG] SLOB breaks Crypto, Matt Mackall, (Tue May 18, 12:33 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Tue May 18, 1:59 pm)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Tue May 18, 2:15 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Tue May 18, 2:20 pm)
Re: [BUG] SLOB breaks Crypto, Paul Mundt, (Tue May 18, 3:35 pm)
Re: [BUG] SLOB breaks Crypto, Paul Mundt, (Tue May 18, 3:37 pm)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Tue May 18, 3:39 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Tue May 18, 3:40 pm)
Re: [BUG] SLOB breaks Crypto, Paul Mundt, (Tue May 18, 4:10 pm)
Re: [BUG] SLOB breaks Crypto, Matt Mackall, (Tue May 18, 4:16 pm)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Tue May 18, 4:20 pm)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Tue May 18, 6:05 pm)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Tue May 18, 6:51 pm)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Tue May 18, 9:09 pm)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Tue May 18, 10:44 pm)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Tue May 18, 10:53 pm)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Wed May 19, 12:14 am)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Wed May 19, 12:45 am)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Wed May 19, 3:58 am)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Wed May 19, 4:08 am)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Wed May 19, 4:16 am)
Re: [BUG] SLOB breaks Crypto, Geert Uytterhoeven, (Wed May 19, 4:32 am)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Wed May 19, 4:40 am)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Wed May 19, 4:46 am)
Re: [BUG] SLOB breaks Crypto, Geert Uytterhoeven, (Wed May 19, 4:50 am)
Re: [BUG] SLOB breaks Crypto, FUJITA Tomonori, (Wed May 19, 5:02 am)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Wed May 19, 5:19 am)
Re: [BUG] SLOB breaks Crypto, FUJITA Tomonori, (Wed May 19, 5:26 am)
Re: [BUG] SLOB breaks Crypto, David Woodhouse, (Wed May 19, 5:48 am)
Re: [BUG] SLOB breaks Crypto, Pekka Enberg, (Wed May 19, 5:54 am)
Re: [BUG] SLOB breaks Crypto, Herbert Xu, (Wed May 19, 5:59 am)
Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALL ..., Johannes Stezenbach, (Wed May 19, 6:30 am)
[PATCH 5/4] Provide __dma_aligned macro, David Woodhouse, (Wed May 19, 6:49 am)
Re: [BUG] SLOB breaks Crypto, Matt Mackall, (Wed May 19, 7:11 am)
Re: [PATCH 5/4] Provide __dma_aligned macro, FUJITA Tomonori, (Wed May 19, 7:50 am)
Re: [BUG] SLOB breaks Crypto, Christoph Lameter, (Wed May 19, 8:19 am)
Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALL ..., Christoph Lameter, (Wed May 19, 12:19 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Wed May 19, 12:33 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Wed May 19, 12:42 pm)
Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALL ..., Christoph Lameter, (Wed May 19, 12:45 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Wed May 19, 12:51 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Wed May 19, 12:56 pm)
Re: [BUG] SLOB breaks Crypto, FUJITA Tomonori, (Wed May 19, 8:38 pm)
Re: [BUG] SLOB breaks Crypto, David Miller, (Wed May 19, 8:46 pm)