[PATCH v4 12/13] perf: Dont adjust symbols on name lookup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Srikar Dronamraju
Date: Tuesday, May 18, 2010 - 10:00 am

Adjusting symbols is not needed if we are searching by name.
Infact if we adjust and search symbols by name, we get incorrect
results.

Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---

 tools/perf/util/symbol.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index c458c4a..7267050 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -958,12 +958,14 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
 	nr_syms = shdr.sh_size / shdr.sh_entsize;
 
 	memset(&sym, 0, sizeof(sym));
-	if (!self->kernel) {
+	if (self->kernel || symbol_conf.sort_by_name)
+		self->adjust_symbols = 0;
+	else {
 		self->adjust_symbols = (ehdr.e_type == ET_EXEC ||
 				elf_section_by_name(elf, &ehdr, &shdr,
 						     ".gnu.prelink_undo",
 						     NULL) != NULL);
-	} else self->adjust_symbols = 0;
+	}
 
 	elf_symtab__for_each_symbol(syms, nr_syms, idx, sym) {
 		struct symbol *f;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v4 0/13] Uprobes v4, Srikar Dronamraju, (Tue May 18, 9:58 am)
[PATCH v4 1/13] X86 instruction analysis: Move Macro W to ..., Srikar Dronamraju, (Tue May 18, 9:58 am)
[PATCH v4 2/13] mm: Move replace_page to mm/memory.c, Srikar Dronamraju, (Tue May 18, 9:58 am)
[PATCH v4 3/13] User Space Breakpoint Assistance Layer, Srikar Dronamraju, (Tue May 18, 9:58 am)
[PATCH v4 4/13] x86 support for User space breakpoint assi ..., Srikar Dronamraju, (Tue May 18, 9:59 am)
[PATCH v4 5/13] Slot allocation for execution out of line ..., Srikar Dronamraju, (Tue May 18, 9:59 am)
[PATCH v4 6/13] Uprobes Implementation, Srikar Dronamraju, (Tue May 18, 9:59 am)
[PATCH v4 7/13] x86 support for Uprobes, Srikar Dronamraju, (Tue May 18, 9:59 am)
[PATCH v4 8/13] samples: Uprobes samples, Srikar Dronamraju, (Tue May 18, 9:59 am)
[PATCH v4 9/13] Uprobes documentation., Srikar Dronamraju, (Tue May 18, 10:00 am)
[PATCH v4 10/13] trace: Common code for kprobes/uprobes tr ..., Srikar Dronamraju, (Tue May 18, 10:00 am)
[PATCH v4 11/13] trace: uprobes trace_event interface, Srikar Dronamraju, (Tue May 18, 10:00 am)
[PATCH v4 12/13] perf: Dont adjust symbols on name lookup, Srikar Dronamraju, (Tue May 18, 10:00 am)
[PATCH v4 13/13] perf: perf interface for uprobes., Srikar Dronamraju, (Tue May 18, 10:00 am)
Re: [PATCH v4 10/13] trace: Common code for kprobes/uprobe ..., Masami Hiramatsu, (Tue May 18, 10:23 am)
Re: [PATCH v4 0/13] Uprobes v4, Mathieu Desnoyers, (Tue May 18, 1:49 pm)
Re: [PATCH v4 0/13] Uprobes v4, Srikar Dronamraju, (Tue May 18, 11:08 pm)
Re: [PATCH v4 10/13] trace: Common code for kprobes/uprobe ..., Srikar Dronamraju, (Tue May 18, 11:21 pm)
Re: [PATCH v4 0/13] Uprobes v4, Mathieu Desnoyers, (Wed May 19, 7:15 am)
Re: [PATCH v4 0/13] Uprobes v4, Peter Zijlstra, (Wed May 19, 7:17 am)
Re: [PATCH v4 0/13] Uprobes v4, Srikar Dronamraju, (Wed May 19, 10:38 am)
Re: [PATCH v4 0/13] Uprobes v4, Frank Ch. Eigler, (Wed May 19, 10:45 am)
Re: [PATCH v4 0/13] Uprobes v4, Peter Zijlstra, (Wed May 19, 10:54 am)
Re: [PATCH v4 0/13] Uprobes v4, Srikar Dronamraju, (Wed May 19, 7:26 pm)
Re: [PATCH v4 11/13] trace: uprobes trace_event interface, Steven Rostedt, (Mon May 24, 7:22 pm)
Re: [PATCH v4 11/13] trace: uprobes trace_event interface, Srikar Dronamraju, (Tue May 25, 5:23 am)