Re: [PATCH] signals: check_kill_permission: don't check creds if same_thread_group()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Howells
Date: Tuesday, May 18, 2010 - 6:50 am

Oleg Nesterov <oleg@redhat.com> wrote:


Sorry, yes.  I was reading get_current() as current_cred() for some reason.

However, you are _still_ calling get_current() twice...  So that bit of your
changelog isn't really correct.

In fact, get_current() should be __attribute_const__ since it can't change
whilst you're looking at it, except within switch_to(), probably in a piece of
assembly code, so gcc should be free to cache it as long as it likes.

David
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] signals: check_kill_permission: don't check cr ..., David Howells, (Tue May 18, 6:50 am)