Re: [PATCH v2 7/11] Uprobes Implementation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Thursday, May 13, 2010 - 12:59 pm

On Thu, 13 May 2010, Oleg Nesterov wrote:

Well, if I reasd the patches right, uprobes will use "copy_to_user()" for 
the self-probing case. So that would definitely just modify a shared 
mapping.

Of course, arguably, who really cares? As long as it's not a security 
issue (and it isn't - since the person could just have written to the 
thing directly instead), I guess it doesn't much matter. But it's a bit 
sad when a probing feature either

 - changes a global mapping that may be executed by other non-related 
   processes that the prober isn't even _aware_ of.

 - changes semantics by creating a non-coherent private page

so arguably it would be good to just make the rule be that you cannot 
probe a shared mapping. Because whatever you do, it's always the wrong 
thing.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v2 0/11] Uprobes patches., Srikar Dronamraju, (Wed Mar 31, 8:51 am)
[PATCH v2 1/11] Move Macro W to insn.h, Srikar Dronamraju, (Wed Mar 31, 8:51 am)
[PATCH v2 2/11] Move replace_page() to mm/memory.c, Srikar Dronamraju, (Wed Mar 31, 8:51 am)
[PATCH v2 3/11] Enhance replace_page() to support pagecache, Srikar Dronamraju, (Wed Mar 31, 8:51 am)
[PATCH v2 4/11] User Space Breakpoint Assistance Layer, Srikar Dronamraju, (Wed Mar 31, 8:51 am)
[PATCH v2 5/11] X86 details for user space breakpoint assi ..., Srikar Dronamraju, (Wed Mar 31, 8:52 am)
[PATCH v2 6/11] Slot allocation for Execution out of line, Srikar Dronamraju, (Wed Mar 31, 8:52 am)
[PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Wed Mar 31, 8:52 am)
[PATCH v2 8/11] X86 details for uprobes., Srikar Dronamraju, (Wed Mar 31, 8:52 am)
[PATCH v2 9/11] Uprobes Documentation patch, Srikar Dronamraju, (Wed Mar 31, 8:52 am)
[PATCH v2 10/11] Uprobes samples., Srikar Dronamraju, (Wed Mar 31, 8:52 am)
[PATCH v2 11/11] Uprobes traceevents patch., Srikar Dronamraju, (Wed Mar 31, 8:53 am)
Re: [PATCH v2 11/11] Uprobes traceevents patch., Steven Rostedt, (Wed Mar 31, 2:24 pm)
Re: [PATCH v2 11/11] Uprobes traceevents patch., Masami Hiramatsu, (Wed Mar 31, 9:16 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Tue Apr 13, 11:35 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Thu Apr 15, 2:35 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Mon Apr 19, 12:31 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Tue Apr 20, 5:43 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Tue Apr 20, 8:30 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Tue Apr 20, 11:59 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Wed Apr 21, 9:05 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Thu Apr 22, 6:31 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Thu Apr 22, 8:40 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Fri Apr 23, 7:58 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Fri Apr 23, 11:53 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Tue May 11, 1:32 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Tue May 11, 1:43 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Tue May 11, 1:44 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Tue May 11, 1:45 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Tue May 11, 1:47 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Frank Ch. Eigler, (Tue May 11, 1:57 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Tue May 11, 2:01 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Wed May 12, 3:31 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Wed May 12, 3:41 am)
Re: [PATCH v2 11/11] Uprobes traceevents patch., Frederic Weisbecker, (Wed May 12, 4:02 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Peter Zijlstra, (Wed May 12, 4:12 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Wed May 12, 7:24 am)
Re: [PATCH v2 11/11] Uprobes traceevents patch., Srikar Dronamraju, (Wed May 12, 7:34 am)
Re: [PATCH v2 11/11] Uprobes traceevents patch., Frederic Weisbecker, (Wed May 12, 7:57 am)
Re: [PATCH v2 11/11] Uprobes traceevents patch., Frederic Weisbecker, (Wed May 12, 8:15 am)
Re: [PATCH v2 7/11] Uprobes Implementation, Oleg Nesterov, (Thu May 13, 12:40 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Linus Torvalds, (Thu May 13, 12:59 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Andi Kleen, (Thu May 13, 3:12 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Linus Torvalds, (Thu May 13, 3:25 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Roland McGrath, (Thu May 13, 5:56 pm)
Re: [PATCH v2 7/11] Uprobes Implementation, Srikar Dronamraju, (Thu May 13, 10:42 pm)