[PATCH] panic: Call console_verbose in panic

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Anton Blanchard
Date: Monday, May 10, 2010 - 3:59 pm

Most distros turn the console verbosity down and that means a backtrace after
a panic never makes it to the console. I assume we haven't seen this because
a panic is often preceeded by an oops which will have called console_verbose.
There are however a lot of places we call panic directly, and they are
broken.

Use console_verbose like we do in the oops path to ensure a directly called
panic will print a backtrace.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Index: linux-2.6/kernel/panic.c
===================================================================
--- linux-2.6.orig/kernel/panic.c	2010-05-09 09:13:06.000000000 +1000
+++ linux-2.6/kernel/panic.c	2010-05-09 09:14:13.000000000 +1000
@@ -87,6 +87,7 @@ NORET_TYPE void panic(const char * fmt, 
 	 */
 	preempt_disable();
 
+	console_verbose();
 	bust_spinlocks(1);
 	va_start(args, fmt);
 	vsnprintf(buf, sizeof(buf), fmt, args);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] panic: Call console_verbose in panic, Anton Blanchard, (Mon May 10, 3:59 pm)
Re: [PATCH] panic: Call console_verbose in panic, Greg KH, (Mon May 10, 4:10 pm)
Re: [PATCH] panic: Call console_verbose in panic, Andrew Morton, (Wed May 12, 4:39 pm)
Re: [PATCH] panic: Call console_verbose in panic, David Howells, (Thu May 13, 3:00 am)