[PATCH 14/25] lmb: Make lmb_find_region() out of lmb_alloc_region()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Monday, May 10, 2010 - 2:38 am

This function will be used to locate a free area to put the new lmb
arrays when attempting to resize them. lmb_alloc_region() is gone,
the two callsites now call lmb_add_region().

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 lib/lmb.c |   20 +++++++++-----------
 1 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/lib/lmb.c b/lib/lmb.c
index 6765a3a..4882e9a 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -309,8 +309,8 @@ static phys_addr_t lmb_align_up(phys_addr_t addr, phys_addr_t size)
 	return (addr + (size - 1)) & ~(size - 1);
 }
 
-static phys_addr_t __init lmb_alloc_region(phys_addr_t start, phys_addr_t end,
-					   phys_addr_t size, phys_addr_t align)
+static phys_addr_t __init lmb_find_region(phys_addr_t start, phys_addr_t end,
+					  phys_addr_t size, phys_addr_t align)
 {
 	phys_addr_t base, res_base;
 	long j;
@@ -318,12 +318,8 @@ static phys_addr_t __init lmb_alloc_region(phys_addr_t start, phys_addr_t end,
 	base = lmb_align_down((end - size), align);
 	while (start <= base) {
 		j = lmb_overlaps_region(&lmb.reserved, base, size);
-		if (j < 0) {
-			/* this area isn't reserved, take it */
-			if (lmb_add_region(&lmb.reserved, base, size) < 0)
-				base = ~(phys_addr_t)0;
+		if (j < 0)
 			return base;
-		}
 		res_base = lmb.reserved.regions[j].base;
 		if (res_base < size)
 			break;
@@ -356,8 +352,9 @@ static phys_addr_t __init lmb_alloc_nid_region(struct lmb_region *mp,
 
 		this_end = lmb_nid_range(start, end, &this_nid);
 		if (this_nid == nid) {
-			phys_addr_t ret = lmb_alloc_region(start, this_end, size, align);
-			if (ret != ~(phys_addr_t)0)
+			phys_addr_t ret = lmb_find_region(start, this_end, size, align);
+			if (ret != ~(phys_addr_t)0 &&
+			    lmb_add_region(&lmb.reserved, start, size) >= 0)
 				return ret;
 		}
 		start = this_end;
@@ -432,8 +429,9 @@ phys_addr_t __init __lmb_alloc_base(phys_addr_t size, phys_addr_t align, phys_ad
 		if (lmbsize < size)
 			continue;
 		base = min(lmbbase + lmbsize, max_addr);
-		res_base = lmb_alloc_region(lmbbase, base, size, align);
-		if (res_base != ~(phys_addr_t)0)
+		res_base = lmb_find_region(lmbbase, base, size, align);		
+		if (res_base != ~(phys_addr_t)0 &&
+		    lmb_add_region(&lmb.reserved, res_base, size) >= 0)
 			return res_base;
 	}
 	return 0;
-- 
1.6.3.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 02/25] lmb: No reason to include asm/lmb.h late, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 03/25] lmb: Introduce for_each_lmb() and new access ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 04/25] lmb: Remove nid_range argument, arch provide ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 05/25] lmb: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 06/25] lmb: Expose LMB_ALLOC_ANYWHERE, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 07/25] lmb: Introduce default allocation limit and ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 08/25] lmb: Remove rmo_size, burry it in arch/power ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 09/25] lmb: Change u64 to phys_addr_t, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 10/25] lmb: Remove unused lmb.debug struct member, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 11/25] lmb: Remove lmb_type.size and add lmb.memory ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 12/25] lmb: Move lmb arrays to static storage in lm ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 13/25] lmb: Add debug markers at the end of the array, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 14/25] lmb: Make lmb_find_region() out of lmb_alloc ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 15/25] lmb: Define LMB_ERROR internally instead of ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 16/25] lmb: Move lmb_init() to the bottom of the file, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 17/25] lmb: split lmb_find_base() out of __lmb_allo ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 18/25] lmb: Move functions around into a more sensi ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 19/25] lmb: Add array resizing support, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 20/25] lmb: Add arch function to control coalescing ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 21/25] lmb: Add &quot;start&quot; argument to lmb_find_base(), Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 22/25] lmb: NUMA allocate can now use early_pfn_map, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 23/25] lmb: Separate lmb_alloc_nid() and lmb_alloc_ ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
Re: [PATCH 12/25] lmb: Move lmb arrays to static storage i ..., Benjamin Herrenschmidt, (Mon May 10, 4:46 am)
Re: [PATCH 03/25] lmb: Introduce for_each_lmb() and new ac ..., Benjamin Herrenschmidt, (Mon May 10, 2:52 pm)
Re: [PATCH 19/25] lmb: Add array resizing support, Yinghai Lu, (Mon May 10, 4:59 pm)
Re: [PATCH 19/25] lmb: Add array resizing support, Benjamin Herrenschmidt, (Mon May 10, 9:56 pm)
Re: [PATCH 19/25] lmb: Add array resizing support, Yinghai Lu, (Tue May 11, 10:54 am)
Re: [PATCH 05/25] lmb: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Tue May 11, 3:24 pm)
Re: [PATCH 03/25] lmb: Introduce for_each_lmb() and new ac ..., Benjamin Herrenschmidt, (Tue May 11, 10:20 pm)
Re: [PATCH 05/25] lmb: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Tue May 11, 10:24 pm)