[PATCH 17/25] lmb: split lmb_find_base() out of __lmb_alloc_base()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Monday, May 10, 2010 - 2:38 am

This will be used by the array resize code and might prove useful
to some arch code as well at which point it can be made non-static.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 lib/lmb.c |   43 +++++++++++++++++++++++++++----------------
 1 files changed, 27 insertions(+), 16 deletions(-)

diff --git a/lib/lmb.c b/lib/lmb.c
index 141d4ab..95ef5b6 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -366,20 +366,7 @@ phys_addr_t __init lmb_alloc(phys_addr_t size, phys_addr_t align)
 	return lmb_alloc_base(size, align, LMB_ALLOC_ACCESSIBLE);
 }
 
-phys_addr_t __init lmb_alloc_base(phys_addr_t size, phys_addr_t align, phys_addr_t max_addr)
-{
-	phys_addr_t alloc;
-
-	alloc = __lmb_alloc_base(size, align, max_addr);
-
-	if (alloc == 0)
-		panic("ERROR: Failed to allocate 0x%llx bytes below 0x%llx.\n",
-		      (unsigned long long) size, (unsigned long long) max_addr);
-
-	return alloc;
-}
-
-phys_addr_t __init __lmb_alloc_base(phys_addr_t size, phys_addr_t align, phys_addr_t max_addr)
+static phys_addr_t __init lmb_find_base(phys_addr_t size, phys_addr_t align, phys_addr_t max_addr)
 {
 	long i;
 	phys_addr_t base = 0;
@@ -405,13 +392,37 @@ phys_addr_t __init __lmb_alloc_base(phys_addr_t size, phys_addr_t align, phys_ad
 			continue;
 		base = min(lmbbase + lmbsize, max_addr);
 		res_base = lmb_find_region(lmbbase, base, size, align);		
-		if (res_base != LMB_ERROR &&
-		    lmb_add_region(&lmb.reserved, res_base, size) >= 0)
+		if (res_base != LMB_ERROR)
 			return res_base;
 	}
 	return 0;
 }
 
+phys_addr_t __init __lmb_alloc_base(phys_addr_t size, phys_addr_t align, phys_addr_t max_addr)
+{
+	phys_addr_t found = lmb_find_base(size, align, max_addr);
+
+	if (found != LMB_ERROR &&
+	    lmb_add_region(&lmb.reserved, found, size) >= 0)
+		return found;
+
+	return 0;
+}
+
+phys_addr_t __init lmb_alloc_base(phys_addr_t size, phys_addr_t align, phys_addr_t max_addr)
+{
+	phys_addr_t alloc;
+
+	alloc = __lmb_alloc_base(size, align, max_addr);
+
+	if (alloc == 0)
+		panic("ERROR: Failed to allocate 0x%llx bytes below 0x%llx.\n",
+		      (unsigned long long) size, (unsigned long long) max_addr);
+
+	return alloc;
+}
+
+
 /* You must call lmb_analyze() before this. */
 phys_addr_t __init lmb_phys_mem_size(void)
 {
-- 
1.6.3.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 02/25] lmb: No reason to include asm/lmb.h late, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 03/25] lmb: Introduce for_each_lmb() and new access ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 04/25] lmb: Remove nid_range argument, arch provide ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 05/25] lmb: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 06/25] lmb: Expose LMB_ALLOC_ANYWHERE, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 07/25] lmb: Introduce default allocation limit and ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 08/25] lmb: Remove rmo_size, burry it in arch/power ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 09/25] lmb: Change u64 to phys_addr_t, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 10/25] lmb: Remove unused lmb.debug struct member, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 11/25] lmb: Remove lmb_type.size and add lmb.memory ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 12/25] lmb: Move lmb arrays to static storage in lm ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 13/25] lmb: Add debug markers at the end of the array, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 14/25] lmb: Make lmb_find_region() out of lmb_alloc ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 15/25] lmb: Define LMB_ERROR internally instead of ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 16/25] lmb: Move lmb_init() to the bottom of the file, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 17/25] lmb: split lmb_find_base() out of __lmb_allo ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 18/25] lmb: Move functions around into a more sensi ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 19/25] lmb: Add array resizing support, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 20/25] lmb: Add arch function to control coalescing ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 21/25] lmb: Add &quot;start&quot; argument to lmb_find_base(), Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 22/25] lmb: NUMA allocate can now use early_pfn_map, Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
[PATCH 23/25] lmb: Separate lmb_alloc_nid() and lmb_alloc_ ..., Benjamin Herrenschmidt, (Mon May 10, 2:38 am)
Re: [PATCH 12/25] lmb: Move lmb arrays to static storage i ..., Benjamin Herrenschmidt, (Mon May 10, 4:46 am)
Re: [PATCH 03/25] lmb: Introduce for_each_lmb() and new ac ..., Benjamin Herrenschmidt, (Mon May 10, 2:52 pm)
Re: [PATCH 19/25] lmb: Add array resizing support, Yinghai Lu, (Mon May 10, 4:59 pm)
Re: [PATCH 19/25] lmb: Add array resizing support, Benjamin Herrenschmidt, (Mon May 10, 9:56 pm)
Re: [PATCH 19/25] lmb: Add array resizing support, Yinghai Lu, (Tue May 11, 10:54 am)
Re: [PATCH 05/25] lmb: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Tue May 11, 3:24 pm)
Re: [PATCH 03/25] lmb: Introduce for_each_lmb() and new ac ..., Benjamin Herrenschmidt, (Tue May 11, 10:20 pm)
Re: [PATCH 05/25] lmb: Factor the lowest level alloc function, Benjamin Herrenschmidt, (Tue May 11, 10:24 pm)