Re: [RFC] Initial OLPC Viafb merge

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Florian Tobias Schandinat
Date: Friday, April 9, 2010 - 4:32 pm

Jonathan Corbet schrieb:

Well the time I looked in your tree I didn't see any of the remaining 
suspend/resume efforts. Okay perhaps I should have rechecked it now and 
than.
Please correct me if I am wrong but the remaining 6 patches concerning 
suspend&resume look like a real big FIXME. So at the end it is expected 
to work only on VX855 and needs something called OFW?
It doesn't seem to make much sense to review each of them because the 
following patches might or might not correct some of the issues of the 
other. It is really a pain to have 6 patches trying to add a single 
feature. Is there any way to fix this mess. (I assume you didn't merge 
them due to authorship issues?)
I think it might be better to drop those for now and wait for viafb to 
be in a better shape before adding this feature. The mode setting should 
be in a pretty good shape just 1 or 2 kernel versions ahead so that the 
dependency on OFW can be dropped I think.

Sorry but I really think this is not in a shape where merging it is an 
option. I think it would be better to skip those suspend/resume patches 
for the next merge window.


Thanks,

Florian Tobias Schandinat
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] Initial OLPC Viafb merge, Jonathan Corbet, (Thu Apr 8, 10:15 am)
[PATCH 02/16] viafb: use proper pci config API, Jonathan Corbet, (Thu Apr 8, 10:15 am)
[PATCH 04/16] viafb: Retain GEMODE reserved bits, Jonathan Corbet, (Thu Apr 8, 10:15 am)
[PATCH 11/16] Minimal support for viafb suspend/resume, Jonathan Corbet, (Thu Apr 8, 10:15 am)
[PATCH 14/16] Remove cursor restore hack in viafb, Jonathan Corbet, (Thu Apr 8, 10:15 am)
[PATCH 15/16] viafb: rework suspend/resume, Jonathan Corbet, (Thu Apr 8, 10:15 am)
[PATCH 16/16] viafb: Only suspend/resume on VX855, Jonathan Corbet, (Thu Apr 8, 10:15 am)
Re: [PATCH 01/16] [FB] viafb: Fix various resource leaks d ..., Florian Tobias Schan ..., (Thu Apr 8, 11:22 am)
Re: [PATCH 02/16] viafb: use proper pci config API, Florian Tobias Schan ..., (Thu Apr 8, 11:42 am)
Re: [PATCH 03/16] viafb: Unmap the frame buffer on initial ..., Florian Tobias Schan ..., (Thu Apr 8, 11:55 am)
Re: [PATCH 04/16] viafb: Retain GEMODE reserved bits, Florian Tobias Schan ..., (Thu Apr 8, 8:07 pm)
Re: [PATCH 05/16] viafb: Determine type of 2D engine and s ..., Florian Tobias Schan ..., (Thu Apr 8, 8:20 pm)
Re: [PATCH 06/16] viafb: complete support for VX800/VX855 ..., Florian Tobias Schan ..., (Thu Apr 8, 9:21 pm)
Re: [RFC] Initial OLPC Viafb merge, Florian Tobias Schan ..., (Thu Apr 8, 10:43 pm)
Re: [RFC] Initial OLPC Viafb merge, Jonathan Corbet, (Fri Apr 9, 11:46 am)
Re: [PATCH 02/16] viafb: use proper pci config API, Jonathan Corbet, (Fri Apr 9, 12:46 pm)
Re: [PATCH 04/16] viafb: Retain GEMODE reserved bits, Jonathan Corbet, (Fri Apr 9, 12:59 pm)
Re: [PATCH 04/16] viafb: Retain GEMODE reserved bits, Florian Tobias Schan ..., (Fri Apr 9, 1:23 pm)
Re: [PATCH 04/16] viafb: Retain GEMODE reserved bits, Jonathan Corbet, (Fri Apr 9, 1:30 pm)
Re: [PATCH 05/16] viafb: Determine type of 2D engine and s ..., Florian Tobias Schan ..., (Fri Apr 9, 1:34 pm)
Re: [PATCH 07/16] viafb: Add 1200x900 DCON/LCD panel modes ..., Florian Tobias Schan ..., (Fri Apr 9, 2:27 pm)
Re: [PATCH 08/16] viafb: Do not probe for LVDS/TMDS on OLP ..., Florian Tobias Schan ..., (Fri Apr 9, 2:40 pm)
Re: [PATCH 09/16] viafb: rework the I2C support in the VIA ..., Florian Tobias Schan ..., (Fri Apr 9, 3:07 pm)
Re: [PATCH 10/16] suppress verbose debug messages: change ..., Florian Tobias Schan ..., (Fri Apr 9, 3:09 pm)
Re: [RFC] Initial OLPC Viafb merge, Florian Tobias Schan ..., (Fri Apr 9, 4:32 pm)
Re: [RFC] Initial OLPC Viafb merge, Jonathan Corbet, (Fri Apr 9, 5:27 pm)
Re: [PATCH 08/16] viafb: Do not probe for LVDS/TMDS on OLP ..., Florian Tobias Schan ..., (Fri Apr 9, 5:42 pm)
Re: [RFC] Initial OLPC Viafb merge, Florian Tobias Schan ..., (Fri Apr 9, 6:02 pm)
Re: [PATCH 02/16] viafb: use proper pci config API, Harald Welte, (Fri Apr 9, 11:41 pm)
Re: [RFC] Initial OLPC Viafb merge, Bruno Prémont, (Sat Apr 10, 1:52 am)
Re: [RFC] Initial OLPC Viafb merge, Florian Tobias Schan ..., (Mon Apr 12, 8:03 pm)
Re: [PATCH 05/16] viafb: Determine type of 2D engine and s ..., Florian Tobias Schan ..., (Sun Apr 18, 11:05 am)
Re: [PATCH 07/16] viafb: Add 1200x900 DCON/LCD panel modes ..., Florian Tobias Schan ..., (Sun Apr 18, 11:24 am)
Re: [RFC] Initial OLPC Viafb merge, Jonathan Corbet, (Wed Apr 21, 1:37 pm)