Home » Mailing list archives » linux-kernel » 2010 » April » 9

[PATCH 07/12] rtc-m41t80: Use nonseekable_open()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jan Blunck
Subject: [PATCH 07/12] rtc-m41t80: Use nonseekable_open()
Date: Friday, April 9, 2010 - 7:00 am

Use nonseekable_open() for this since seeking is not supported anyway.

Signed-off-by: Jan Blunck <jblunck@suse.de>
---
 drivers/rtc/rtc-m41t80.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index 60fe266..1e2ed76 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -595,10 +595,6 @@ static void wdt_disable(void)
 static ssize_t wdt_write(struct file *file, const char __user *buf,
 			 size_t count, loff_t *ppos)
 {
-	/*  Can't seek (pwrite) on this device
-	if (ppos != &file->f_pos)
-	return -ESPIPE;
-	*/
 	if (count) {
 		wdt_ping();
 		return 1;
@@ -695,7 +691,7 @@ static int wdt_open(struct inode *inode, struct file *file)
 		 */
 		wdt_is_open = 1;
 		unlock_kernel();
-		return 0;
+		return nonseekable_open(inode, file);
 	}
 	return -ENODEV;
 }
-- 
1.6.4.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/12] Multiple file-&gt;f_pos/nonseekable_open/llseek ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 01/12] osst: Update ppos instead of using file-&gt;f_pos, Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 02/12] flash_read should update ppos instead of fil ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 03/12] eeprom_read()/eeprom_write() should update p ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 04/12] frv: remove &quot;struct file *&quot; argument from sy ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 05/12] mISDN: Remove unnecessary test on f_pos, Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 06/12] zcrypt: Use nonseekable_open(), Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 07/12] rtc-m41t80: Use nonseekable_open(), Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 08/12] Introduce noop_llseek(), Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 09/12] osst: Use noop_llseek() instead of default_l ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 10/12] st: Use noop_llseek() instead of default_lls ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 11/12] Do not fallback to default_llseek() when rea ..., Jan Blunck, (Fri Apr 9, 7:00 am)
[PATCH 12/12] Documentation/filesystems/Locking: Update do ..., Jan Blunck, (Fri Apr 9, 7:00 am)
Re: [PATCH 04/12] frv: remove &quot;struct file *&quot; argument fro ..., Alexey Dobriyan, (Fri Apr 9, 9:23 am)
Re: [PATCH 04/12] frv: remove &quot;struct file *&quot; argument fro ..., Jan Blunck, (Mon Apr 12, 1:11 am)