[PATCH 01/39] swiotlb: Use page alignment for early buffer allocation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Thursday, April 8, 2010 - 11:03 pm

We could call free_bootmem_late() if swiotlb is not used, and
it will shrink to page alignement.

So alloc them with page alignment at first, to avoid lose two pages

before patch:
[    0.000000]     lmb_reserve_area: [00d3600000, 00d7600000]   swiotlb buffer
[    0.000000]     lmb_reserve_area: [00d7e7ef40, 00d7e9ef40]     swiotlb list
[    0.000000]     lmb_reserve_area: [00d7e3ef40, 00d7e7ef40]  swiotlb orig_ad
[    0.000000]     lmb_reserve_area: [000008a000, 0000092000]  swiotlb overflo

after patch will get
[    0.000000]     lmb_reserve_area: [00d3600000, 00d7600000]   swiotlb buffer
[    0.000000]     lmb_reserve_area: [00d7e7e000, 00d7e9e000]     swiotlb list
[    0.000000]     lmb_reserve_area: [00d7e3e000, 00d7e7e000]  swiotlb orig_ad
[    0.000000]     lmb_reserve_area: [000008a000, 0000092000]  swiotlb overflo

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Becky Bruce <beckyb@kernel.crashing.org>
---
 lib/swiotlb.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 5fddf72..1bd4258 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -159,7 +159,7 @@ swiotlb_init_with_default_size(size_t default_size, int verbose)
 	/*
 	 * Get IO TLB memory from the low pages
 	 */
-	io_tlb_start = alloc_bootmem_low_pages(bytes);
+	io_tlb_start = alloc_bootmem_low_pages(PAGE_ALIGN(bytes));
 	if (!io_tlb_start)
 		panic("Cannot allocate SWIOTLB buffer");
 	io_tlb_end = io_tlb_start + bytes;
@@ -169,16 +169,16 @@ swiotlb_init_with_default_size(size_t default_size, int verbose)
 	 * to find contiguous free memory regions of size up to IO_TLB_SEGSIZE
 	 * between io_tlb_start and io_tlb_end.
 	 */
-	io_tlb_list = alloc_bootmem(io_tlb_nslabs * sizeof(int));
+	io_tlb_list = alloc_bootmem_pages(PAGE_ALIGN(io_tlb_nslabs * sizeof(int)));
 	for (i = 0; i < io_tlb_nslabs; i++)
  		io_tlb_list[i] = IO_TLB_SEGSIZE - OFFSET(i, IO_TLB_SEGSIZE);
 	io_tlb_index = 0;
-	io_tlb_orig_addr = alloc_bootmem(io_tlb_nslabs * sizeof(phys_addr_t));
+	io_tlb_orig_addr = alloc_bootmem_pages(PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t)));
 
 	/*
 	 * Get the overflow emergency buffer
 	 */
-	io_tlb_overflow_buffer = alloc_bootmem_low(io_tlb_overflow);
+	io_tlb_overflow_buffer = alloc_bootmem_low_pages(PAGE_ALIGN(io_tlb_overflow));
 	if (!io_tlb_overflow_buffer)
 		panic("Cannot allocate SWIOTLB overflow buffer!\n");
 	if (verbose)
@@ -304,13 +304,13 @@ void __init swiotlb_free(void)
 			   get_order(io_tlb_nslabs << IO_TLB_SHIFT));
 	} else {
 		free_bootmem_late(__pa(io_tlb_overflow_buffer),
-				  io_tlb_overflow);
+				  PAGE_ALIGN(io_tlb_overflow));
 		free_bootmem_late(__pa(io_tlb_orig_addr),
-				  io_tlb_nslabs * sizeof(phys_addr_t));
+				  PAGE_ALIGN(io_tlb_nslabs * sizeof(phys_addr_t)));
 		free_bootmem_late(__pa(io_tlb_list),
-				  io_tlb_nslabs * sizeof(int));
+				  PAGE_ALIGN(io_tlb_nslabs * sizeof(int)));
 		free_bootmem_late(__pa(io_tlb_start),
-				  io_tlb_nslabs << IO_TLB_SHIFT);
+				  PAGE_ALIGN(io_tlb_nslabs << IO_TLB_SHIFT));
 	}
 }
 
-- 
1.6.4.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -v12 00/39] use lmb with x86, Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 01/39] swiotlb: Use page alignment for early buffer ..., Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 02/39] x86: Add sanitize_e820_map(), Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 03/39] x86: Align e820 ram range to page, Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 04/39] lmb: Move lmb.c to mm/, Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 07/39] lmb: Add lmb_find_area(), Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 10/39] lmb: Add lmb_to_bootmem(), Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 11/39] lmb: Add get_free_all_memory_range(), Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 14/39] lmb: Add find_memory_core_early(), Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 22/39] x86, lmb: Add lmb_find_area_size(), Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 24/39] x86: Use lmb to replace early_res, Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 27/39] x86, lmb: turn off ARCH_LMB_FIND_AREA, Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 28/39] x86: Remove not used early_res code, Yinghai Lu, (Thu Apr 8, 11:03 pm)
[PATCH 32/39] x86: Add get_centaur_ram_top(), Yinghai Lu, (Thu Apr 8, 11:04 pm)
[PATCH 35/39] x86: make e820 to be __initdata, Yinghai Lu, (Thu Apr 8, 11:04 pm)
Re: [PATCH -v12 00/39] use lmb with x86, Benjamin Herrenschmidt, (Mon Apr 12, 8:41 pm)
Re: [PATCH 04/39] lmb: Move lmb.c to mm/, Benjamin Herrenschmidt, (Mon Apr 12, 8:52 pm)
Re: [PATCH 05/39] lmb: Seperate region array from lmb_regi ..., Benjamin Herrenschmidt, (Mon Apr 12, 8:56 pm)
Re: [PATCH 07/39] lmb: Add lmb_find_area(), Benjamin Herrenschmidt, (Mon Apr 12, 9:05 pm)
Re: [PATCH 08/39] lmb: Add lmb_reserve_area/lmb_free_area, Benjamin Herrenschmidt, (Mon Apr 12, 9:15 pm)
Re: [PATCH 26/39] nobootmem: use lmb.default_alloc_limit i ..., Benjamin Herrenschmidt, (Mon Apr 12, 9:23 pm)
Re: [PATCH 07/39] lmb: Add lmb_find_area(), Yinghai, (Mon Apr 12, 9:29 pm)
Re: [PATCH 07/39] lmb: Add lmb_find_area(), Benjamin Herrenschmidt, (Mon Apr 12, 10:07 pm)
Re: [PATCH 26/39] nobootmem: use lmb.default_alloc_limit i ..., Benjamin Herrenschmidt, (Mon Apr 12, 10:13 pm)
Re: [PATCH 07/39] lmb: Add lmb_find_area(), Yinghai, (Mon Apr 12, 10:26 pm)
Re: [PATCH 07/39] lmb: Add lmb_find_area(), H. Peter Anvin, (Mon Apr 12, 10:46 pm)
Re: [PATCH 07/39] lmb: Add lmb_find_area(), Benjamin Herrenschmidt, (Tue Apr 13, 3:15 am)