Re: [PATCH] eepc-wmi.c: Fix build error

Previous thread: INFO: task apache2:7601 blocked for more than 120 seconds. by Davide Ferrari on Wednesday, April 7, 2010 - 2:53 am. (1 message)

Next thread: PROBLEM + POSS FIX: kernel stack overflow, xfs, many disks, heavy write load, 8k stack, x86-64 by John Berthels on Wednesday, April 7, 2010 - 4:06 am. (17 messages)
From: Jan III Sobieski
Date: Wednesday, April 7, 2010 - 2:57 am

Hi,

  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `eeepc_wmi_notify':
/home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:86: undefined
reference to `sparse_keymap_report_event'
drivers/built-in.o: In function `eeepc_wmi_input_setup':
/home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:106: undefined
reference to `sparse_keymap_setup'
/home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:117: undefined
reference to `sparse_keymap_free'
drivers/built-in.o: In function `eeepc_wmi_init':
/home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:140: undefined
reference to `sparse_keymap_free'
drivers/built-in.o: In function `eeepc_wmi_exit':
/home/test/linux-2.6/drivers/platform/x86/eeepc-wmi.c:153: undefined
reference to `sparse_keymap_free'
make: *** [.tmp_vmlinux1] Błąd 1

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.34-rc3-git6
# Wed Apr  7 03:56:51 2010
#
CONFIG_64BIT=y
# CONFIG_X86_32 is not set
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_OUTPUT_FORMAT="elf64-x86-64"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/x86_64_defconfig"
CONFIG_GENERIC_TIME=y
CONFIG_GENERIC_CMOS_UPDATE=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_ZONE_DMA=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_GENERIC_GPIO=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
# CONFIG_RWSEM_GENERIC_SPINLOCK is not ...
From: Ingo Molnar
Date: Wednesday, April 7, 2010 - 7:22 am

-tip testing has triggered this bug too, see the fix below.

	Ingo

--------------------------->
From 763400ebb305711ebbd468c030db76d631400fe1 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 7 Apr 2010 16:15:51 +0200
Subject: [PATCH] eepc-wmi.c: Fix build error

-tip testing found:

eeepc-wmi.c:(.text+0x36673c): undefined reference to `sparse_keymap_report_event'
drivers/built-in.o: In function `eeepc_wmi_init':
eeepc-wmi.c:(.init.text+0x19cd0): undefined reference to `sparse_keymap_setup'
eeepc-wmi.c:(.init.text+0x19cf0): undefined reference to `sparse_keymap_free'
eeepc-wmi.c:(.init.text+0x19d0b): undefined reference to `sparse_keymap_free'
drivers/built-in.o: In function `eeepc_wmi_exit':
eeepc-wmi.c:(.exit.text+0x2e87): undefined reference to `sparse_keymap_free'

To fix this select INPUT_SPARSEKMAP, like the ASUS driver does.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/platform/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3046776..301e379 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -392,6 +392,7 @@ config EEEPC_WMI
 	depends on ACPI_WMI
 	depends on INPUT
 	depends on EXPERIMENTAL
+	select INPUT_SPARSEKMAP
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
 
--

From: Jan III Sobieski
Date: Wednesday, April 7, 2010 - 8:55 am

Works here. Thanks!




-- 
Jan III Sobieski
--

Previous thread: INFO: task apache2:7601 blocked for more than 120 seconds. by Davide Ferrari on Wednesday, April 7, 2010 - 2:53 am. (1 message)

Next thread: PROBLEM + POSS FIX: kernel stack overflow, xfs, many disks, heavy write load, 8k stack, x86-64 by John Berthels on Wednesday, April 7, 2010 - 4:06 am. (17 messages)