Home » Mailing list archives » linux-kernel » 2010 » April » 7

[PATCH 27/27] Staging: comedi: fix brace, print(k), indent and over 80 characters coding style issues in adv_pci_dio.c

Previous thread: [PATCH] btusb: Raw mode and ACL/SCO data by Kim B. Heino on Wednesday, April 7, 2010 - 5:53 am. (2 messages)

Next thread: [PATCH 2/8] sched: __wake_up_locked() exported by Michal Nazarewicz on Wednesday, April 7, 2010 - 6:41 am. (22 messages)
[view original message]
From: Maurice Dawson
Subject: [PATCH 27/27] Staging: comedi: fix brace, print(k), indent and over 80 characters coding style issues in adv_pci_dio.c
Date: Wednesday, April 7, 2010 - 6:12 am

This is a patch to the adv_pci_dio.c file that fixes up brace, print(k), indent and over 80 character warnings found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <mauricedawson2699@googlemail.com>
---
 drivers/staging/comedi/drivers/adv_pci_dio.c |  399 +++++++++++++++-----------
 1 files changed, 226 insertions(+), 173 deletions(-)

diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c b/drivers/staging/comedi/drivers/adv_pci_dio.c
index 61d35fe..b768ea5 100644
--- a/drivers/staging/comedi/drivers/adv_pci_dio.c
+++ b/drivers/staging/comedi/drivers/adv_pci_dio.c
@@ -8,8 +8,8 @@
 /*
 Driver: adv_pci_dio
 Description: Advantech PCI-1730, PCI-1733, PCI-1734, PCI-1736UP,
-             PCI-1750, PCI-1751, PCI-1752, PCI-1753/E, PCI-1754,
-             PCI-1756, PCI-1762
+		PCI-1750, PCI-1751, PCI-1752, PCI-1753/E, PCI-1754,
+		PCI-1756, PCI-1762
 Author: Michal Dobes <dobes@tesnet.cz>
 Devices: [Advantech] PCI-1730 (adv_pci_dio), PCI-1733,
   PCI-1734, PCI-1736UP, PCI-1750,
@@ -24,9 +24,8 @@ This driver supports now only insn interface for DI/DO/DIO.
 Configuration options:
   [0] - PCI bus of device (optional)
   [1] - PCI slot of device (optional)
-          If bus/slot is not specified, the first available PCI
-          device will be used.
-
+	If bus/slot is not specified, the first available PCI
+	device will be used.
 */
 
 #include "../comedidev.h"
@@ -64,41 +63,44 @@ enum hw_io_access {
 
 #define MAX_DI_SUBDEVS	2	/* max number of DI subdevices per card */
 #define MAX_DO_SUBDEVS	2	/* max number of DO subdevices per card */
-#define MAX_DIO_SUBDEVG	2	/* max number of DIO subdevices group per card */
+#define MAX_DIO_SUBDEVG	2
+			/* max number of DIO subdevices group per card */
 
 #define SIZE_8255	   4	/* 8255 IO space length */
 
 #define PCIDIO_MAINREG	   2	/* main I/O region for all Advantech cards? */
 
 /* Register offset definitions */
-/*  Advantech PCI-1730/3/4 */
+/* Advantech PCI-1730/3/4 */
 #define PCI1730_IDI	   0	/* R:   ...
[ message continues ]
[view original message]
From: Greg KH
Subject: Re: [PATCH 27/27] Staging: comedi: fix brace, print(k), indent and over 80 characters coding style issues in adv_pci_dio.c
Date: Thursday, April 8, 2010 - 12:40 pm

No, put the comment on the line above, not below it, that just confuses
things.

thanks,

greg k-h
--


[ message continues ]
Previous thread: [PATCH] btusb: Raw mode and ACL/SCO data by Kim B. Heino on Wednesday, April 7, 2010 - 5:53 am. (2 messages)

Next thread: [PATCH 2/8] sched: __wake_up_locked() exported by Michal Nazarewicz on Wednesday, April 7, 2010 - 6:41 am. (22 messages)