Re: linux-next: build failure after merge of the mfd tree

Previous thread: linux-next: manual merge of the pcmcia tree with the net tree by Stephen Rothwell on Tuesday, April 6, 2010 - 9:17 pm. (1 message)

Next thread: linux-next: build failure after merge of the mfd tree by Stephen Rothwell on Tuesday, April 6, 2010 - 10:02 pm. (3 messages)
From: Stephen Rothwell
Date: Tuesday, April 6, 2010 - 9:51 pm

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpio/janz-ttl.c: In function 'ttl_probe':
drivers/gpio/janz-ttl.c:158: error: implicit declaration of function 'kzalloc'
drivers/gpio/janz-ttl.c:158: warning: assignment makes pointer from integer without a cast
drivers/gpio/janz-ttl.c:210: error: implicit declaration of function 'kfree'

Caused by commit 989b68d7d885a45099126e32b46304afd9b3789e ("gpio: Add
support for Janz VMOD-TTL Digital IO module") interacting with commit
de380b55f92986c1a84198149cb71b7228d15fbd ("percpu: don't implicitly
include slab.h from percpu.h").

I applied the following fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 7 Apr 2010 14:47:52 +1000
Subject: [PATCH] gpio: janz-ttl: using kzalloc/kfree requires including slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpio/janz-ttl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpio/janz-ttl.c b/drivers/gpio/janz-ttl.c
index d97eeda..813ac07 100644
--- a/drivers/gpio/janz-ttl.c
+++ b/drivers/gpio/janz-ttl.c
@@ -17,6 +17,7 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
+#include <linux/slab.h>
 
 #include <linux/mfd/janz.h>
 
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
--

From: Samuel Ortiz
Date: Wednesday, April 7, 2010 - 1:52 am

Hi Stephen,

Sorry about that. That's fixed with the latest mfd tree.

Cheers,

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--

Previous thread: linux-next: manual merge of the pcmcia tree with the net tree by Stephen Rothwell on Tuesday, April 6, 2010 - 9:17 pm. (1 message)

Next thread: linux-next: build failure after merge of the mfd tree by Stephen Rothwell on Tuesday, April 6, 2010 - 10:02 pm. (3 messages)