Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dan Carpenter
Subject:
Date: Tuesday, April 6, 2010 - 9:45 am

Earlier in this function we set the last byte of "buf" to NULL so we 
always hit the break statement and "i" is never equal to NAME_MAX_LEN.  
This patch doesn't change how the driver works but it silences a Smatch 
warning and it makes it clearer that we don't write past the end of the 
array.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index ba8b670..01e6427 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
 	 * Now parse out the first token and use it as the name for the
 	 * driver to filter for.
 	 */
-	for (i = 0; i < NAME_MAX_LEN; ++i) {
+	for (i = 0; i < NAME_MAX_LEN - 1; ++i) {
 		current_driver_name[i] = buf[i];
 		if (isspace(buf[i]) || buf[i] == ' ' || buf[i] == 0)
 			break;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch] dma-debug: off by one issue, Joerg Roedel, (Sat Apr 3, 1:47 pm)
Re: [patch] dma-debug: off by one issue, Dan Carpenter, (Mon Apr 5, 5:53 am)
Re: [patch] dma-debug: off by one issue, Joerg Roedel, (Mon Apr 5, 7:02 am)
Re: [patch] dma-debug: off by one issue, Joerg Roedel, (Mon Apr 5, 7:09 am)
[No subject], Dan Carpenter, (Tue Apr 6, 9:45 am)
Re: [patch v2] dma-debug: cleanup for loop, Joerg Roedel, (Wed Apr 7, 3:05 am)