Home » Mailing list archives » linux-kernel » 2010 » April » 6

Re: [PATCH -mm 2/4] oom: select_bad_process: PF_EXITING check should take ->mm into account

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oleg Nesterov
Subject: Re: [PATCH -mm 2/4] oom: select_bad_process: PF_EXITING check should take ->mm into account
Date: Tuesday, April 6, 2010 - 6:38 am

On 04/06, anfei wrote:

Even if we forget about get_task_mm() which increments mm_users, it is not
clear to me how to do this check correctly.

Say, mm_users > 1 but SIGNAL_GROUP_EXIT is set. This means this process is
exiting and (ignoring CLONE_VM task) it is going to release its ->mm. But
otoh mm can be NULL.

Perhaps we can do

	if ((PF_EXITING && thread_group_empty(p) ||
	    (p->signal->flags & SIGNAL_GROUP_EXIT) {
		// OK, it is exiting

		bool has_mm = false;
		do {
			if (t->mm) {
				has_mm = true;
				break;
			}
		} while_each_thread(p, t);
			
		if (!has_mm)
			continue;

		if (p != current)
			return ERR_PTR(-1);
		...
	}

I dunno.

Oleg.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] oom killer: break from infinite loop, Anfei Zhou, (Wed Mar 24, 9:25 am)
Re: [PATCH] oom killer: break from infinite loop, KOSAKI Motohiro, (Wed Mar 24, 7:51 pm)
Re: [PATCH] oom killer: break from infinite loop, Andrew Morton, (Fri Mar 26, 3:08 pm)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Fri Mar 26, 3:33 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Sat Mar 27, 7:46 pm)
Re: [PATCH] oom killer: break from infinite loop, anfei, (Sun Mar 28, 7:55 am)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Sun Mar 28, 9:28 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Sun Mar 28, 2:21 pm)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Mon Mar 29, 4:21 am)
Re: [PATCH] oom killer: break from infinite loop, anfei, (Mon Mar 29, 4:31 am)
Re: [PATCH] oom killer: break from infinite loop, Oleg Nesterov, (Mon Mar 29, 4:46 am)
Re: [PATCH] oom killer: break from infinite loop, anfei, (Mon Mar 29, 5:09 am)
Re: [PATCH] oom killer: break from infinite loop, anfei, (Mon Mar 29, 7:06 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Mon Mar 29, 1:01 pm)
[patch] oom: give current access to memory reserves if it ..., David Rientjes, (Mon Mar 29, 1:49 pm)
Re: [PATCH] oom killer: break from infinite loop, anfei, (Tue Mar 30, 7:29 am)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Tue Mar 30, 8:46 am)
[PATCH] oom: fix the unsafe proc_oom_score()->badness() call, Oleg Nesterov, (Tue Mar 30, 9:39 am)
[PATCH -mm] proc: don't take ->siglock for /proc/pid/oom_adj, Oleg Nesterov, (Tue Mar 30, 10:43 am)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Tue Mar 30, 1:26 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Mar 30, 1:29 pm)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., David Rientjes, (Tue Mar 30, 1:30 pm)
Re: [PATCH] oom: fix the unsafe proc_oom_score()->badness( ..., David Rientjes, (Tue Mar 30, 1:32 pm)
Re: [PATCH] oom killer: break from infinite loop, KAMEZAWA Hiroyuki, (Tue Mar 30, 5:57 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Mar 30, 11:07 pm)
Re: [PATCH] oom killer: break from infinite loop, KAMEZAWA Hiroyuki, (Tue Mar 30, 11:13 pm)
Re: [PATCH] oom killer: break from infinite loop, Balbir Singh, (Tue Mar 30, 11:30 pm)
Re: [PATCH] oom killer: break from infinite loop, KAMEZAWA Hiroyuki, (Tue Mar 30, 11:31 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Mar 30, 11:32 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Wed Mar 31, 12:04 am)
Re: [PATCH] oom: fix the unsafe proc_oom_score()->badness( ..., Oleg Nesterov, (Wed Mar 31, 2:16 am)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., Oleg Nesterov, (Wed Mar 31, 2:17 am)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Wed Mar 31, 10:58 am)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., Oleg Nesterov, (Wed Mar 31, 11:59 am)
Re: [PATCH] oom: fix the unsafe proc_oom_score()->badness( ..., Oleg Nesterov, (Wed Mar 31, 1:17 pm)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Wed Mar 31, 1:47 pm)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Wed Mar 31, 2:07 pm)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., David Rientjes, (Wed Mar 31, 2:14 pm)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Wed Mar 31, 3:50 pm)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., Oleg Nesterov, (Wed Mar 31, 4:00 pm)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Wed Mar 31, 4:30 pm)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Wed Mar 31, 4:48 pm)
Re: [PATCH] oom: fix the unsafe proc_oom_score()->badness( ..., David Rientjes, (Thu Apr 1, 12:41 am)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Thu Apr 1, 1:25 am)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., David Rientjes, (Thu Apr 1, 1:32 am)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Thu Apr 1, 1:35 am)
[PATCH 0/1] oom: fix the unsafe usage of badness() in proc ..., Oleg Nesterov, (Thu Apr 1, 6:13 am)
[PATCH 1/1] oom: fix the unsafe usage of badness() in proc ..., Oleg Nesterov, (Thu Apr 1, 6:13 am)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Thu Apr 1, 7:00 am)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Thu Apr 1, 7:39 am)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Thu Apr 1, 8:26 am)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., Oleg Nesterov, (Thu Apr 1, 8:37 am)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Thu Apr 1, 11:58 am)
Re: [PATCH 1/1] oom: fix the unsafe usage of badness() in ..., David Rientjes, (Thu Apr 1, 12:03 pm)
Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/o ..., David Rientjes, (Thu Apr 1, 12:04 pm)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Thu Apr 1, 12:12 pm)
Re: [PATCH] oom killer: break from infinite loop, Mel Gorman, (Fri Apr 2, 3:17 am)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Fri Apr 2, 4:14 am)
[PATCH -mm 0/4] oom: linux has threads, Oleg Nesterov, (Fri Apr 2, 11:30 am)
[PATCH -mm 1/4] oom: select_bad_process: check PF_KTHREAD ..., Oleg Nesterov, (Fri Apr 2, 11:31 am)
[PATCH -mm 2/4] oom: select_bad_process: PF_EXITING check ..., Oleg Nesterov, (Fri Apr 2, 11:32 am)
[PATCH -mm 3/4] oom: introduce find_lock_task_mm() to fix ..., Oleg Nesterov, (Fri Apr 2, 11:32 am)
[PATCH -mm 4/4] oom: oom_forkbomb_penalty: move thread_gro ..., Oleg Nesterov, (Fri Apr 2, 11:33 am)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Fri Apr 2, 12:02 pm)
Re: [PATCH -mm 4/4] oom: oom_forkbomb_penalty: move thread ..., David Rientjes, (Fri Apr 2, 12:04 pm)
Re: [PATCH -mm 1/4] oom: select_bad_process: check PF_KTHR ..., David Rientjes, (Fri Apr 2, 12:05 pm)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Fri Apr 2, 12:14 pm)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Fri Apr 2, 12:46 pm)
[patch -mm] oom: exclude tasks with badness score of 0 fro ..., David Rientjes, (Fri Apr 2, 12:54 pm)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Fri Apr 2, 1:55 pm)
Re: [patch -mm] oom: exclude tasks with badness score of 0 ..., Oleg Nesterov, (Fri Apr 2, 2:04 pm)
[patch -mm v2] oom: exclude tasks with badness score of 0 ..., David Rientjes, (Fri Apr 2, 2:22 pm)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Sun Apr 4, 4:26 pm)
Re: [PATCH] oom killer: break from infinite loop, Mel Gorman, (Mon Apr 5, 3:47 am)
[PATCH -mm] oom: select_bad_process: never choose tasks wi ..., Oleg Nesterov, (Mon Apr 5, 7:23 am)
Re: [PATCH -mm 2/4] oom: select_bad_process: PF_EXITING ch ..., anfei, (Tue Apr 6, 4:42 am)
Re: [PATCH -mm 2/4] oom: select_bad_process: PF_EXITING ch ..., Oleg Nesterov, (Tue Apr 6, 5:18 am)
Re: [PATCH -mm 2/4] oom: select_bad_process: PF_EXITING ch ..., anfei, (Tue Apr 6, 6:05 am)
Re: [PATCH -mm 2/4] oom: select_bad_process: PF_EXITING ch ..., Oleg Nesterov, (Tue Apr 6, 6:38 am)
Re: [PATCH] oom killer: break from infinite loop, David Rientjes, (Tue Apr 6, 3:40 pm)
Re: [patch] oom: give current access to memory reserves if ..., David Rientjes, (Thu Apr 8, 2:08 pm)
Re: [patch] oom: give current access to memory reserves if ..., Oleg Nesterov, (Fri Apr 9, 5:38 am)