[patch] proc: copy_to_user() returns unsigned

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dan Carpenter
Date: Tuesday, April 6, 2010 - 3:45 am

copy_to_user() returns the number of bytes left to be copied.

This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363
"proc: pagemap: Hold mmap_sem during page walk".

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 0962739..bfb2773 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
 		start_vaddr = end;
 
 		len = min(count, PM_ENTRY_BYTES * pm.pos);
-		if (copy_to_user(buf, pm.buffer, len) < 0) {
+		if (copy_to_user(buf, pm.buffer, len)) {
 			ret = -EFAULT;
 			goto out_free;
 		}
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] proc: copy_to_user() returns unsigned, Dan Carpenter, (Tue Apr 6, 3:45 am)
Re: [patch] proc: copy_to_user() returns unsigned, Minchan Kim, (Tue Apr 6, 4:04 am)
Re: [patch] proc: copy_to_user() returns unsigned, KOSAKI Motohiro, (Tue Apr 6, 4:32 am)
[No subject], Matt Mackall, (Tue Apr 6, 8:17 am)