Home » Mailing list archives » linux-kernel » 2010 » April » 6

[PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Randy Dunlap
Subject: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE
Date: Monday, April 5, 2010 - 10:04 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

HID_PICOLCD should depend on LCD_CLASS_DEVICE, otherwise the
build fails when HID_PICOLCD=y and LCD_CLASS_DEVICE=m:

hid-picolcd.c:(.text+0x84523f): undefined reference to `lcd_device_unregister'
hid-picolcd.c:(.text+0x8478ab): undefined reference to `lcd_device_register'
hid-picolcd.c:(.text+0x84c15f): undefined reference to `lcd_device_unregister'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/hid/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2010-0405-1609.orig/drivers/hid/Kconfig
+++ mmotm-2010-0405-1609/drivers/hid/Kconfig
@@ -265,6 +265,7 @@ config HID_PETALYNX
 config HID_PICOLCD
 	tristate "PicoLCD (graphic version)"
 	depends on USB_HID
+	depends on LCD_CLASS_DEVICE
 	select FB_DEFERRED_IO if FB
 	select FB_SYS_FILLRECT if FB
 	select FB_SYS_COPYAREA if FB
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
mmotm 2010-04-05-16-09 uploaded, akpm, (Mon Apr 5, 4:09 pm)
[PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Randy Dunlap, (Mon Apr 5, 10:04 pm)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Jiri Kosina, (Tue Apr 6, 1:40 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Bruno =?UTF-8?B?UHLD ..., (Tue Apr 6, 1:56 am)
[No subject], Randy Dunlap, (Tue Apr 6, 8:26 am)
[No subject], Bruno , (Tue Apr 6, 9:35 am)
[No subject], Randy Dunlap, (Tue Apr 6, 9:56 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Bruno =?UTF-8?B?UHLD ..., (Tue Apr 6, 2:04 pm)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Randy Dunlap, (Wed Apr 7, 9:20 am)
Re: mmotm 2010-04-05-16-09 uploaded, Valdis.Kletnieks, (Wed Apr 7, 11:01 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Bruno =?UTF-8?B?UHLD ..., (Wed Apr 7, 11:31 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Bruno =?UTF-8?B?UHLD ..., (Wed Apr 7, 11:44 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Randy Dunlap, (Wed Apr 7, 1:12 pm)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Bruno =?UTF-8?B?UHLD ..., (Wed Apr 7, 1:29 pm)
Re: mmotm 2010-04-05-16-09 uploaded, Patrick McHardy, (Thu Apr 8, 4:41 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Jiri Kosina, (Thu Apr 8, 5:42 am)
Re: mmotm 2010-04-05-16-09 uploaded, Valdis.Kletnieks, (Thu Apr 8, 8:23 am)
Re: mmotm 2010-04-05-16-09 uploaded, Patrick McHardy, (Thu Apr 8, 8:36 am)
mmotm 2010-04-05 - another RCU whinge (not network this time), Valdis.Kletnieks, (Thu Apr 8, 4:57 pm)
Re: mmotm 2010-04-05-16-09 uploaded, Valdis.Kletnieks, (Thu Apr 8, 5:50 pm)
Re: mmotm 2010-04-05-16-09 uploaded, Patrick McHardy, (Fri Apr 9, 7:49 am)
Re: mmotm 2010-04-05 - another RCU whinge (not network thi ..., Paul E. McKenney, (Fri Apr 9, 4:16 pm)
Re: mmotm 2010-04-05 - another RCU whinge (not network thi ..., Valdis.Kletnieks, (Fri Apr 9, 8:22 pm)
Re: mmotm 2010-04-05 - another RCU whinge (not network thi ..., Paul E. McKenney, (Fri Apr 9, 10:15 pm)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Bruno Prémont, (Sun Apr 11, 3:17 am)
Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE, Jiri Kosina, (Sun Apr 11, 11:28 am)
Re: mmotm 2010-04-05 - another RCU whinge (not network thi ..., Oleg Nesterov, (Mon Apr 12, 11:32 am)