Re: [PATCH 1/4] Add targets to use the Coccinelle checker

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Randy Dunlap

Subject: Re: [PATCH 1/4] Add targets to use the Coccinelle checker

Date: Friday, April 30, 2010 - 2:07 pm

On Thu, 29 Apr 2010 10:01:54 -0700 Roland Dreier wrote:

quoted text>  > > +		"Take particularly attention when using the \"patch\" mode\n"\
>  > 
>  > 		      particular
> 
> Actually, "take particular attention" is not particularly grammatical.
> I might phrase this as
> 
>   Be especially careful when using the "patch" mode to review the patch
>   you are about to submit.

Yes, or:

    When using "patch" mode, carefully review the patch before submitting it.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/4] Add a Coccinelle front-end script, Nicolas Palix, (Mon Apr 26, 2:11 pm)

[PATCH 1/4] Add targets to use the Coccinelle checker, Nicolas Palix, (Mon Apr 26, 2:11 pm)

[PATCH 2/4] Add scripts/smpl/drop_kmalloc_cast.cocci, Nicolas Palix, (Mon Apr 26, 2:11 pm)

[PATCH 3/4] Add scripts/smpl/kzalloc-simple.cocci, Nicolas Palix, (Mon Apr 26, 2:11 pm)

[PATCH 4/4] Add scripts/smpl/resource_size.cocci, Nicolas Palix, (Mon Apr 26, 2:11 pm)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Joe Perches, (Mon Apr 26, 2:37 pm)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Nicolas Palix, (Mon Apr 26, 3:20 pm)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Randy Dunlap, (Mon Apr 26, 3:23 pm)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Michal Marek, (Tue Apr 27, 5:40 am)

Re: [PATCH 0/4] Add a Coccinelle front-end script, Wolfram Sang, (Tue Apr 27, 5:50 am)

Re: [PATCH 0/4] Add a Coccinelle front-end script, Julia Lawall, (Tue Apr 27, 5:53 am)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Wolfram Sang, (Tue Apr 27, 5:53 am)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Michal Marek, (Tue Apr 27, 6:01 am)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Sam Ravnborg, (Tue Apr 27, 1:24 pm)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Sam Ravnborg, (Tue Apr 27, 1:28 pm)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Roland Dreier, (Thu Apr 29, 10:01 am)

Re: [PATCH 1/4] Add targets to use the Coccinelle checker, Randy Dunlap, (Fri Apr 30, 2:07 pm)


linux-kernel:
Fortier,Vincent [Montreal]	2.6.21.5 june 30th to july 1st date hang?
Jeff Dike	[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood	[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov	Re: Getting the new RxRPC patches upstream
Stefan Seyfried	Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev:
Arnaud Ebalard	Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt	Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior	[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller	Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git:
Jakub Narebski	Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey	Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder	[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra	Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano	Re: git-rm isn't the inverse action of git-add
openbsd-misc:
Joachim Schipper	Re: UVC Webcams
Florin Andrei	SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith	Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan	Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.	Re: Real men don't attack straw men
git-commits-head:
Linux Kernel Mailing List	ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List	m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List	[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List	[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List	mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()