Home » Mailing list archives » linux-kernel » 2010 » April » 30

Re: [PATCH] Inotify: Fix build failure in inotify user support

Previous thread: Re: Upstream first policy by James Kosin on Monday, March 8, 2010 - 12:40 pm. (1 message)

Next thread: [PATCH 1/2] Staging: rar: fixed various style issues in rar_driver.c by Eric Anschuetz on Monday, March 8, 2010 - 1:02 pm. (2 messages)
[view original message]
From: Ralf Baechle
Subject: [PATCH] Inotify: Fix build failure in inotify user support
Date: Monday, March 8, 2010 - 12:51 pm

CONFIG_INOTIFY_USER defined but CONFIG_ANON_INODES undefined will result
in the following build failure:

  LD      vmlinux
fs/built-in.o: In function 'sys_inotify_init1':
(.text.sys_inotify_init1+0x22c): undefined reference to 'anon_inode_getfd'
fs/built-in.o: In function `sys_inotify_init1':
(.text.sys_inotify_init1+0x22c): relocation truncated to fit: R_MIPS_26 against 'anon_inode_getfd'
make[2]: *** [vmlinux] Error 1
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@linux-kernel.org

 fs/notify/inotify/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/notify/inotify/Kconfig b/fs/notify/inotify/Kconfig
index 3e56dbf..b3a159b 100644
--- a/fs/notify/inotify/Kconfig
+++ b/fs/notify/inotify/Kconfig
@@ -15,6 +15,7 @@ config INOTIFY
 
 config INOTIFY_USER
 	bool "Inotify support for userspace"
+	select ANON_INODES
 	select FSNOTIFY
 	default y
 	---help---
--


[ message continues ]
[view original message]
From: Ralf Baechle
Subject: Re: [PATCH] Inotify: Fix build failure in inotify user support
Date: Friday, April 30, 2010 - 10:04 am

Ping.  The problem still exists in rc6.

  Ralf
--


[ message continues ]
[view original message]
From: Florian Fainelli
Subject: Re: [PATCH] Inotify: Fix build failure in inotify user support
Date: Tuesday, May 4, 2010 - 1:09 am

Hi,


Ralf's patch fixes the issue for me.

--


[ message continues ]
Previous thread: Re: Upstream first policy by James Kosin on Monday, March 8, 2010 - 12:40 pm. (1 message)

Next thread: [PATCH 1/2] Staging: rar: fixed various style issues in rar_driver.c by Eric Anschuetz on Monday, March 8, 2010 - 1:02 pm. (2 messages)