[PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Chris Wright
Date: Friday, April 2, 2010 - 6:27 pm

This effectively reverts commit 61d047be99757fd9b0af900d7abce9a13a337488.

Disabling the IOMMU can potetially allow DMA transactions to
complete without being translated.  Leave it enabled, and allow
crash kernel to do the IOMMU reinitialization properly.

Cc: Joerg Roedel <joerg.roedel@amd.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---
 arch/x86/kernel/crash.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -27,7 +27,6 @@
 #include <asm/cpu.h>
 #include <asm/reboot.h>
 #include <asm/virtext.h>
-#include <asm/x86_init.h>
 
 #if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC)
 
@@ -103,10 +102,5 @@ void native_machine_crash_shutdown(struc
 #ifdef CONFIG_HPET_TIMER
 	hpet_disable();
 #endif
-
-#ifdef CONFIG_X86_64
-	x86_platform.iommu_shutdown();
-#endif
-
 	crash_save_cpu(regs, safe_smp_processor_id());
 }

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/4] AMD IOMMU kdump fix plus cleanups (v2), Chris Wright, (Fri Apr 2, 6:27 pm)
[PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash", Chris Wright, (Fri Apr 2, 6:27 pm)
[PATCH 4/4] x86/amd-iommu: use for_each_pci_dev, Chris Wright, (Fri Apr 2, 6:27 pm)
[No subject], Chris Wright, (Tue Apr 6, 10:42 am)
[No subject], Joerg Roedel, (Tue Apr 6, 10:51 am)
Re: [PATCH 0/4] AMD IOMMU kdump fix plus cleanups (v2), Joerg Roedel, (Wed Apr 7, 3:05 am)