Home » Mailing list archives » linux-kernel » 2010 » April » 3

Re: [PATCH] mtd/maps/physmap: catch failure to register MTD_PHYSMAP_COMPAT device

Previous thread: Re: [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode by tytso on Friday, April 2, 2010 - 2:48 pm. (1 message)

Next thread: none
[view original message]
From: H Hartley Sweeten
Subject: [PATCH] mtd/maps/physmap: catch failure to register MTD_PHYSMAP_COMPAT device
Date: Friday, April 2, 2010 - 3:46 pm

If the default Kconfig values are used with MTD_PHYSMAP_COMPAT you end
up with a resource where end < start.  This causes __request_resource to
return a conflict which then returns an -EBUSY error code.  The current
physmap.c code just assumes that the platfom_device_register will always
succeed.

Catch this failure during the physmap_init and propogate the error.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>

---

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index d9603f7..426461a 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -264,8 +264,11 @@ static int __init physmap_init(void)
 
 	err = platform_driver_register(&physmap_flash_driver);
 #ifdef CONFIG_MTD_PHYSMAP_COMPAT
-	if (err == 0)
-		platform_device_register(&physmap_flash);
+	if (err == 0) {
+		err = platform_device_register(&physmap_flash);
+		if (err)
+			platform_driver_unregister(&physmap_flash_driver);
+	}
 #endif
 
 	return err;

[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH] mtd/maps/physmap: catch failure to register MTD_PHYSMAP_COMPAT device
Date: Friday, April 2, 2010 - 6:09 pm

Thanks, Hartley.



---
~Randy
--


[ message continues ]
Previous thread: Re: [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode by tytso on Friday, April 2, 2010 - 2:48 pm. (1 message)

Next thread: none