Re: mmotm 2010-04-28-16-53 uploaded

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Valdis.Kletnieks
Date: Thursday, April 29, 2010 - 2:32 pm

On Wed, 28 Apr 2010 16:53:32 PDT, akpm@linux-foundation.org said:

Dies trying to compile mm/slab.c because something screwed the pooch with
the definition of numa_mem_id(). My bets are on
numa-slab-use-numa_mem_id-for-slab-local-memory-node.patch

  CC      mm/slab.o
mm/slab.c: In function 'kmem_cache_init':
mm/slab.c:1506: error: 'numa_node' undeclared (first use in this function)
mm/slab.c:1506: error: (Each undeclared identifier is reported only once
mm/slab.c:1506: error: for each function it appears in.)
mm/slab.c:1506: warning: type defaults to 'int' in declaration of 'pscr_ret__'
mm/slab.c:1506: warning: type defaults to 'int' in declaration of 'type name'
mm/slab.c:1506: warning: cast from pointer to integer of different size
mm/slab.c:1506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:1506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:1506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:1506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c: In function 'setup_cpu_cache':
mm/slab.c:2148: error: 'numa_node' undeclared (first use in this function)
mm/slab.c:2148: warning: type defaults to 'int' in declaration of 'pscr_ret__'
mm/slab.c:2148: warning: type defaults to 'int' in declaration of 'type name'
mm/slab.c:2148: warning: cast from pointer to integer of different size
mm/slab.c:2148: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:2148: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:2148: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:2148: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c: In function 'do_drain':
mm/slab.c:2506: error: 'numa_node' undeclared (first use in this function)
mm/slab.c:2506: warning: type defaults to 'int' in declaration of 'pscr_ret__'
mm/slab.c:2506: warning: type defaults to 'int' in declaration of 'type name'
mm/slab.c:2506: warning: cast from pointer to integer of different size
mm/slab.c:2506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:2506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:2506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:2506: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c: In function 'cache_alloc_refill':
mm/slab.c:3039: error: 'numa_node' undeclared (first use in this function)
mm/slab.c:3039: warning: type defaults to 'int' in declaration of 'pscr_ret__'
mm/slab.c:3039: warning: type defaults to 'int' in declaration of 'type name'
mm/slab.c:3039: warning: cast from pointer to integer of different size
mm/slab.c:3039: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:3039: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:3039: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:3039: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c: In function 'cache_flusharray':
mm/slab.c:3575: error: 'numa_node' undeclared (first use in this function)
mm/slab.c:3575: warning: type defaults to 'int' in declaration of 'pscr_ret__'
mm/slab.c:3575: warning: type defaults to 'int' in declaration of 'type name'
mm/slab.c:3575: warning: cast from pointer to integer of different size
mm/slab.c:3575: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:3575: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:3575: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:3575: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c: In function 'cache_reap':
mm/slab.c:4139: error: 'numa_node' undeclared (first use in this function)
mm/slab.c:4139: warning: type defaults to 'int' in declaration of 'pscr_ret__'
mm/slab.c:4139: warning: type defaults to 'int' in declaration of 'type name'
mm/slab.c:4139: warning: cast from pointer to integer of different size
mm/slab.c:4139: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:4139: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:4139: warning: type defaults to 'int' in declaration of 'pfo_ret__'
mm/slab.c:4139: warning: type defaults to 'int' in declaration of 'pfo_ret__'
make[1]: *** [mm/slab.o] Error 1
make: *** [mm] Error 2

line 1506: node = numa_mem_id();
line 2148: cachep->nodelists[numa_mem_id()]->next_reap =
line 2506: int node = numa_mem_id();
line 3039: node = numa_mem_id();
line 3575: int node = numa_mem_id();
line 3139: int node = numa_mem_id();

Looks like a twisty little maze of cpp macros in each case, probably
related to this:

% grep -i numa .config
# CONFIG_NUMA is not set
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
mmotm 2010-04-28-16-53 uploaded, akpm, (Wed Apr 28, 4:53 pm)
Re: mmotm 2010-04-28-16-53 uploaded, Valdis.Kletnieks, (Thu Apr 29, 2:32 pm)
Re: mmotm 2010-04-28-16-53 uploaded, Andrew Morton, (Thu Apr 29, 2:53 pm)
Re: mmotm 2010-04-28-16-53 uploaded, Andrew Morton, (Thu Apr 29, 3:00 pm)
Re: mmotm 2010-04-28-16-53 uploaded, Lee Schermerhorn, (Fri Apr 30, 5:11 am)
Re: mmotm 2010-04-28-16-53 uploaded, Lee Schermerhorn, (Fri Apr 30, 11:02 am)
Re: mmotm 2010-04-28-16-53 uploaded, Valdis.Kletnieks, (Fri Apr 30, 11:47 am)
Re: mmotm 2010-04-28-16-53 uploaded, Lee Schermerhorn, (Fri Apr 30, 12:05 pm)
mmotm 2010-04-28 - nouveau driver issues, Valdis.Kletnieks, (Sun May 2, 10:38 am)
mmotm 2010-04-28 - RCU whinges, Valdis.Kletnieks, (Sun May 2, 10:46 am)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Sun May 2, 10:38 pm)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Sun May 2, 10:41 pm)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Sun May 2, 10:43 pm)
Re: mmotm 2010-04-28 - RCU whinges, David Miller, (Sun May 2, 10:55 pm)
Re: mmotm 2010-04-28 - RCU whinges, Valdis.Kletnieks, (Mon May 3, 7:30 am)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Mon May 3, 7:48 am)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Mon May 3, 7:58 am)
Re: mmotm 2010-04-28 - RCU whinges, Valdis.Kletnieks, (Mon May 3, 8:29 am)
Re: mmotm 2010-04-28 - RCU whinges, Paul E. McKenney, (Mon May 3, 8:43 am)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Mon May 3, 9:14 am)
Re: mmotm 2010-04-28 - RCU whinges, Paul E. McKenney, (Mon May 3, 11:16 am)
[PATCH net-next-2.6] net: if6_get_next() fix, Eric Dumazet, (Mon May 3, 12:46 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, David Miller, (Mon May 3, 1:09 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, Eric Dumazet, (Mon May 3, 1:13 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, David Miller, (Mon May 3, 1:24 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, Eric Dumazet, (Mon May 3, 1:50 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, David Miller, (Mon May 3, 3:17 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, Paul E. McKenney, (Mon May 3, 3:48 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, Paul E. McKenney, (Mon May 3, 3:52 pm)
Re: [PATCH net-next-2.6] net: if6_get_next() fix, David Miller, (Mon May 3, 3:54 pm)
Re: mmotm 2010-04-28 - RCU whinges, Patrick McHardy, (Mon May 10, 8:40 am)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Mon May 10, 8:56 am)
Re: mmotm 2010-04-28 - RCU whinges, Eric Dumazet, (Mon May 10, 8:57 am)
Re: mmotm 2010-04-28 - RCU whinges, Paul E. McKenney, (Mon May 10, 8:57 am)
Re: mmotm 2010-04-28 - RCU whinges, Patrick McHardy, (Mon May 10, 9:03 am)
Re: mmotm 2010-04-28 - RCU whinges, Patrick McHardy, (Mon May 10, 9:04 am)
Re: mmotm 2010-04-28 - RCU whinges, David Miller, (Mon May 10, 9:12 am)
Re: mmotm 2010-04-28 - RCU whinges, Patrick McHardy, (Mon May 10, 9:27 am)
Re: mmotm 2010-04-28 - RCU whinges, Patrick McHardy, (Mon May 10, 9:53 am)