Home » Mailing list archives » linux-kernel » 2010 » April » 29

Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrea Arcangeli
Subject: Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks
Date: Thursday, April 29, 2010 - 9:21 am

Hi Mel,

did you see my proposed fix? I'm running with it applied, I'd be
interested if you can test it. Surely it will also work for new
anon-vma code in upstream, because at that point there's just 1
anon-vma and nothing else attached to the vma.

http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git;a=commit;h=6efa1dfa5152ef8d7f2...

I think it's wrong to try to handle the race in rmap walk by making
magic checks on vm_flags VM_GROWSDOWN|GROWSUP and
vma->vm_mm->map_count == 1, when we can fix it fully and simply in
exec.c by indexing two vmas in the same anon-vma with a different
vm_start so the pages will be found at all times by the rmap_walk.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 2/2] mm,migration: Avoid race between shift_arg_pag ..., Mel Gorman, (Thu Apr 29, 1:32 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Thu Apr 29, 9:21 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Fri Apr 30, 12:22 pm)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Rik van Riel, (Fri Apr 30, 1:21 pm)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Sat May 1, 2:39 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Rik van Riel, (Sat May 1, 6:02 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Christoph Lameter, (Sat May 1, 6:56 pm)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Minchan Kim, (Sun May 2, 10:40 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Sun May 2, 11:20 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Mel Gorman, (Tue May 4, 2:45 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Mel Gorman, (Tue May 4, 3:32 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Tue May 4, 5:56 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Mel Gorman, (Tue May 4, 7:33 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Tue May 4, 7:44 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Christoph Lameter, (Mon May 10, 10:41 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Mel Gorman, (Mon May 10, 10:56 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Mon May 10, 12:05 pm)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., KAMEZAWA Hiroyuki, (Mon May 10, 5:10 pm)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Christoph Lameter, (Tue May 11, 6:59 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Mel Gorman, (Tue May 11, 8:11 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Christoph Lameter, (Tue May 11, 8:56 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Mel Gorman, (Tue May 11, 9:15 am)
Re: [PATCH 2/2] mm,migration: Avoid race between shift_arg ..., Andrea Arcangeli, (Tue May 11, 9:29 am)