Home » Mailing list archives » linux-kernel » 2010 » April » 29

Re: [PATCH 24/30] viafb: Add a driver for the video capture engine

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jonathan Corbet
Subject: Re: [PATCH 24/30] viafb: Add a driver for the video capture engine
Date: Thursday, April 29, 2010 - 12:06 pm

On Thu, 29 Apr 2010 19:16:24 +0200
Bruno Prémont <bonbons@linux-vserver.org> wrote:


I think you're right, yes.  (As noted above, the camera driver isn't
quite ready for merging yet - but I can't swear I would have caught
this one, so I'm glad you did).


That's a little harder - the platform device is the means by which the
camera and the core communicate.  I guess I could add a general "I'm a
via-core subdev and I'm here now" exported function in the core, but
I'm not sure that would be better than just having the platform dev be
there.

But it definitely shouldn't be around if the camera is configured out.

Thanks,

jon
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC] Second OLPC Viafb series, v2, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 01/30] viafb: Fix various resource leaks during mod ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 02/30] viafb: use proper pci config API, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 03/30] viafb: Unmap the frame buffer on initializat ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 04/30] viafb: Retain GEMODE reserved bits, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 05/30] viafb: Unify duplicated set_bpp() code, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 06/30] viafb: Determine type of 2D engine and store ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 07/30] viafb: complete support for VX800/VX855 acce ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 08/30] viafb: Add 1200x900 DCON/LCD panel modes for ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 09/30] viafb: rework the I2C support in the VIA fra ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 10/30] suppress verbose debug messages: change prin ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 11/30] viafb: Only establish i2c busses on ports th ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 12/30] viafb: Move core stuff into via-core.c, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 13/30] viafb: Separate global and fb-specific data, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 14/30] viafb: add a driver for GPIO lines, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 15/30] viafb: package often used basic io functions, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 16/30] viafb: Convert GPIO and i2c to the new index ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 17/30] viafb: Turn GPIO and i2c into proper platfor ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 18/30] via: Do not attempt I/O on inactive I2C adapters, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 19/30] viafb: Introduce viafb_find_i2c_adapter(), Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 20/30] via: Rationalize vt1636 detection, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 21/30] viafb: Add a simple interrupt management inf ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 22/30] viafb: Add a simple VX855 DMA engine driver, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 23/30] viafb: Reserve framebuffer memory for the up ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 24/30] viafb: Add a driver for the video capture engine, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 25/30] viafb: unify modesetting functions, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 26/30] viafb: move some modesetting functions to a ..., Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 27/30] viafb: replace inb/outb, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 28/30] viafb: improve misc register handling, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 29/30] viafb: fix proc entry removal, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
[PATCH 30/30] viafb: make procfs entries optional, Jonathan Corbet, (Wed Apr 28, 3:17 pm)
Re: [PATCH 24/30] viafb: Add a driver for the video captur ..., Bruno Prémont, (Thu Apr 29, 10:16 am)
Re: [RFC] Second OLPC Viafb series, v2, Bruno Prémont, (Thu Apr 29, 10:26 am)
Re: [PATCH 13/30] viafb: Separate global and fb-specific data, Bruno Prémont, (Thu Apr 29, 11:19 am)
Re: [PATCH 24/30] viafb: Add a driver for the video captur ..., Jonathan Corbet, (Thu Apr 29, 12:06 pm)
Re: [RFC] Second OLPC Viafb series, v2, Jonathan Corbet, (Fri Apr 30, 8:39 am)
Re: [PATCH 13/30] viafb: Separate global and fb-specific data, Jonathan Corbet, (Fri Apr 30, 9:21 am)
Re: [PATCH 13/30] viafb: Separate global and fb-specific data, Florian Tobias Schan ..., (Fri Apr 30, 11:07 am)
Re: [PATCH 13/30] viafb: Separate global and fb-specific data, Jonathan Corbet, (Fri Apr 30, 11:22 am)
Re: [PATCH 13/30] viafb: Separate global and fb-specific data, Florian Tobias Schan ..., (Fri Apr 30, 11:43 am)
Re: [PATCH 13/30] viafb: Separate global and fb-specific data, Bruno Prémont, (Fri Apr 30, 1:01 pm)
Re: [PATCH 02/30] viafb: use proper pci config API, Florian Tobias Schan ..., (Sat May 1, 7:01 am)
Re: [PATCH 12/30] viafb: Move core stuff into via-core.c, Florian Tobias Schan ..., (Sat May 1, 8:02 am)
Re: [PATCH 12/30] viafb: Move core stuff into via-core.c, Jonathan Corbet, (Sat May 1, 8:08 am)
Re: [PATCH 12/30] viafb: Move core stuff into via-core.c, Florian Tobias Schan ..., (Sat May 1, 8:29 am)
Re: [RFC] Second OLPC Viafb series, v2, Florian Tobias Schan ..., (Sat May 1, 2:28 pm)
Re: [RFC] Second OLPC Viafb series, v2, Jonathan Corbet, (Sat May 1, 3:57 pm)
Re: [PATCH 24/30] viafb: Add a driver for the video captur ..., Florian Tobias Schan ..., (Sat May 1, 6:18 pm)
Re: [PATCH 24/30] viafb: Add a driver for the video captur ..., Jonathan Corbet, (Sat May 1, 6:52 pm)
Re: [PATCH 02/30] viafb: use proper pci config API, Jonathan Corbet, (Mon May 3, 7:37 pm)