linux-next: build warning after merge of the driver-core.current tree

Previous thread: Linux 2.6.34-rc6 by Linus Torvalds on Thursday, April 29, 2010 - 8:18 pm. (1 message)

Next thread: [BUG] perf: perf trace does not work anymore by Stephane Eranian on Thursday, April 29, 2010 - 5:28 am. (3 messages)
From: Stephen Rothwell
Date: Thursday, April 29, 2010 - 4:35 pm

Hi Grant,

After merging the driver-core.current tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:

drivers/base/firmware_class.c: In function 'release_firmware':
drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'

Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
("firmware_class: fix memory leak - free allocated pages").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell
Date: Thursday, April 29, 2010 - 5:01 pm

Hi Greg,


Excellent, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Greg KH
Date: Thursday, April 29, 2010 - 4:43 pm

Thanks, I've fixed this up, the release call should not have 'const'
on it as it is going to touch the pointer passed to it :)

thanks,

greg k-h
--

From: Greg KH
Date: Thursday, April 29, 2010 - 4:45 pm

And it's now pushed out in my tree.

thanks,

greg k-h
--

Previous thread: Linux 2.6.34-rc6 by Linus Torvalds on Thursday, April 29, 2010 - 8:18 pm. (1 message)

Next thread: [BUG] perf: perf trace does not work anymore by Stephane Eranian on Thursday, April 29, 2010 - 5:28 am. (3 messages)