Home » Mailing list archives » linux-kernel » 2010 » April » 28

[PATCH 0/3] ipc/sem.c: Optimization for reducing spinlock contention

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Manfred Spraul
Subject: [PATCH 0/3] ipc/sem.c: Optimization for reducing spinlock contention
Date: Wednesday, April 28, 2010 - 12:06 pm

Hi,

I've cleaned up the patches I sent a week ago:
- they pass now checkpatch.pl
- some comments updated/added
- a bug with semctl(,,SETALL,) is fixed
- tested against LTP

Andrew: Could you add them the next -mm?

The following series of patches tries to fix the spinlock contention
reported by Chris Manson: His benchmark exposes problems of the current
code:

- In the worst case, the algorithm used by update_queue() is O(N^2).
  Bulk wake-up calls can enter this worst case.
  The patch series fix that.
  Note that the benchmark app doesn't expose the problem, it just should
  be fixed: Real world apps might do the wake-ups in another order
  than perfect FIFO.

- The part of the code that runs within the semaphore array spinlock
  is significantly larger than necessary.
  The patch series fixes that. This change is responsible for the
  main improvement.

- The cacheline with the spinlock is also used for a variable that
  is read in the hot path (sem_base) and for a variable that is
  unnecessarily written to multiple times (sem_otime).
  The last step of the series cacheline-aligns the spinlock.

--
	Manfred
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] ipc/sem.c: Optimization for reducing spinlock ..., Manfred Spraul, (Wed Apr 28, 12:06 pm)
[PATCH 1/2] ipc/sem.c: Optimize update_queue() for bulk wa ..., Manfred Spraul, (Wed Apr 28, 12:06 pm)
[PATCH 2/2] ipc/sem.c: move wake_up_process out of the spi ..., Manfred Spraul, (Wed Apr 28, 12:06 pm)
[PATCH 3/3] [PATCH] ipc/sem.c: cacheline align the ipc spi ..., Manfred Spraul, (Wed Apr 28, 12:06 pm)
Re: [PATCH 2/2] ipc/sem.c: move wake_up_process out of the ..., Andrew Morton, (Tue May 11, 2:21 pm)
Re: [PATCH 2/2] ipc/sem.c: move wake_up_process out of the ..., Manfred Spraul, (Wed May 12, 10:34 am)
Re: [PATCH 2/2] ipc/sem.c: move wake_up_process out of the ..., Manfred Spraul, (Wed May 12, 11:18 am)