[PATCH 1/2] mn10300: Don't warn that atomic_t is only 24 bit

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Peter Fritzsche
Date: Wednesday, April 28, 2010 - 3:50 am

32-bit Sparc used to only allow usage of 24-bit of it's atomic_t type.
This was corrected with linux 2.6.3 when Keith M Wesolowski changed the
implementation to use the parisc approach of having an array of
spinlocks to protect the atomic_t.

These warnings were also removed from the sparc implementation when the
new implementation was merged in BKrev:402e4949VThdc6D3iaosSFUgabMfvw,
but the warning still remained in some other places without any
24-bit-only atomic_t implementation inside the kernel.

We should remove these warnings to allow users to rely on the full
32-bit range of atomic_t.

Signed-off-by: Peter Fritzsche <peter.fritzsche@gmx.de>
---
 This should correct the problem mentioned in http://lkml.org/lkml/2010/4/26/33

 arch/mn10300/include/asm/atomic.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/mn10300/include/asm/atomic.h b/arch/mn10300/include/asm/atomic.h
index 5bf5be9..5b58ff8 100644
--- a/arch/mn10300/include/asm/atomic.h
+++ b/arch/mn10300/include/asm/atomic.h
@@ -28,8 +28,7 @@
  * atomic_read - read atomic variable
  * @v: pointer of type atomic_t
  *
- * Atomically reads the value of @v.  Note that the guaranteed
- * useful range of an atomic_t is only 24 bits.
+ * Atomically reads the value of @v.
  */
 #define atomic_read(v)	((v)->counter)
 
@@ -38,8 +37,7 @@
  * @v: pointer of type atomic_t
  * @i: required value
  *
- * Atomically sets the value of @v to @i.  Note that the guaranteed
- * useful range of an atomic_t is only 24 bits.
+ * Atomically sets the value of @v to @i.
  */
 #define atomic_set(v, i) (((v)->counter) = (i))
 
@@ -51,7 +49,6 @@
  * @v: pointer of type atomic_t
  *
  * Atomically adds @i to @v and returns the result
- * Note that the guaranteed useful range of an atomic_t is only 24 bits.
  */
 static inline int atomic_add_return(int i, atomic_t *v)
 {
@@ -73,7 +70,6 @@ static inline int atomic_add_return(int i, atomic_t *v)
  * @v: pointer of type atomic_t
  *
  * Atomically subtracts @i from @v and returns the result
- * Note that the guaranteed useful range of an atomic_t is only 24 bits.
  */
 static inline int atomic_sub_return(int i, atomic_t *v)
 {
-- 
1.7.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2] mn10300: Don't warn that atomic_t is only 24 bit, Peter Fritzsche, (Wed Apr 28, 3:50 am)
Re: [PATCH 2/2] asm-generic: Don't warn that atomic_t is o ..., Mathieu Desnoyers, (Wed Apr 28, 6:54 am)
Re: [PATCH 2/2] asm-generic: Don't warn that atomic_t is o ..., Mathieu Desnoyers, (Wed Apr 28, 9:27 am)
Re: [PATCH 2/2] asm-generic: Don't warn that atomic_t is o ..., Mathieu Desnoyers, (Thu Apr 29, 2:10 pm)