Re: [v4 Patch 3/3] bonding: make bonding support netpoll

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Cong Wang

Subject: Re: [v4 Patch 3/3] bonding: make bonding support netpoll

Date: Tuesday, April 27, 2010 - 7:08 pm

David Miller wrote:
quoted text> From: Amerigo Wang <amwang@redhat.com>
> Date: Tue, 27 Apr 2010 03:56:09 -0400
> 
>> +		if ((slave->dev->priv_flags & IFF_DISABLE_NETPOLL)
>> +				|| !slave->dev->netdev_ops->ndo_poll_controller)
> 
> "|| on first line please, plus fix second line's indentation as per
> comments given in patch #1 and #2

Thanks, David!
I will fix all of this style problem.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[v4 Patch 1/3] netpoll: add generic support for bridge and ..., Amerigo Wang, (Tue Apr 27, 12:55 am)

[v4 Patch 2/3] bridge: make bridge support netpoll, Amerigo Wang, (Tue Apr 27, 12:55 am)

[v4 Patch 3/3] bonding: make bonding support netpoll, Amerigo Wang, (Tue Apr 27, 12:56 am)

Re: [v4 Patch 1/3] netpoll: add generic support for bridge ..., David Miller, (Tue Apr 27, 3:22 pm)

Re: [v4 Patch 2/3] bridge: make bridge support netpoll, David Miller, (Tue Apr 27, 3:23 pm)

Re: [v4 Patch 3/3] bonding: make bonding support netpoll, David Miller, (Tue Apr 27, 3:24 pm)

Re: [v4 Patch 3/3] bonding: make bonding support netpoll, Cong Wang, (Tue Apr 27, 7:08 pm)

Re: [v4 Patch 1/3] netpoll: add generic support for bridge ..., Dongdong Deng, (Tue Apr 27, 9:02 pm)

Re: [v4 Patch 1/3] netpoll: add generic support for bridge ..., Cong Wang, (Wed Apr 28, 2:59 am)


linux-kernel:
Paul Turner	[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Matthew Garrett	Re: [PATCH] Enable speedstep for sonoma processors.
Mauro Carvalho Chehab	Re: [PATCH 1/2] media: Add timberdale video-in driver
Peter Zijlstra	[PATCH 23/30] netvm: skb processing
Greg Kroah-Hartman	[PATCH 21/28] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on
git:
Jan Hudec	Re: GIT push to sftp (feature request)
Steffen Prohaska	[PATCH 0/4] core.ignorecase
Johannes Schindelin	Re: Git checkout preserve timestamp?
Linus Torvalds	[PATCH 1/7] Make unpack_trees_options bit flags actual bitfields
Johan Herland	Re: What's cooking in git.git (Oct 2010, #01; Wed, 13)
linux-netdev:
David Miller	Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Richard Cochran	Re: [PATCH v3 3/3] ptp: Added a clock that uses the eTSEC found on the MPC85xx.
Jan Engelhardt	Re: [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div()
Herbert Xu	Re: [RFC PATCH 00/17] virtual-bus
Jeff Kirsher	Re: [net-next-2.6 PATCH] e1000e: don't inadvertently re-set INTX_DISABLE
git-commits-head:
Linux Kernel Mailing List	ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
Linux Kernel Mailing List	Use path_put() in a few places instead of {mnt,d}put()
Linux Kernel Mailing List	mv643xx_eth: use sw csum for big packets
Linux Kernel Mailing List	arm: fix HAVE_CLK merge goof
Linux Kernel Mailing List	arm: convert pcm037 platform to use smsc911x
freebsd-current:
David Wolfskill	"interrupt storm..."; seems associated with an0 NIC
Andriy Gapon	Re: letting glabel recognise a media change
Garrett Cooper	Re: Only display ACPI bootmenu key if ACPI is present
Pyun YongHyeon	CFT: msk(4) Rx checksum offloading support
FreeBSD Tinderbox	[head tinderbox] failure on sparc64/sparc64