Re: [v4 Patch 2/3] bridge: make bridge support netpoll

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: David Miller

Subject: Re: [v4 Patch 2/3] bridge: make bridge support netpoll

Date: Tuesday, April 27, 2010 - 3:23 pm

From: Amerigo Wang <amwang@redhat.com>
Date: Tue, 27 Apr 2010 03:55:56 -0400

quoted text> +		if (p->dev->priv_flags & IFF_DISABLE_NETPOLL
> +				|| !p->dev->netdev_ops->ndo_poll_controller)

"||" goes on first line, and indentation on second line is incorrect.
See my comments from patch #1.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[v4 Patch 1/3] netpoll: add generic support for bridge and ..., Amerigo Wang, (Tue Apr 27, 12:55 am)

[v4 Patch 2/3] bridge: make bridge support netpoll, Amerigo Wang, (Tue Apr 27, 12:55 am)

[v4 Patch 3/3] bonding: make bonding support netpoll, Amerigo Wang, (Tue Apr 27, 12:56 am)

Re: [v4 Patch 1/3] netpoll: add generic support for bridge ..., David Miller, (Tue Apr 27, 3:22 pm)

Re: [v4 Patch 2/3] bridge: make bridge support netpoll, David Miller, (Tue Apr 27, 3:23 pm)

Re: [v4 Patch 3/3] bonding: make bonding support netpoll, David Miller, (Tue Apr 27, 3:24 pm)

Re: [v4 Patch 3/3] bonding: make bonding support netpoll, Cong Wang, (Tue Apr 27, 7:08 pm)

Re: [v4 Patch 1/3] netpoll: add generic support for bridge ..., Dongdong Deng, (Tue Apr 27, 9:02 pm)

Re: [v4 Patch 1/3] netpoll: add generic support for bridge ..., Cong Wang, (Wed Apr 28, 2:59 am)


linux-kernel:
swhiteho	[PATCH 42/51] [GFS2] Move inode deletion out of blocking_cb
FUJITA Tomonori	Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Benjamin Herrenschmidt	[git pull] Please pull powerpc.git merge branch
Vivek Goyal	Re: [PATCH v4] sched: automated per session task groups
Bart Van Assche	Re: Integration of SCST in the mainstream Linux kernel
git:
Mike Miller	git message
Stefan Richter	Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Jeff King	Re: [PATCH] t7004: test that "git-tag -u" implies "-s"
Christian MICHON	Re: VCS comparison table
Scott Chacon	Re: why not TortoiseGit
linux-netdev:
Arnaldo Carvalho de Melo	Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
David Miller	Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
David Miller	Re: [PATCH 2/5] dccp: Auto-load (when supported) CCID plugins for negotiation
Chuck Lever	Re: svc: failed to register lockdv1 RPC service (errno 97).
David Miller	Re: [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap
git-commits-head:
Linux Kernel Mailing List	i915: Don't whine when pci_enable_msi() fails.
Linux Kernel Mailing List	NFSv4: Move error handling out of the delegation generic code
Linux Kernel Mailing List	Disallow gcc versions 4.1.{0,1}
Linux Kernel Mailing List	V4L/DVB: au8522: fix race condition in switching from digital to analog mode
Linux Kernel Mailing List	[ARM] 4671/1: ep93xx: remove obsolete gpio_line_* operations
openbsd-misc:
Christian Weisgerber	Re: CARP with a single public IP address
Marco Peereboom	Re: OpenBSD culture?
Vikas N Kumar	Re: Singularity OS
"RALOVICH, Kristóf"	Re: thinkpad windows refund
Kevin	Re: uvm_mapent_alloc: out of static map entries on 4.3 i386