Re: [patch] gpio: potential null dereference

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Dan Carpenter

Subject: Re: [patch] gpio: potential null dereference

Date: Tuesday, April 27, 2010 - 3:30 am

On Tue, Apr 27, 2010 at 11:41:16AM +0200, Daniel Glöckner wrote:
quoted text> It returns a valid pointer iff (desc->flags & GPIO_TRIGGER_MASK).
> 
> When !(desc->flags & GPIO_TRIGGER_MASK) it returns NULL and everything
> gets allocated (unless !gpio_flags as well). What you wanted to remove
> is the allocation code, not error handling code. 

No no.  I don't want to remove anything.  I'm happy with the code as is
now that you've explained it to me.  :)

regards,
dan carpenter

quoted text> It is always run when
> the trigger is set from "none" to something else.
> 
>   Daniel
>
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch] gpio: potential null dereference, Dan Carpenter, (Mon Apr 26, 12:25 pm)

Re: [patch] gpio: potential null dereference, Daniel Glöckner, (Mon Apr 26, 4:05 pm)

Re: [patch] gpio: potential null dereference, Andrew Morton, (Mon Apr 26, 4:14 pm)

Re: [patch] gpio: potential null dereference, Dan Carpenter, (Tue Apr 27, 2:05 am)

Re: [patch] gpio: potential null dereference, Daniel Glöckner, (Tue Apr 27, 2:41 am)

Re: [patch] gpio: potential null dereference, Dan Carpenter, (Tue Apr 27, 3:30 am)


linux-kernel:
Greg Kroah-Hartman	[PATCH 01/75] platform: prefix MODALIAS with "platform:"
stephane eranian	Re: perf_counters issue with PERF_SAMPLE_GROUP
Eric Sandeen	Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages
Daniel Hazelton	Re: x86: 4kstacks default
Mathieu Desnoyers	Re: Linux 2.6.25-rc2
git:
Johannes Schindelin	[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Alex Riesen	Re: git exclude patterns for directory
Andreas Ericsson	Re: why not TortoiseGit
Oliver Kullmann	Re: how to move with history?
Junio C Hamano	Re: [PATCH] http-push: making HTTP push more robust and more user-friendly
linux-netdev:
Andi Kleen	Re: RFC: Nagle latency tuning
Herbert Xu	Re: Oops in tun: bisected to Limit amount of queued packets per device
gregkh	Patch "IPv6: keep route for tentative address" has been added to the 2.6.34-stable...
Patrick McHardy	Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
Paul Gortmaker	[PATCH net-next 09/16] tipc: Relocate trivial link status functions to header file
git-commits-head:
Linux Kernel Mailing List	sh: Fix compile error by operands(mov.l) in sh3/entry.S
Linux Kernel Mailing List	New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List	tmpfs: depend on shmem
Linux Kernel Mailing List	drivers/acpi: use kasprintf
Linux Kernel Mailing List	Staging: et131x: prune all the debug code
openbsd-misc:
Andres Salazar	About priorities in /etc/resolv.conf
Tonnerre LOMBARD	Re: bge0: watchdog timeout
Damien Miller	Re: Patching a SSH 'Weakness'
ropers	Re: Real men don't attack straw men
Stuart Henderson	Re: Apache Seg Fault after upgrade to 4.6 stable