[PATCH 2/2] [MTD] Call bdi_init() and bdi_register()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jörn Engel
Date: Monday, April 26, 2010 - 9:31 am

Otherwise we hit a BUG_ON in bdi_queue_work().

Signed-off-by: Joern Engel <joern@logfs.org>
---
 drivers/mtd/mtdcore.c |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index cb4858b..8dd3e46 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -299,7 +299,7 @@ static struct device_type mtd_devtype = {
 
 int add_mtd_device(struct mtd_info *mtd)
 {
-	int i;
+	int i, err;
 
 	if (!mtd->backing_dev_info) {
 		switch (mtd->type) {
@@ -322,6 +322,12 @@ int add_mtd_device(struct mtd_info *mtd)
 		if (!mtd_table[i]) {
 			struct mtd_notifier *not;
 
+			err = bdi_register(mtd->backing_dev_info, NULL, "mtd%d",
+					i);
+			if (err) {
+				/* We lose the errno information :( */
+				break;
+			}
 			mtd_table[i] = mtd;
 			mtd->index = i;
 			mtd->usecount = 0;
@@ -692,6 +698,15 @@ static int __init init_mtd(void)
 	int ret;
 	ret = class_register(&mtd_class);
 
+	ret = bdi_init(&mtd_bdi_unmappable);
+	if (ret)
+		return ret;
+	ret = bdi_init(&mtd_bdi_ro_mappable);
+	if (ret)
+		return ret;
+	ret = bdi_init(&mtd_bdi_rw_mappable);
+	if (ret)
+		return ret;
 	if (ret) {
 		pr_err("Error registering mtd class: %d\n", ret);
 		return ret;
-- 
1.6.2.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Sat Apr 17, 11:40 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Mon Apr 19, 12:38 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Mon Apr 19, 3:15 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Mon Apr 19, 3:20 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Mon Apr 19, 4:39 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Wed Apr 21, 10:54 pm)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Wed Apr 21, 11:26 pm)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Thu Apr 22, 2:03 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Thu Apr 22, 3:39 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, David Woodhouse, (Thu Apr 22, 3:58 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Thu Apr 22, 4:05 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Thu Apr 22, 4:55 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Thu Apr 22, 5:08 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jörn Engel, (Thu Apr 22, 5:17 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Linus Torvalds, (Thu Apr 22, 7:25 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Linus Torvalds, (Thu Apr 22, 7:33 am)
Re: [PATCH] [MTD] Fix JFFS2 sync silent failure, Jens Axboe, (Thu Apr 22, 9:27 am)
[Patch] Catch filesystems lacking s_bdi, Jörn Engel, (Thu Apr 22, 1:33 pm)
Re: [Patch] Catch filesystems lacking s_bdi, Jens Axboe, (Fri Apr 23, 3:05 am)
Re: [Patch] Catch filesystems lacking s_bdi, Jörn Engel, (Fri Apr 23, 1:55 pm)
Re: [Patch] Catch filesystems lacking s_bdi, Jens Axboe, (Mon Apr 26, 2:48 am)
Re: [Patch] Catch filesystems lacking s_bdi, Jörn Engel, (Mon Apr 26, 7:32 am)
Re: [Patch] Catch filesystems lacking s_bdi, Jens Axboe, (Mon Apr 26, 7:38 am)
Re: [Patch] Catch filesystems lacking s_bdi, Jens Axboe, (Mon Apr 26, 7:45 am)
[PATCH 1/2] [MTD] Move mtd_bdi_*mappable to mtdcore.c, Jörn Engel, (Mon Apr 26, 9:30 am)
[PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Jörn Engel, (Mon Apr 26, 9:31 am)
Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Paolo Minazzi, (Tue Apr 27, 1:11 am)
Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Paolo Minazzi, (Tue Apr 27, 2:01 am)
Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Paolo Minazzi, (Tue Apr 27, 2:26 am)
Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Paolo Minazzi, (Tue Apr 27, 2:36 am)
Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Paolo Minazzi, (Tue Apr 27, 4:31 am)
Re: [PATCH 2/2] [MTD] Call bdi_init() and bdi_register(), Paolo Minazzi, (Tue Apr 27, 4:54 am)