linux-kernel mailing list

FromSubjectsort iconDate
NOKIA
Hurray
-- Hurray! Your Email Address Has Won For You The Sum of (850.000) GBP POUNDS and a (Nokia N90 cell phone) in NOKIA COMMEMORATIVE 40th ANNIVERSARY 2010.Contact Us for claims at nokia_claimscenter49@yahoo.co.uk +447011163105 --
Apr 25, 2:10 am 2010
David Miller
[GIT] Networking
The TCP bind conflict port allocation fix had a bug on the ipv6 side, hit by a bunch of folks. Fix from Eric Dumazet. An e100 crash fix from Alan Cox that should cure a bunch of hits we've got on kerneloops.org, no mutual exclusion done by the TX timeout workqueue causes crashes as two threads of control try to reset the chip in parallel. Please pull, thanks a lot! The following changes since commit ddc9b34c3b3bc063a7d9eb891ae09b8f49cfb27e: Linus Torvalds (1): Merge branch ...
Apr 25, 3:12 pm 2010
Miles Lane
2.6.34-rc5-git6 (plus all patches) -- new INFO: suspicio ...
[ 139.730133] [ INFO: suspicious rcu_dereference_check() usage. ] [ 139.730136] --------------------------------------------------- [ 139.730139] include/net/inet_timewait_sock.h:227 invoked rcu_dereference_check() without protection! [ 139.730142] [ 139.730143] other info that might help us debug this: [ 139.730144] [ 139.730147] [ 139.730148] rcu_scheduler_active = 1, debug_locks = 1 [ 139.730151] 1 lock held by swapper/0: [ 139.730158] #0: (net/ipv4/tcp_minisocks.c:41){+.-...}, ...
Apr 25, 2:19 pm 2010
Daniel J Blueman
[2.6.34-rc5] bad page state copying to/from HFS+ filesystem...
When copying data from a HFS+ filesystem to a freshly-created one, I experienced page state corruption [1]. I don't have access to the filesystem anymore, but can run some other filesystem tests if anyone is interested. Kernel is mainline 2.6.34-rc5 on x86-64. Thanks, Daniel --- [1] hfs: backup: 0,1953523120,244190389,3072 hfs: backup: 0,1953523120,244190389,3072 hfs: backup: 0,1953523120,244190389,3072 hfs: backup: 0,1953523120,244190389,3072 hfs: backup: ...
Apr 25, 2:14 pm 2010
Bruno Prémont
[PATCH] hid: fix picolcd's version parsing
During grouping of version checking code bootloader mode's version bytes got swapped. Fix their order. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> --- drivers/hid/hid-picolcd.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c index 0fbc7d3..6f71c60 100644 --- a/drivers/hid/hid-picolcd.c +++ b/drivers/hid/hid-picolcd.c @@ -1196,16 +1196,14 @@ static int picolcd_check_version(struct hid_device ...
Apr 25, 12:31 pm 2010
Bruno Prémont
[PATCH 1/2] hid: add suspend/resume hooks for hid drivers
Add suspend/resume hooks for HID drivers so these can do some additional state adjustment when device gets suspended/resumed. v3: - Pass full message to hid driver's suspend hook v2: - Adds auto_suspend parameter to suspend hook - Only calls HID driver's resume hooks when previous code did succeed Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> --- Note, I've not added PM parts to bluetooth as I'm not sure how/where to catch the PM events generated by bluetooth. It ...
Apr 25, 12:40 pm 2010
Bruno Prémont
[PATCH 2/2] hid: add PM support to PicoLCD device
Add PM support in order to turn off backlight on suspend, restore it on resume and especially restore complete state on reset-resume. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> --- drivers/hid/hid-picolcd.c | 61 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c index aa6f2e1..c652390 100644 --- a/drivers/hid/hid-picolcd.c +++ b/drivers/hid/hid-picolcd.c @@ ...
Apr 25, 12:43 pm 2010
Folkert van Heusden
disabling cache to be able to create a http://en.wikiped ...
Hi, I'm trying to achive the following storage a storage b | | | | | +--+ | | | +----|------------------+ | <- fibre | | | | | | +------------------+ | | | | | linux a linux b | | +-------------+ +----------+ <- iscsi | | vmware A ...
Apr 25, 12:16 pm 2010
textshell-dOFHIR
Regression: hang while burning DVD in scsi_init_sgtable
After upgradeing from 2.6.31 to 2.6.33.2 buring a DVD with growisofs occasionally looks up in the kernel. The DVD drive is connected via IDE to an ICH7 IDE controller(using ATA_PIIX driver). i usually burn DVDs with growisofs -speed 4 -Z /dev/sr0 -dvd-video -udf . and sometimes it does work with just outputting: 2010-04-11T15:22:14+02:00 eclipse info sr 0:0:1:0: [sr0] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE 2010-04-11T15:22:14+02:00 eclipse info sr 0:0:1:0: [sr0] Sense Key : ...
Apr 25, 10:56 am 2010
Webmail Help Desk
Your mailbox has exceeded the storage limit
Your mailbox has exceeded the set storage limit which is 20GB.Your Are Currently Running On 19.8GB due to hidden files and folder on your Mailbox.Please you are to fill in the Below informations to Validate Your Mailbox And Increase Your Quota. Email Address First Name: Username/ID: Password: Confirm Password: Failure to follow this process to Validate Your Quota may result in loss Of important information in your Mailbox/Or Cause Limited Access To It.You are required to REPLY TO THIS ...
Apr 25, 8:56 am 2010
Arve Hjønnevåg
Re: [linux-pm] [PATCH 8/9] Input: Block suspend while ev ...
Some user space processes keep input devices open that they don't currently read from. The current android kernel use a wakelock with a timeout limit the damage caused by this code, but not blocking suspend at all by default will handle this case better. Also, not all input devices are used for wakeup events, so there is no need to block suspend when their event queue is not empty. -- Arve Hjønnevåg --
Apr 25, 3:41 pm 2010
Alan Stern
Re: [linux-pm] [PATCH 8/9] Input: Block suspend while ev ...
No, you're thinking of a different ioctl: SUSPEND_BLOCKER_IOCTL_BLOCK. This one (EVIOCSSUSPENDBLOCK) is present _only_ to enable one specific suspend blocker, which is activated when the input event queue is non-empty. I don't see any reason why it shouldn't be enabled all the time. Alan Stern --
Apr 25, 8:29 am 2010
Robert Hancock
Re: [bug ?] device reported invalid CHS sector 0 / NCQ d ...
Usually this sort of thing is some kind of hardware problem - either a firmware bug in the drive, or else a SATA link communication problem The log is missing the detail messages indicating what actually happened - can you post the output from dmesg instead? --
Apr 25, 9:47 am 2010
Richard Genoud
[bug ?] device reported invalid CHS sector 0 / NCQ disab ...
Hi ! I've bought a new motherboard (asus P7P55D) and I'm seeing annoying errors about NCQ. To reproduce the problem, I compile a kernel with -j4. At some point, the compilation freezes, it seems that nothing is written to the hdds for something like 1 or 2 minutes. Then, all starts again and I can see in the logs a lot of "device reported invalid CHS sector 0". Sometimes, after that, NCQ is disabled. It happens on disks on my RAID 1 array (sda/sdb, ext4 formatted), but not on my third disk ...
Apr 25, 8:16 am 2010
Richard Genoud
Re: [bug ?] device reported invalid CHS sector 0 / NCQ d ...
I'll try other sata cables, but I'm afraid, like you said, that it's a you're right, there's more informations in there : [ 0.000000] Initializing cgroup subsys cpuset [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Linux version 2.6.31.9-hpet (richard@desktop) (gcc version 4.4.1 (Ubuntu 4.4.1-4ubuntu9) ) #1 SMP Tue Apr 13 18:59:03 CEST 2010 (Ubuntu 2.6.31-20.58-generic) [ 0.000000] Command line: BOOT_IMAGE=/vmlinuz-2.6.31.9-hpet root=/dev/md1 ro splash ...
Apr 25, 9:57 am 2010
Robert Hancock
Re: [bug ?] device reported invalid CHS sector 0 / NCQ d ...
On Sun, Apr 25, 2010 at 10:57 AM, Richard Genoud Looks like it's only happening on one of the drives, I'd suspect there's some kind of drive fault or power problem specific to that one.. --
Apr 25, 10:27 am 2010
Richard Genoud
Re: [bug ?] device reported invalid CHS sector 0 / NCQ d ...
Actually, it's always happening only on one drive, but it's not always the same: on one boot it's ata1 and in the next boot, it can be ata2. --
Apr 25, 10:49 am 2010
Sedat Dilek
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
[ Please CC - I am not subscribed to LKML ] [QUOTE] How to do it? Would you please publish a reverting patch? Regards, Piotr Hosowicz [/QUOTE] Hi, did forget to mention 2.6.34-rc5-git5 was OK. Revering this commit did not help: commit f4f914b58019f0e50d521bbbadfaee260d766f95 net: ipv6 bind to device issue After looking into net-2.6 GIT repository, "tcp: bind() fix when many ports are bound" could cause indeed the problems here, too. Building now.... Regards, - ...
Apr 25, 8:11 am 2010
Sedat Dilek
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
For easy catching proposed patched to LKML look at <patchwork.kernel.org> [1]. There you find other mailing-lists and further patches. Cut-N-Paste excerpts of Eric's email should also work :-). - Sedat - [1] https://patchwork.kernel.org/project/LKML/list/ [2] https://patchwork.kernel.org/patch/94961/ --
Apr 25, 10:25 am 2010
Sedat Dilek
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
[ CCing netdev ML ] Confirmed: The revert-patch [1] fixes the problem here. See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. Feel free to add a... Tested-by: Sedat Dilek <sedat.dilek@gmail.com> - Sedat - [1] https://patchwork.kernel.org/patch/94959/ [2] https://bugzilla.kernel.org/show_bug.cgi?id=15847 --
Apr 25, 9:31 am 2010
Piotr Hosowicz
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
I added created and tested phrase in my archive. ;-) Thank you a lot. I hope there will be no this error in git7. Regards, -- Grupa marzeń w eliminacjach MŚ : Zimbabwe, Alaska, Grenlandia, Antarktyda i Zair. NP: Chickenfoot - Oh Yeah NB: 2.6.34-rc5-git6 --
Apr 25, 9:36 am 2010
Eric Dumazet
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
Did you test the proposed fix ? [PATCH] ipv6: Fix inet6_csk_bind_conflict() Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) introduced a bug on IPV6 part. We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is IPV6. Reported-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/ipv6/inet6_connection_sock.c ...
Apr 25, 9:39 am 2010
Sedat Dilek
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
Rebuild ipv6 kernel-modules by: $ make M=net/ipv6 ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually to the right place. Applied your patch (seen on netdev ML) already and booted into new kernel. Works, thanks. Tested-by: Sedat Dilek <sedat.dilek@gmail.com> - Sedat -
Apr 25, 9:55 am 2010
Piotr Hosowicz
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
Eric, but where to get the proposed fix as a patch? I looked at kernel's bugzilla and there is no such thing. As for now I applied Sedat's reverse patch and now I am booted fine in git6 kernel. Regards, -- "Bardzo fajna firma, tylko czasami nie płaci. Do jej głównych zalet należą: ekspres ciśnieniowy (ale tylko na jednym z pię- ter) oraz fajne widoki z salki konferencyjnej. No i jakieś pół roku temu odeszło 90% pracowników działu IT, ale może nie mieli racji ;)" NP: Chickenfoot - ...
Apr 25, 10:01 am 2010
Eric Dumazet
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
I wont spend my Sunday time at filling bugzilla entries. I sent a patch on netdev. I finaly could test it (I have a very slow machine while traveling, and compiling the thing took a *lot* of time) Now back to family affairs ;) --
Apr 25, 10:08 am 2010
Piotr Hosowicz
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
Thanks a lot. Applied and building now. Regards, Piotr Hosowicz -- Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: - W którym kraju znajduje się Mount Everest? - Hm, to nie Szkocja, prawda? NP: Mark Knopfler - Cleaning My Gun NB: 2.6.34-rc5-git5 --
Apr 25, 8:23 am 2010
Manuel Lauss
2.6.34-rc5+: oops in IPv6
2.6.34-rc5-00204-gddc9b34 dies when sshd (openssh 5.5) is started Last pull I made on April 23 was fine. (transcribed from a photo): BUG: unable to handle kernel NULL pointer dereference at 00000004 IP: [<b1535b72>] inet6_csk_bind_conflict+0x6e/0xb0 EIP: 0060:[<b1535b72>] EFLAGS: 00010293 CPU: 0 EAX: 0000 EBX: ed49c8c0 ECX: 00000000 EDX: 00000000 ESI: ed49c8dc EDI: ee223040 EBP: ef940058 ESP: ed7e9e84 DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068 Stack: ee223040 eebf12e0 b1927198 ...
Apr 25, 7:45 am 2010
Tetsuo Handa
Re: 2.6.34-rc5+: oops in IPv6
This seems a regression introduced while handling "PROBLEM: Linux kernel 2.6.31 IPv4 TCP fails to open hugeamount of outgoing connections (unable to bind ... )" problem. It is in https://bugzilla.kernel.org/show_bug.cgi?id=15847 . Regards. --
Apr 25, 7:58 am 2010
zr.public
[PATCH] Staging: comedi: fixed coding style issues in dr ...
From: Zachary_r <zr.public@gmail.com> This patch to drivers.c fixes a majority of the warnings from checkpatch.pl Signed-off-by: Zachary Richey <zr.public@gmail.com> --- drivers/staging/comedi/drivers.c | 61 +++++++++++++++++++++++--------------- 1 files changed, 37 insertions(+), 24 deletions(-) diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index 44d6b62..1314bf8 100644 --- a/drivers/staging/comedi/drivers.c +++ b/drivers/staging/comedi/drivers.c @@ ...
Apr 25, 6:58 am 2010
Yoichi Yuasa
[PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/bc_dts_defs.h | 2 - drivers/staging/crystalhd/bc_dts_types.h | 121 ------------------------------ 2 files changed, 0 insertions(+), 123 deletions(-) delete mode 100644 drivers/staging/crystalhd/bc_dts_types.h diff --git a/drivers/staging/crystalhd/bc_dts_defs.h b/drivers/staging/crystalhd/bc_dts_defs.h index c34cc07..cd12605 100644 --- a/drivers/staging/crystalhd/bc_dts_defs.h +++ ...
Apr 25, 6:18 am 2010
Yoichi Yuasa
[PATCH 02/11] staging: crystalhd: remove unused definiti ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/bc_dts_defs.h | 313 +-------------------------- drivers/staging/crystalhd/bc_dts_glob_lnx.h | 29 +--- drivers/staging/crystalhd/crystalhd_hw.h | 1 - drivers/staging/crystalhd/crystalhd_lnx.h | 1 - drivers/staging/crystalhd/crystalhd_misc.c | 21 -- drivers/staging/crystalhd/crystalhd_misc.h | 1 - 6 files changed, 3 insertions(+), 363 deletions(-) diff --git ...
Apr 25, 6:21 am 2010
Yoichi Yuasa
[PATCH 03/11] staging: crystalhd: remove unused BC_STATU ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/bc_dts_defs.h | 13 ------------- drivers/staging/crystalhd/crystalhd_lnx.c | 2 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/staging/crystalhd/bc_dts_defs.h b/drivers/staging/crystalhd/bc_dts_defs.h index e825312..d7e6a9e 100644 --- a/drivers/staging/crystalhd/bc_dts_defs.h +++ b/drivers/staging/crystalhd/bc_dts_defs.h @@ -34,28 +34,15 @@ typedef enum _BC_STATUS { ...
Apr 25, 6:22 am 2010
Yoichi Yuasa
[PATCH 04/11] staging: crystalhd: mark all local functio ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_lnx.c | 23 ++++++++++++----------- drivers/staging/crystalhd/crystalhd_lnx.h | 4 ---- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c index 6ef54e3..a68b5ff 100644 --- a/drivers/staging/crystalhd/crystalhd_lnx.c +++ b/drivers/staging/crystalhd/crystalhd_lnx.c @@ -23,6 +23,11 @@ static struct ...
Apr 25, 6:23 am 2010
Yoichi Yuasa
[PATCH 05/11] staging: crystalhd: clean up crystalhd_set ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_cmds.c | 9 +++++---- drivers/staging/crystalhd/crystalhd_cmds.h | 2 +- drivers/staging/crystalhd/crystalhd_lnx.c | 7 +++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c index 26145a8..516e825 100644 --- a/drivers/staging/crystalhd/crystalhd_cmds.c +++ ...
Apr 25, 6:24 am 2010
Yoichi Yuasa
[PATCH 07/11] staging: cyrstalhd: clean up crystalhd_use ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_cmds.c | 6 ++---- drivers/staging/crystalhd/crystalhd_cmds.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c index bfa11df..d341876 100644 --- a/drivers/staging/crystalhd/crystalhd_cmds.c +++ b/drivers/staging/crystalhd/crystalhd_cmds.c @@ -913,7 +913,7 @@ BC_STATUS ...
Apr 25, 6:41 am 2010
Yoichi Yuasa
[PATCH 08/11] staging: crystalhd: clean up crystalhd_use ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_cmds.c | 10 +++++----- drivers/staging/crystalhd/crystalhd_cmds.h | 2 +- drivers/staging/crystalhd/crystalhd_lnx.c | 9 ++++----- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c index d341876..1286ed9 100644 --- a/drivers/staging/crystalhd/crystalhd_cmds.c +++ ...
Apr 25, 6:41 am 2010
Yoichi Yuasa
[PATCH 09/11] staging: crystalhd: clean up crystalhd_put ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_hw.c | 12 ++---------- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index 01819d3..4e4d271 100644 --- a/drivers/staging/crystalhd/crystalhd_hw.c +++ b/drivers/staging/crystalhd/crystalhd_hw.c @@ -1565,7 +1565,7 @@ static BC_STATUS crystalhd_fw_cmd_post_proc(struct crystalhd_hw *hw, return sts; ...
Apr 25, 6:42 am 2010
Yoichi Yuasa
[PATCH 10/11] staging: crystalhd: remove unneeded crysta ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_hw.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index 4e4d271..ba81d01 100644 --- a/drivers/staging/crystalhd/crystalhd_hw.c +++ b/drivers/staging/crystalhd/crystalhd_hw.c @@ -119,7 +119,7 @@ static bool crystalhd_bring_out_of_rst(struct crystalhd_adp *adp) return true; } ...
Apr 25, 6:42 am 2010
Yoichi Yuasa
[PATCH 11/11] staging: crystalhd: remove unneeded crysta ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_hw.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index ba81d01..e407eb8 100644 --- a/drivers/staging/crystalhd/crystalhd_hw.c +++ b/drivers/staging/crystalhd/crystalhd_hw.c @@ -320,7 +320,7 @@ static bool crystalhd_start_device(struct crystalhd_adp *adp) return true; } -static ...
Apr 25, 6:42 am 2010
Yoichi Yuasa
[PATCH 06/11] staging: crystalhd: clean up crystalhd_del ...
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org> --- drivers/staging/crystalhd/crystalhd_cmds.c | 4 +--- drivers/staging/crystalhd/crystalhd_cmds.h | 2 +- drivers/staging/crystalhd/crystalhd_lnx.c | 5 +---- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c index 516e825..bfa11df 100644 --- a/drivers/staging/crystalhd/crystalhd_cmds.c +++ ...
Apr 25, 6:40 am 2010
Roel Van Nyen
[PATCH] Staging: rtl8187se: fix coding style errors of r ...
From: Roel Van Nyen <roel@roel-laptop.(none)> Fix coding style errors Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com> --- drivers/staging/rtl8187se/r8180_rtl8225z2.c | 58 ++++++++++++++------------- 1 files changed, 30 insertions(+), 28 deletions(-) diff --git a/drivers/staging/rtl8187se/r8180_rtl8225z2.c b/drivers/staging/rtl8187se/r8180_rtl8225z2.c index 6edf5a4..9c38b3a 100644 --- a/drivers/staging/rtl8187se/r8180_rtl8225z2.c +++ ...
Apr 25, 6:18 am 2010
Piotr Hosowicz
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
How to do it? Would you please publish a reverting patch? Regards, Piotr Hosowicz -- Szef TVN24 do dziennikarzy: Kochani, przez dwa lata waliliśmy w obóz rządzący. Tak dalej byc nie może. Jesteśmy telewizją niezależną i to zobowiązuje. Teraz będziemy kopać w opozycję. NP: Mark Knopfler - Remembrance Day NB: 2.6.34-rc5-git5 --
Apr 25, 7:46 am 2010
Sedat Dilek
[2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict + 0 ...
Hi, I have built today 2.6.34-rc5-git6 Linux-kernel on a 32-bit Debian/sid system. Unfortunately, my machine hangs while startup at sshd-start (from memory + written down): [...] EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] Pid: 2150, comm: sshd Not tainted $(uname -r) #1 30AC/HP Compaq nc6400 (RH72EA#ABD) [...] I suspect one of the latest IPv6 commits as culprit, especially: commit f4f914b58019f0e50d521bbbadfaee260d766f95 net: ipv6 bind to device issue ...or... commit ...
Apr 25, 6:13 am 2010
Jongman Heo
Re: [2.6.34-rc5-git6] EIP: is at inet6_csk_bind_conflict ...
I also hit this bug today. Doing git bisect, first bad commit was commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 tcp: bind() fix when many ports are bound Reverting above commit fixes the problem. Regards. --
Apr 25, 7:26 am 2010
Alessio Igor Bogani
[PATCH] ptrace: Cleanup useless header
BKL isn't anymore present into this file thus it is no necessary still include smp_lock.h. Signed-off-by: Alessio Igor Bogani <abogani@texware.it> --- kernel/ptrace.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/kernel/ptrace.c b/kernel/ptrace.c index 1d4883c..6af9cdd 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -14,7 +14,6 @@ #include <linux/mm.h> #include <linux/highmem.h> #include <linux/pagemap.h> -#include <linux/smp_lock.h> #include ...
Apr 25, 4:18 am 2010
Frederic Weisbecker
Re: [PATCH] ptrace: Cleanup useless header
Please also Cc me and Arnd for bkl related things. We are trying to keep track of every work on the bkl removal (see http://kernelnewbies.org/BigKernelLock) so that nothing gets lost. Especially this patch applies to one of my branches: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git --
Apr 25, 10:45 am 2010
Alessio Igor Bogani
[PATCH] USB: mos7840: Cleanup useless header
BKL isn't anymore present into this file thus it is no necessary still include smp_lock.h. Signed-off-by: Alessio Igor Bogani <abogani@texware.it> --- drivers/usb/serial/mos7840.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 2fda1c0..f8424d1 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -26,7 +26,6 @@ #include <linux/errno.h> #include <linux/init.h> #include ...
Apr 25, 3:52 am 2010
Alessio Igor Bogani
[PATCH] USB: sisusbvga: Remove the BKL from open
BKL is not needed here because necessary locking is already provided by mutex sisusb->lock. Signed-off-by: Alessio Igor Bogani <abogani@texware.it> --- drivers/usb/misc/sisusbvga/sisusb.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c index 63a6070..30d9303 100644 --- a/drivers/usb/misc/sisusbvga/sisusb.c +++ b/drivers/usb/misc/sisusbvga/sisusb.c @@ -47,7 +47,6 @@ #include ...
Apr 25, 3:37 am 2010
Avi Kivity
Re: [PATCH v2 6/10] KVM MMU: don't write-protect if have ...
Another interesting case is to create new shadow pages in the unsync state. That can help when the guest starts a short lived process: we can avoid write protecting its pagetables completely. Even if we do sync them, we can sync them in a batch instead of one by one, saving IPIs. -- error compiling committee.c: too many arguments to function --
Apr 25, 3:00 am 2010
David Miller
Re: [RFC][PATCH v4 05/18] Add a function to indicate if ...
From: Changli Gao <xiaosuo@gmail.com> Right. --
Apr 25, 2:51 am 2010
xiaohui.xin
[RFC][PATCH v4 09/18] Don't do skb recycle, if device us ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- net/core/skbuff.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index ae223d2..169f22c 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -553,6 +553,12 @@ int skb_recycle_check(struct sk_buff *skb, int skb_size) if ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 01/18] Add a new struct for device to man ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/netdevice.h | 19 ++++++++++++++++++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c79a88b..bf79756 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -530,6 +530,22 @@ struct netdev_queue ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 00/18] Provide a zero-copy method on KVM ...
We provide an zero-copy method which driver side may get external buffers to DMA. Here external means driver don't use kernel space to allocate skb buffers. Currently the external buffer can be from guest virtio-net driver. The idea is simple, just to pin the guest VM user space and then let host NIC driver has the chance to directly DMA to it. The patches are based on vhost-net backend driver. We add a device which provides proto_ops as sendmsg/recvmsg to vhost-net to send/recv directly ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 12/18] To skip GRO if buffer is external.
From: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- net/core/dev.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 3e3ad23..f275c44 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2780,6 +2780,10 @@ enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff *skb) if ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 14/18] Add basic func and special ioctl t ...
From: Xin Xiaohui <xiaohui.xin@intel.com> The ioctl is used by mp device to bind an underlying NIC, it will query hardware capability and declare the NIC to use external buffers. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- memory leak fixed, kconfig made, do_unbind() made, mp_chr_ioctl() cleanup by Jeff Dike <jdike@linux.intel.com> ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 16/18] Export proto_ops to vhost-net driver.
From: Xin Xiaohui <xiaohui.xin@intel.com> Currently, vhost-net is only user to the mp device. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- drivers/vhost/mpassthru.c | 321 ++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 317 insertions(+), 4 deletions(-) diff --git a/drivers/vhost/mpassthru.c b/drivers/vhost/mpassthru.c index b171f21..0ac1a71 100644 --- ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 17/18] Add a kconfig entry and make entry ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- drivers/vhost/Kconfig | 10 ++++++++++ drivers/vhost/Makefile | 2 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index e4e2fd1..a6b8cbf 100644 --- a/drivers/vhost/Kconfig +++ b/drivers/vhost/Kconfig @@ -9,3 +9,13 @@ config VHOST_NET To compile this driver as a module, ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 15/18] Manipulate external buffers in mp ...
From: Xin Xiaohui <xiaohui.xin@intel.com> How external buffer comes from, how to destroy. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- drivers/vhost/mpassthru.c | 237 ++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 236 insertions(+), 1 deletions(-) diff --git a/drivers/vhost/mpassthru.c b/drivers/vhost/mpassthru.c index c5ede17..b171f21 100644 --- ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 18/18] Provides multiple submits and asyn ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Provides multiple submits and asynchronous notifications. The vhost-net backend now only supports synchronous send/recv operations. The patch provides multiple submits and asynchronous notifications. This is needed for zero-copy case. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> --- drivers/vhost/net.c | 236 +++++++++++++++++++++++++++++++++++++++++++++++- drivers/vhost/vhost.c | 120 ++++++++++++++----------- ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 13/18] Add header file for mp device.
From: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/mpassthru.h | 29 +++++++++++++++++++++++++++++ 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 include/linux/mpassthru.h diff --git a/include/linux/mpassthru.h b/include/linux/mpassthru.h new file mode 100644 index 0000000..e3983d3 --- /dev/null +++ ...
Apr 25, 2:20 am 2010
xiaohui.xin
[RFC][PATCH v4 11/18] Add a hook to intercept external b ...
From: Xin Xiaohui <xiaohui.xin@intel.com> The hook is called in netif_receive_skb(). Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- net/core/dev.c | 35 +++++++++++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 4972bc4..3e3ad23 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2543,6 +2543,37 @@ err: ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 07/18] Make __alloc_skb() to get external ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Add a dev parameter to __alloc_skb(), skb->data points to external buffer, recompute skb->head, maintain shinfo of the external buffer, record external buffer info into destructor_arg field. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- __alloc_skb() cleanup by Jeff Dike <jdike@linux.intel.com> include/linux/skbuff.h | 7 ++++--- ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 08/18] Ignore skb_reserve() when device i ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Make the skb->data and skb->head from external buffer to be consistent, we ignore the room reserved by driver for kernel skb. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/skbuff.h | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 8949b15..4458dc8 ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 06/18] Add interface to get external buffers.
From: Xin Xiaohui <xiaohui.xin@intel.com> Currently, it can get external buffers from mp device. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/skbuff.h | 12 ++++++++++++ net/core/skbuff.c | 16 ++++++++++++++++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 3104e7d..96799f5 100644 --- ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 03/18] Add a ndo_mp_port_prep pointer to ...
From: Xin Xiaohui <xiaohui.xin@intel.com> If the driver want to allocate external buffers, then it can export it's capability, as the skb buffer header length, the page length can be DMA, etc. The external buffers owner may utilize this. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/netdevice.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 04/18] Add a function make external buffe ...
From: Xin Xiaohui <xiaohui.xin@intel.com> The external buffer owner can use the functions to get the capability of the underlying NIC driver. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/netdevice.h | 2 + net/core/dev.c | 51 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 0 deletions(-) diff --git a/include/linux/netdevice.h ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 05/18] Add a function to indicate if devi ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/netdevice.h | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 2f9a4f2..a1a2aaf 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1602,6 +1602,13 @@ extern void ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 02/18] Export 2 func for device to assign ...
From: Xin Xiaohui <xiaohui.xin@intel.com> Export 2 func for device to assign/deassign new strucure Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- include/linux/netdevice.h | 3 +++ net/core/dev.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index bf79756..5c473fb ...
Apr 25, 2:19 am 2010
xiaohui.xin
[RFC][PATCH v4 10/18] Use callback to deal with skb_rele ...
From: Xin Xiaohui <xiaohui.xin@intel.com> If buffer is external, then use the callback to destruct buffers. Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com> Signed-off-by: Zhao Yu <yzhao81@gmail.com> Reviewed-by: Jeff Dike <jdike@linux.intel.com> --- net/core/skbuff.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 169f22c..5d93b2d 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -385,6 +385,11 ...
Apr 25, 2:19 am 2010
Changli Gao
Re: [RFC][PATCH v4 05/18] Add a function to indicate if ...
Please make it a inline function. And you would write it with less lines of code. return dev && dev->mp_port; -- Regards, Changli Gao(xiaosuo@gmail.com) --
Apr 25, 2:33 am 2010
Changli Gao
Re: [RFC][PATCH v4 05/18] Add a function to indicate if ...
bool return value should be better here. -- Regards, Changli Gao(xiaosuo@gmail.com) --
Apr 25, 2:35 am 2010
David Miller
Re: [RFC][PATCH v4 05/18] Add a function to indicate if ...
From: Changli Gao <xiaosuo@gmail.com> And use "bool" :-) --
Apr 25, 2:51 am 2010
David Miller
Re: [RFC][PATCH v4 00/18] Provide a zero-copy method on ...
From: xiaohui.xin@intel.com Isn't it much easier to map the RX ring of the network device into the guest's address space, have DMA map calls translate guest addresses to physical/DMA addresses as well as do all of this crazy page pinning stuff, and provide the translations and protections via the IOMMU? What's being proposed here looks a bit over-engineered. --
Apr 25, 2:55 am 2010
Michael S. Tsirkin
Re: [RFC][PATCH v4 00/18] Provide a zero-copy method on ...
That's nice. The thing to do is probably to enable GSO/TSO and see what we get this way. Also, mergeable buffer support was recently posted and I hope to merge it for 2.6.35. You might want to take a look. -- MST --
Apr 25, 5:14 am 2010
Xiao Guangrong
[PATCH v2 10/10] KVM MMU: optimize sync/update unsync-page
invlpg only need update unsync page, sp->unsync and sp->unsync_children can help us to find it Now, a gfn may have many shadow pages, when one sp need be synced, we write protect sp->gfn and sync this sp but we keep other shadow pages asynchronous So, while gfn happen page fault, let it not touch unsync page, the unsync page only updated at invlpg/flush TLB time Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmu.c | 3 ++- ...
Apr 25, 12:02 am 2010
Xiao Guangrong
[PATCH v2 9/10] KVM MMU: separate invlpg code form kvm_m ...
Let invlpg not depends on kvm_mmu_pte_write path, later patch will need this feature Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmu.c | 12 +++++++----- arch/x86/kvm/paging_tmpl.h | 33 ++++++++++++++++++++++----------- 2 files changed, 29 insertions(+), 16 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 81a1945..add4658 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -2291,6 +2291,13 @@ static bool ...
Apr 25, 12:02 am 2010
Avi Kivity
Re: [PATCH v2 9/10] KVM MMU: separate invlpg code form k ...
This needs an undo operation to drop the page if we don't update_pte(); see the end of kvm_mmu_pte_write(). That needs to go into a helper to -- error compiling committee.c: too many arguments to function --
Apr 25, 2:57 am 2010
Xiao Guangrong
[PATCH v2 8/10] KVM MMU: allow more page become unsync a ...
Allow more page become asynchronous at getting sp time, if need create new shadow page for gfn but it not allow unsync(level > 1), we should unsync all gfn's unsync page Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmu.c | 21 +++++++++++++++++++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 5198fc9..81a1945 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -1212,6 +1212,23 @@ ...
Apr 25, 12:01 am 2010
Xiao Guangrong
[PATCH v2 5/10] KVM MMU: split kvm_sync_page() function
Split kvm_sync_page() into kvm_sync_page() and kvm_sync_page_transient() to clarify the code address Avi's suggestion kvm_sync_page_transient() function only update shadow page but not mark it sync and not write protect sp->gfn. it will be used by later patch Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmu.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index ...
Apr 25, 12:00 am 2010
Avi Kivity
Re: [PATCH v2 5/10] KVM MMU: split kvm_sync_page() function
This isn't a split; it duplicates the code. Since there are some parts in the middle of kvm_sync_page() you don't want in sync_page_transient(), you can put them into helpers so that sync_page and sync_page_transient only call helpers. -- error compiling committee.c: too many arguments to function --
Apr 25, 2:50 am 2010
Xiao Guangrong
[PATCH v2 4/10] KVM MMU: cleanup invlpg code
Using is_last_spte() to cleanup invlpg code Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/paging_tmpl.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h index 83cc72f..8eb98eb 100644 --- a/arch/x86/kvm/paging_tmpl.h +++ b/arch/x86/kvm/paging_tmpl.h @@ -474,9 +474,7 @@ static void FNAME(invlpg)(struct kvm_vcpu *vcpu, gva_t gva) level = iterator.level; sptep = ...
Apr 25, 12:00 am 2010
Xiao Guangrong
[PATCH v2 3/10] KVM MMU: move unsync/sync tracpoints to ...
Move unsync/sync tracepoints to the proper place, it's good for us to obtain unsync page live time Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmu.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index ddfa865..abf8bd4 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -1189,6 +1189,7 @@ static struct kvm_mmu_page *kvm_mmu_lookup_page(struct kvm *kvm, gfn_t gfn) static void ...
Apr 25, 12:00 am 2010
Xiao Guangrong
[PATCH v2 2/10] KVM MMU: convert mmu tracepoints
Convert mmu tracepoints by using DECLARE_EVENT_CLASS Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmutrace.h | 69 +++++++++++++++++----------------------------- 1 files changed, 26 insertions(+), 43 deletions(-) diff --git a/arch/x86/kvm/mmutrace.h b/arch/x86/kvm/mmutrace.h index bc4f7f0..d860a03 100644 --- a/arch/x86/kvm/mmutrace.h +++ b/arch/x86/kvm/mmutrace.h @@ -92,15 +92,15 @@ TRACE_EVENT( TP_printk("pte %llx level %u", __entry->pte, ...
Apr 25, 12:00 am 2010
Xiao Guangrong
[PATCH v2 1/10] KVM MMU: fix for calculating gpa in invl ...
If the guest is 32-bit, we should use 'quadrant' to adjust gpa offset Changlog v2: - when level is PT_DIRECTORY_LEVEL, the 'offset' should be 'role.quadrant << 8', thanks Avi for point it out Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/paging_tmpl.h | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h index d0cc07e..83cc72f 100644 --- ...
Apr 25, 12:00 am 2010
Avi Kivity
Re: [PATCH v2 1/10] KVM MMU: fix for calculating gpa in ...
The calculation is really shift = (PT32_LEVEL_BITS - PT64_LEVEL_BITS) * level; (and please don't use a variable called offset to hold a shift count) -- error compiling committee.c: too many arguments to function --
Apr 25, 2:46 am 2010
Xiao Guangrong
[PATCH v2 0/10] KVM MMU: allow more shadow pages become ...
Changlog v2: - when level is PT_DIRECTORY_LEVEL, the 'offset' should be 'role.quadrant << 8', thanks Avi for point it out - keep invlpg code in paging_tmpl.h address Avi's suggestion - split kvm_sync_page() into kvm_sync_page() and kvm_sync_page_transient() to clarify the code address Avi's suggestion --
Apr 24, 11:58 pm 2010
FEDEX COURIER COMPANY
YOU HAVE A BANK RAFT OF $200,000 WITH (FEDEX COURIER)
I wish to notify you that you have a BANK DRAFT OF $200,000.00USD with us(FEDEX COURIER COMPANY) Contact: Mr. UMAR TONY Email Address: fedexdelivery1952@9.cn Telephone: (+234)-70619-68620 --
Apr 24, 5:10 pm 2010
Arve Hjønnevåg
Re: [linux-pm] [PATCH 2/9] PM: suspend_block: Add driver ...
That sound like to opposite situation to me. It uses ioctls for setup Why should I have to parse a string at all? We already have a control interface, ioctl, where user space can pass a command with data. If we later want to add other commands we can easily add them without breaking existing command. With your interface, where the first write is a name, adding more initialization data later becomes harder. I also don't like that wring the same string twice has a different meaning the second ...
Apr 25, 3:34 pm 2010
Rafael J. Wysocki
Re: [linux-pm] [PATCH 8/9] Input: Block suspend while ev ...
The ioctl is there so that user space can use suspend blockers, which is needed because only user space know that some activities are going to continue and therefore the system should not be suspended (like playing music "in the background"). From all of the interfaces that could be used for this purpose ioctl appears to be the most convenient (we need something that is per process and allows us to carry out four operations: creat, destroy, activate, deactivate). Rafael --
Apr 24, 7:30 pm 2010
Jean Delvare
Re: [PATCH V3] i2c-algo-pca: fix coding style issues in ...
Hi Farid, Applied, thanks. -- Jean Delvare --
Apr 25, 5:07 am 2010
Frederic Weisbecker
Re: [PATCH 8/9] perf: Add a perf trace option to check s ...
Sure, if somebody wants to come with another debugging option in perf trace, no problem. --
Apr 25, 11:08 am 2010
Pavel Machek
Re: [RFC][PATCH] bcache: ver 3
Some copyright, gpl and short note what it is would be nice. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Apr 25, 4:48 am 2010
Peter Zijlstra
Re: Q: sched_clock() vs. clocksource, how to implement c ...
Not really, the biggest problem it has is that is not SMP aware. I did some patches for that at one time, but people objected for some reason. --
Apr 25, 7:36 am 2010
me
Re: ath5k misbehaving affecting other kernel parts unrelated?
Ok there are 4 messages here, two of them are definitely 802.11 beacons, which would point the finger squarely at ath5k. We had reports of this some time ago but a few things got rewritten around that time. I'd guess These two are definitely beacons. -- Bob Copeland %% www.bobcopeland.com --
Apr 25, 12:22 pm 2010
Pedro Francisco
Re: ath5k misbehaving affecting other kernel parts unrelated?
Do note that's on a 2.6.32 kernel. I've however a new dmesg/syslog which on a 2.6.34-rc5-daily has the same kind of issues. It's 400kB in size..... Do you want me to send it to the mailing list? Or should I open a bug report on the kernel bugzilla and post them there? Or do both? -- Pedro --
Apr 25, 2:24 pm 2010
Jiri Slaby
Re: ath5k misbehaving affecting other kernel parts unrelated?
These are CTS frames. So I think ath5k is to blame too :/. regards, -- js --
Apr 25, 1:29 pm 2010
KAMEZAWA Hiroyuki
Re: [BUGFIX][mm][PATCH] fix migration race in rmap_walk
On Sat, 24 Apr 2010 11:43:24 +0100 Ouch. Hmm, how about the race in fork() I pointed out ? Thanks, -Kame --
Apr 25, 4:49 pm 2010
Greg KH
Re: [PATCH 5/9] PM: suspend_block: Add debugfs file
It's debug-like information, and has more than one value per file, so debugfs seems like the proper place for it. I have no objection to it going there. thanks, greg k-h --
Apr 25, 11:15 am 2010
Randy Dunlap
Re: [PATCH 5/9] PM: suspend_block: Add debugfs file
I have no objection if it really is debug info, but I'm not convinced of that yet. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Apr 25, 12:53 pm 2010
Avi Kivity
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
Even when frontswapping to RAM on a bare metal hypervisor it makes sense to use an async API, in case you have a DMA engine on board. -- error compiling committee.c: too many arguments to function --
Apr 25, 7:15 am 2010
Dan Magenheimer
RE: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
While I admit that I started this whole discussion by implying that frontswap (and cleancache) might be useful for SSDs, I think we are going far astray here. Frontswap is synchronous for a reason: It uses real RAM, but RAM that is not directly addressable by a (guest) kernel. SSD's (at least today) are still I/O devices; even though they may be very fast, they still live on a PCI (or slower) bus and use DMA. Frontswap is not intended for use with I/O devices. Today's memory technologies ...
Apr 25, 6:37 am 2010
Dan Magenheimer
RE: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
Umm... I think the difference between a "new" API and extending an existing one here is a choice of semantics. As designed, frontswap is an extremely simple, only-very-slightly-intrusive set of hooks that allows swap pages to, under some conditions, go to pseudo-RAM instead of an asynchronous disk-like device. It works today with at least one "backend" (Xen tmem), is shipping today in real distros, and is extremely easy to enable/disable via CONFIG or module... meaning no impact on anyone ...
Apr 24, 5:30 pm 2010
Dan Magenheimer
RE: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
Yes, indeed, this is true. That is why it is important for any policy implemented behind frontswap to "bill" the guest if it is attempting to keep frontswap pages in the hypervisor forever and to prod the guest to reclaim them when it no longer needs super-fast emergency swap space. The frontswap patch already includes the kernel mechanism to enable this and the prodding can be implemented by a guest daemon (of which there already exists an existence proof). (While devil's advocacy is ...
Apr 24, 5:41 pm 2010
Nitin Gupta
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
No: trim or discard is not useful. The problem is that we require a callback _as soon as_ a page (swap slot) is freed. Otherwise, stale data quickly accumulates in memory defeating the whole purpose of in-memory compressed swap devices (like ramzswap). Increasing the frequency of discards is also not an option: - Creating discard bio requests themselves need memory and these swap devices come into picture only under low memory conditions. - We need to regularly scan swap_map to issue these ...
Apr 24, 8:11 pm 2010
Avi Kivity
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
In this case you could use the same mechanism to stop new put_page()s? Seems frontswap is like a reverse balloon, where the balloon is in Good to know. -- error compiling committee.c: too many arguments to function --
Apr 25, 5:06 am 2010
Avi Kivity
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
My issue is with the API's synchronous nature. Both RAM and more exotic memories can be used with DMA instead of copying. A synchronous No need to change the kernel at all; the hypervisor controls the page I see. Given that swap-to-flash will soon be way more common than frontswap, it needs to be solved (either in flash or in the swap code). -- error compiling committee.c: too many arguments to function --
Apr 25, 5:11 am 2010
Avi Kivity
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
Doesn't flash have similar requirements? The earlier you discard, the I'm not sure. Swap-to-flash will soon be everywhere. If it's slow, Even for copying to RAM an async API is wanted, so you can dma it instead of copying. -- error compiling committee.c: too many arguments to function --
Apr 25, 5:16 am 2010
Dan Magenheimer
RE: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
You are suggesting the hypervisor communicate dynamically-rapidly-changing physical memory availability information to a userland daemon in each guest, and each daemon communicate this information to each respective kernel to notify the kernel that hypervisor memory is not available? Seems very convoluted to me, and anyway it doesn't eliminate the need That's a reasonable analogy. Frontswap serves nicely as an emergency safety valve when a guest has given up (too) much of its memory via ...
Apr 25, 6:12 am 2010
Avi Kivity
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
Yeah, it's pretty ugly. Balloons typically communicate without a daemon (or ordinary swap) -- error compiling committee.c: too many arguments to function --
Apr 25, 6:18 am 2010
Dan Magenheimer
RE: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
When pages are 2MB, this may be true. When pages are 4KB and copied individually, it may take longer to program a DMA engine than to just copy 4KB. But in any case, frontswap works fine on all existing machines today. If/when most commodity CPUs have an asynchronous RAM DMA engine, an asynchronous API may be appropriate. Or the existing swap API might be appropriate. Or the synchronous frontswap API may work fine too. Speculating further about non-existent hardware that might exist in ...
Apr 25, 8:29 am 2010
Nitin Gupta
Re: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
No. We do not want to issue discard for every page as soon as it is freed. I'm not flash expert but I guess issuing erase is just too expensive to be issued so frequently. OTOH, ramzswap needs a callback for every page and as Ok, but still all this bio allocation and block layer overhead seems unnecessary and is easily avoidable. I think frontswap code needs frontswap simply calls frontswap_flush_page() in swap_entry_free() i.e. as Optimizing swap-to-flash is surely desirable but this ...
Apr 25, 9:05 am 2010
Michael S. Tsirkin
Re: [Bugme-new] [Bug 15709] New: swapper page allocation ...
Hmm. I have these CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y CONFIG_KALLSYMS_EXTRA_PASS=y --
Apr 25, 2:18 am 2010
Robert Wimmer
Re: [Bugme-new] [Bug 15709] New: swapper page allocation ...
I've added CONFIG_KALLSYMS and CONFIG_KALLSYMS_ALL to my .config. I've uploaded the dmesg output. Maybe it helps a little bit: https://bugzilla.kernel.org/attachment.cgi?id=26138 - Robert --
Apr 25, 1:41 pm 2010
Michael S. Tsirkin
Re: [Bugme-new] [Bug 15709] New: swapper page allocation ...
So, it's an NFS-related regression, which is consistent with the bisect results. I guess someone who knows about NFS will have to look at it... BTW, you probably want to label the bug as regression. --
Apr 25, 1:49 pm 2010
Mike Rapoport
Re: [PATCH] ds2782_battery: add support for ds2786 batte ...
Hi Ryan, Shall we move ds2782_battery.c to ds278x_battery.c at the same time? It's possible to have get_rsns and coalesce _get_current for both chips. However, ds2872 and ds2786 need slightly different formula for current calculations. Part of these calculations can be wrapped into Here again we need to add the divider and RARC register to the info Summarizing all the parameters that should be added to the info structure we'd get here switch with lots of 'param = ...
Apr 25, 8:33 am 2010
Ryan Mallon
Re: [PATCH] ds2782_battery: add support for ds2786 batte ...
Fair enough. I just didn't want to have two versions of each function, that were doing almost the same thing. If you think it is cleaner/clearer to have separate functions, then stick with that. ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St ryan@bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 ...
Apr 25, 1:44 pm 2010
Pavel Machek Apr 25, 12:13 am 2010
Linus Torvalds
Re: [Patch 1/1] init: Provide a kernel start parameter t ...
Iirc, some _really_ old code used 'short' for pid_t, and we wanted to be really safe when we raised the limits. I seriously doubt we need to worry about old binaries like that on any 16+ CPU machines, though. The other issue is just the size of the pidmap[] array. Instead of walking all the processes to see "is this pid in use" (like I think the original Linux kernel did), we have a bitmap of used pids. When you raise pid_max, that bitmap obviously still needs to be big enough. ...
Apr 25, 10:15 am 2010
Pavel Machek
Re: [Patch 1/1] init: Provide a kernel start parameter t ...
Issue with max_pids is that it can break userspace, right? At that point it seems saner to require a parameter --- just adding cpus to the system should not do it... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Apr 25, 12:16 am 2010
Linus Torvalds
Re: [Patch 1/1] init: Provide a kernel start parameter t ...
.. I dug into the history, and this is from August 2002.. We used to limit it to sixteen bits, but that was too tight even then for some people, so first we did this: Author: Linus Torvalds <torvalds@home.transmeta.com> Date: Thu Aug 8 03:57:42 2002 -0700 Make pid allocation use 30 of the 32 bits, instead of 15. diff --git a/include/linux/threads.h b/include/linux/threads.h index 880b990..6804ee7 100644 --- a/include/linux/threads.h +++ ...
Apr 25, 10:27 am 2010
Pavel Machek
Re: [Patch 1/1] init: Provide a kernel start parameter t ...
From principle of least surprise PoV: breaking old userspace when you pass special config option is less surpising than breaking old userspace when you add more CPUs. Whether the breakage will be common enough that this matters is other question. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Apr 25, 5:13 am 2010
Serge E. Hallyn
Re: [PATCH 3/3] p9auth: add p9auth driver
Well I'm not convinced that it's a worthwhile tradeoff for polluting /proc/filesystems and needing yet another fs mounted in each container, but a preliminary working version using an fs is at http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sergeh/linux-cr.git;a=shortlog;h=r... I'll do some cleanup before sending it out. Eric, I'd said that the device-based version was namespace-aware, but that meant that you could on grant and use capabilities in your own user ...
Apr 24, 8:24 pm 2010
Linus Torvalds
Re: [GIT PULL] ext4 fixes
Never attribute to forethought what can be sufficiently explained by incompetence. I just missed the email in all my confusion. Pulled, Linus --
Apr 25, 10:02 am 2010
tytso
Re: [GIT PULL] ext4 fixes
Ping? I'm guessing that perhaps you didn't pull because of concerns raised about some of the crazy dates in the ext4 tree. I've checked to make sure this isn't true for this set of patches, and I'll make sure the dates are well-behaved for the future. Best regards, - Ted --
Apr 24, 5:53 pm 2010
Andrea Arcangeli
Re: [PATCH 04/14] mm,migration: Allow the migration of P ...
Oh I just got the very crash you're talking about with aa.git with your v8 code. Weird that I never reproduced it before! I think it's because I fixed gcc to be fully backed by hugepages always (without khugepaged) and I was rebuilding a couple of packages, and that now triggers memory compaction much more, but mixed with heavy fork/execve. This is the only instability I managed to reproduce over 24 hours of stress testing and it's clearly not related to transparent hugepage support but it's ...
Apr 25, 7:41 am 2010
tytso
Re: [PATCH 3/4] writeback: pay attention to wbc->nr_to_w ...
Be careful here. If you are going to write more pages than what the writeback code has requested (the stupid no more than 1024 pages restriction in the writeback code before it jumps to start writing some other inode), you actually need to let the returned wbc->nr_to_write go negative, so that wb_writeback() knows how many pages it has written. In other words, the writeback code assumes that <orignal value of nr_to_write> - <returned wbc->nr_to_write> is <number of pages ...
Apr 24, 8:33 pm 2010
Tomas Winkler
Re: request_firmware API exhaust memory
Sorry maybe I was not clear what I mean that the memory will be eventually exhausted and system will crash Is this normal? Actually I less suspect now udevd as the same happens on android platform where there is no udev Tomas --
Apr 25, 12:22 pm 2010
Greg KH
Re: request_firmware API exhaust memory
That sounds normal for the free memory. Kay, that's also to be expected for the udevd forks as well, right? thanks, greg k-h --
Apr 25, 9:37 am 2010
Greg KH
Re: request_firmware API exhaust memory
Ah, no, that's not normal. Have you run kmemleak on your module (or Which is a sad thing for a whole other range of issues... thanks, greg k-h --
Apr 25, 12:36 pm 2010
Tomas Winkler
Re: request_firmware API exhaust memory
yes, one of my college has run the kmemleak but didn't bring much evidence. I've also looked into slubinfo as suggested by Johannes but don't see anything suspicions either but this is expected as everything is allocated through kmalloc and alloc_pages. I may rerun the kmemleak by myself but this shows up on too many setups and kernels with also full driver and also my simple test Said thing is that I don't see where the memory goes.... Anyhow I will try to run valgrin on udev just to be ...
Apr 25, 1:09 pm 2010
Jonathan Corbet
Re: [PATCH 10/11] viafb: rework the I2C support in the V ...
On Sat, 24 Apr 2010 15:53:16 +0200 OK, my proposal would be to add the following patch into the early part of the series; that will help to avoid the creation of confusion in the middle until the full i2c/gpio configuration code is in. Look good? Thanks, jon viafb: Only establish i2c busses on ports that always had them ...otherwise it seems we run into conflicts with shadowy other users which don't expect to see i2c taking control of ports it never used to do anything ...
Apr 25, 7:38 am 2010
Florian Tobias Schan ...
Re: [PATCH 10/11] viafb: rework the I2C support in the V ...
Hi Jon, Yes, it does. But it highlighted a bug in the original patch: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<c11df2db>] i2c_transfer+0x19/0xb0 *pdpt = 000000000af77001 *pde = 0000000000000000 Oops: 0000 [#1] PREEMPT last sysfs file: /sys/devices/virtual/vtconsole/vtcon1/bind Modules linked in: viafb(+) fbcon font bitblit softcursor fb i2c_algo_bit cfbcopyarea cfbimgblt cfbfillrect snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_pcm ...
Apr 25, 8:56 am 2010
Richard Röjfors
Re: [PATCH 1/2] media: Add timberdale video-in driver
1. dma_sg can not be used, the DMA engine requires the memory blocks to be aligned on a factor of bytes per line, so 4K pages wouldn't work. 2. I tried using videobuf-dma-contig, but got poor performance. I can not really explain why, I though it's due to the fact that the contiguous buffer is allocated coherent -> no caching. I saw both gstreamer and mplayer perform very badly. The frame grabber requires the DMA transfer for a frame beeing started while the frame is decoded. When I tested ...
Apr 25, 9:01 am 2010
Mauro Carvalho Chehab
Re: [PATCH 1/2] media: Add timberdale video-in driver
Why do you need a fixed DMA buffer size? Just allocate the buffer size dynamically at You should be using, instead, videobuf_dma_sg or videobuf_cont, instead of using videobuf-vmalloc. This way, you'll avoid double buffering. -- Cheers, Mauro --
Apr 25, 8:24 am 2010
Mauro Carvalho Chehab
Re: [PATCH 1/2] media: Add timberdale video-in driver
The better is to fix videobuf-dma_contig to better work on your hardware. It makes sense to add a flag to allow specifying if it should use coherent or non-coherent memory for the dma buffer alloc/free calls. -- Cheers, Mauro --
Apr 25, 9:13 am 2010
Mauro Carvalho Chehab
Re: [PATCH 0/2] media, mfd: Add timberdale video-in driver
No problem. I'll let you know after I get my ack. -- Cheers, Mauro --
Apr 25, 8:26 am 2010
Frederic Weisbecker
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal
Well, we won't be able to get this bkl.ko but the desired effect of having it was rather psychological than practical, as Arnd explained: to make the dependency more visible and pull concerned people into dropping the bkl from the drivers they are using. But other than that, the final effect remains pretty the same so it's not a big deal. I'm ok with that. Thanks for clarifying the situation! --
Apr 25, 11:05 am 2010
Linus Torvalds
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal
Seriously, why not just - .ioctl = foo, + .bkl_ioctl = foo because that line of + .unlocked_ioctl = bkl_ioctl, is just total and utter _garbage_. There is zero reason for it. In the long run (this is a year from now, when we rename "unlocked_ioctl" back to just "ioctl"), the vfs_ioctl code will just do struct file_operations *fops = filp->f_op; if (!fops) return -ENOTTY; if (fops->ioctl) { int error = fops->ioctl(...) if (error == ...
Apr 25, 10:49 am 2010
Frederic Weisbecker
Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal
Our final goal was not to have three different ioctl interfaces. This state was only deemed to be temporary. This was the only way to make the change smoother and don't conflict with other trees with a single monolithic patch. But if you are ok with a single one, then we are going this way and we'll send it for It's true, but once it gets pushed down/dropped from every core parts (which is what we are working on currently in parallel), lock_kernel() and .bkl_ioctl is only going to be ...
Apr 25, 10:39 am 2010
Amir Vadai
Re: SDP bugs 2027 and 2028
I have a fix for 2027 (number of SGE's issue) read. I'm busy with other things - but hopefully will succeed testing it and pushing it today. As to 2028 (No FMR support) - I need pushed a fix to only disable ZCopy when no FMR facility. I don't have time right now to add support for fast memory registeration when FMR is not available - but Steve said he'll help with implementing it. - Amir --
Apr 25, 12:35 am 2010
FUJITA Tomonori
Re: [PATCH -mm 06/12] m68k: use asm-generic/scatterlist.h
On Fri, 23 Apr 2010 10:29:04 +0200 asm-generic/scatterlist.h can't define ISA_DMA_THRESHOLD because of This patch needs to be applied against -mm; including some changes to asm-generic/scatterlist.h. I've attached asm-generic/scatterlist.h in -mm. = #ifndef __ASM_GENERIC_SCATTERLIST_H #define __ASM_GENERIC_SCATTERLIST_H #include <linux/types.h> struct scatterlist { #ifdef CONFIG_DEBUG_SG unsigned long sg_magic; #endif unsigned long page_link; unsigned int offset; unsigned ...
Apr 25, 6:46 am 2010
Geert Uytterhoeven
Re: [PATCH -mm 06/12] m68k: use asm-generic/scatterlist.h
On Sun, Apr 25, 2010 at 15:46, FUJITA Tomonori OK, I won't touch it. Please consider it acked-by, so it can go in through Andrew, together with the other patches. Sorry for the confusion. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus ...
Apr 25, 11:17 am 2010
Emmanuel Florac
Re: 2.6.34-rc3: simple du (on a big xfs tree) triggers o ...
No, I always use pristine unpatched kernel.org releases, no SELinux, no nothing. Just another confirmation I should go on this way :) -- ------------------------------------------------------------------------ Emmanuel Florac | Direction technique | Intellique | <eflorac@intellique.com> | +33 1 78 94 84 02 ------------------------------------------------------------------------ --
Apr 25, 6:04 am 2010
Greg KH
Re: 2.6.34-rc3: simple du (on a big xfs tree) triggers o ...
Is 2.6.33.3-rc2 affected? A lot of xfs patches are in there (as are in 2.6.32.12-rc2.) thanks, greg k-h --
Apr 25, 9:27 am 2010
Christoph Hellwig
Re: 2.6.34-rc3: simple du (on a big xfs tree) triggers o ...
Yes. It's not even in mainline yet as Nick doesn't like the trivial core VM fix required to solve this in a clean way. --
Apr 25, 9:57 am 2010
Greg KH
Re: 2.6.34-rc3: simple du (on a big xfs tree) triggers o ...
Hm, Nick, why? This seems like a real problem, easily reproduced. Is it solved some other way in Linus's tree that we could backport to the -stable series? thanks, greg k-h --
Apr 25, 11:18 am 2010
Bruno Prémont
[PATCH] hid: split picolcd's operation_mode sysfs attribute
Original operation_mode sysfs attribute accepts the operation mode as main value with an option delay as second value to change the start-up delay on mode change. As it is preferred to have exactly one value per sysfs attribute, extract this delay into a separate sysfs attribute called operation_mode_delay. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> --- Documentation/ABI/testing/sysfs-driver-hid-picolcd | 17 ++++- drivers/hid/hid-picolcd.c | 62 ...
Apr 25, 12:29 pm 2010
Rafael J. Wysocki
Re: commit 9630bdd9 changes behavior of the poweroff - bug?
Please try the patch below. It kind of restores the previous behavior, let's see if it changes anything. Rafael --- drivers/acpi/acpica/evgpeblk.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux-2.6/drivers/acpi/acpica/evgpeblk.c =================================================================== --- linux-2.6.orig/drivers/acpi/acpica/evgpeblk.c +++ linux-2.6/drivers/acpi/acpica/evgpeblk.c @@ -364,7 +364,7 @@ acpi_ev_match_prw_and_gpe(acpi_handle ob ...
Apr 24, 7:35 pm 2010
Rafael J. Wysocki
Re: commit 9630bdd9 changes behavior of the poweroff - bug?
If it doesn't help, please try to comment out the acpi_enable_gpe() in drivers/acpi/wakeup.c:acpi_wakeup_device_init() and retest (if you haven't done that already). Rafael --
Apr 24, 8:15 pm 2010
Yuhong Bao
RE: KVM warning about uncertified CPU for SMP for AMD mo ...
And BTW, another such old once common unsupported configuration that theLinux kernel never detected is the old dual Celerons. At first achieved byhacking slockets, later ABIT released the BP6 motherboard with dualSocket 370 specifically wired to allow this config. They were once commonamong the enthusiast community, Ars Technica among other review siteshad old articles about it. Yuhong Bao _________________________________________________________________ The New Busy is not the too busy. ...
Apr 24, 9:22 pm 2010
Giel van Schijndel
Re: [PATCH 2/3] hwmon: f71882fg: use a muxed resource lo ...
Fix a bug which caused f71882fg_find() to pretend to be succesfull on Super I/O ports which didn't have a Fintek chip attached. This was caused by returning 0 instead of -ENODEV, adding several 'err = -ENODEV' statements preceding the 'goto exit' statements fixed this. Patch follows this line: ======================================================================== Sleep while acquiring a resource lock on the Super I/O port. This should prevent collisions from causing the hardware probe to ...
Apr 25, 3:35 am 2010
Jim Cromie
Re: [lm-sensors] [PATCH 4/4] [RFC] hwmon: f71882fg: Add ...
For my part, I started seeing difficulties in the centralized probing, esp around the unlocking sequences; stuff thats device specific, but wanted to be hidden in the centralized probe. When it was just byte-sequences, "coordinator" was meant to imply cooperative drivers, though thats *always* the case, in that drivers would at least --
Apr 25, 2:20 pm 2010
Paul E. McKenney
Re: [PATCH] RCU: don't turn off lockdep when find suspic ...
This should be covered by the patch I sent with my previous email. And thank you again, Miles, for all the testing!!! Thanx, Paul --
Apr 24, 7:36 pm 2010
Paul E. McKenney
Re: [PATCH] RCU: don't turn off lockdep when find suspic ...
According to Documentation/cgroups/cgroups.txt, we must hold cgroup_mutex, the task's task_alloc lock, or be in an RCU read-side critical section. We are in neither of these. I would argue that sched_setscheduler() should take care of synchronization, but am not sure which of these three are appropriate Please see below for a patch for this based on my earlier conversation with Vivek Goyal. (Vivek, if you are already pushing a fix elsewhere, This is a repeat from last time that ...
Apr 24, 7:34 pm 2010
Johannes Berg
Re: [PATCH] RCU: don't turn off lockdep when find suspic ...
The station locking is a tad confusing, but I've added the right annotations already, should be coming to a kernel near you soon (i.e. are in net-2.6 right now). johannes --
Apr 25, 12:45 am 2010
David Miller
Re: [PATCH] RCU: don't turn off lockdep when find suspic ...
From: Johannes Berg <johannes@sipsolutions.net> Linus took in everything I have so it should be in Linus's tree by now. --
Apr 25, 12:49 am 2010
Miles Lane
Re: [PATCH] RCU: don't turn off lockdep when find suspic ...
On Sat, Apr 24, 2010 at 10:34 PM, Paul E. McKenney I am down to seeing three suspicious rcu_dereference_check traces when I apply this patch and all the previous patches to 2.6.34-rc5-git6. 1. The "__sched_setscheduler+0x19d/0x300" trace. 2. The two "is_swiotlb_buffer+0x2e/0x3b" traces (waiting to see Johannes' patch show up in a Linux snapshot) Did I miss a patch for the setscheduler issue? Thanks! Miles --
Apr 25, 8:49 am 2010
Miles Lane
Re: [PATCH] RCU: don't turn off lockdep when find suspic ...
Hmm. I am still seeing these two messages as well. [ 83.363146] [ INFO: suspicious rcu_dereference_check() usage. ] [ 83.363148] --------------------------------------------------- [ 83.363151] include/net/inet_timewait_sock.h:227 invoked rcu_dereference_check() without protection! [ 83.363154] [ 83.363155] other info that might help us debug this: [ 83.363156] [ 83.363158] [ 83.363159] rcu_scheduler_active = 1, debug_locks = 1 [ 83.363162] 2 locks held by ...
Apr 25, 1:20 pm 2010
Tejun Heo
Re: [PATCHSET UPDATED] workqueue: concurrency managed wo ...
Hello, I've just updated the git tree. git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git review-cmwq The original take#4 is now in branch review-cmwq-3. This will probably become take#5 soonish but I don't have access to my test machines for some days, so this is sort of take#5 pre-release. Changes are... * The patchset is rebased on cpu_stop + sched/core. cpu_stop already reimplements stop_machine so that it doesn't use RT workqueue, so this patchset simply drops RT wq ...
Apr 25, 1:09 am 2010
previous daytodaynext day
April 24, 2010April 25, 2010April 26, 2010