[ Please CC - I am not subscribed to LKML ]

[QUOTE]



How to do it? Would you please publish a reverting patch?

Regards,

Piotr Hosowicz

[/QUOTE]

Hi,

did forget to mention 2.6.34-rc5-git5 was OK.

Revering this commit did not help:

commit f4f914b58019f0e50d521bbbadfaee260d766f95
net: ipv6 bind to device issue

After looking into net-2.6 GIT repository, "tcp: bind() fix when many
ports are bound" could cause indeed the problems here, too.
Building now....

Regards,
- Sedat -

P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch
[ message continues ]

Thanks a lot. Applied and building now.

Regards,

Piotr Hosowicz

-- 
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach:
- W którym kraju znajduje się Mount Everest?
- Hm, to nie Szkocja, prawda?
NP: Mark Knopfler - Cleaning My Gun
NB: 2.6.34-rc5-git5
--

[ message continues ]

[ CCing netdev ML ]

Confirmed: The revert-patch [1] fixes the problem here.

See also "Bug 15847 -  crash in inet6_csk_bind_conflict" [2].

Feel free to add a... Tested-by: Sedat Dilek <sedat.dilek@gmail.com>

- Sedat -

[1] https://patchwork.kernel.org/patch/94959/
[2] https://bugzilla.kernel.org/show_bug.cgi?id=15847

--

[ message continues ]

I added created and tested phrase in my archive. ;-) Thank you a lot. I 
hope there will be no this error in git7.

Regards,



-- 
Grupa marzeń w eliminacjach MŚ :
Zimbabwe, Alaska, Grenlandia, Antarktyda i Zair.
NP: Chickenfoot - Oh Yeah
NB: 2.6.34-rc5-git6
--

[ message continues ]

Did you test the proposed fix ?


[PATCH] ipv6: Fix inet6_csk_bind_conflict()

Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound)
introduced a bug on IPV6 part.
We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but
ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is
IPV6.

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
index b4b7d40..3a4d92b 100644
--- a/net/ipv6/inet6_connection_sock.c
+++ b/net/ipv6/inet6_connection_sock.c
@@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk,
 			     ipv6_rcv_saddr_equal(sk, sk2))
 				break;
 			else if (sk->sk_reuse && sk2->sk_reuse &&
-				!ipv6_addr_any(inet6_rcv_saddr(sk2)) &&
+				!ipv6_addr_any(inet6_rcv_saddr(sk)) &&
 				ipv6_rcv_saddr_equal(sk, sk2))
 				break;
 		}


--

[ message continues ]

Rebuild ipv6 kernel-modules by:

$ make M=net/ipv6

...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually
to the right place.

Applied your patch (seen on netdev ML) already and booted into new kernel.
Works, thanks.

Tested-by: Sedat Dilek <sedat.dilek@gmail.com>

- Sedat -

[ message continues ]

Eric, but where to get the proposed fix as a patch? I looked at kernel's 
bugzilla and there is no such thing. As for now I applied Sedat's 
reverse patch and now I am booted fine in git6 kernel.

Regards,



-- 
"Bardzo fajna firma, tylko czasami nie płaci. Do jej głównych
zalet należą: ekspres ciśnieniowy (ale tylko na jednym z pię-
ter) oraz fajne widoki z salki konferencyjnej. No i jakieś
pół roku temu odeszło 90% pracowników działu IT, ale może nie
mieli racji ;)"
NP: Chickenfoot - Soap On A Rope
NB: 2.6.34-rc5-git6
--

[ message continues ]

I wont spend my Sunday time at filling bugzilla entries.

I sent a patch on netdev.

I finaly could test it (I have a very slow machine while traveling, and
compiling the thing took a *lot* of time)

Now back to family affairs ;)



--

[ message continues ]

For easy catching proposed patched to LKML look at <patchwork.kernel.org> [1].
There you find other mailing-lists and further patches.
Cut-N-Paste excerpts of Eric's email should also work :-).

- Sedat -

[1] https://patchwork.kernel.org/project/LKML/list/
[2] https://patchwork.kernel.org/patch/94961/
--

[ message continues ]