login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
April
»
25
Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: David Miller
Subject:
Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.
Date: Sunday, April 25, 2010 - 2:51 am
From: Changli Gao <xiaosuo@gmail.com> Date: Sun, 25 Apr 2010 17:33:02 +0800
quoted text
> On Sun, Apr 25, 2010 at 5:19 PM, <xiaohui.xin@intel.com> wrote: >> +static int dev_is_mpassthru(struct net_device *dev) >> +{ >> + if (dev && dev->mp_port) >> + return 1; >> + return 0; >> +} >> + > > Please make it a inline function. And you would write it with less > lines of code. > > return dev && dev->mp_port;
And use "bool" :-) --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RFC][PATCH v4 01/18] Add a new struct for device to manip ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 02/18] Export 2 func for device to assign/d ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 03/18] Add a ndo_mp_port_prep pointer to ne ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 04/18] Add a function make external buffer ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 05/18] Add a function to indicate if device ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 06/18] Add interface to get external buffers.
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 07/18] Make __alloc_skb() to get external b ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 08/18] Ignore skb_reserve() when device is ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 09/18] Don't do skb recycle, if device use ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 10/18] Use callback to deal with skb_releas ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 11/18] Add a hook to intercept external buf ...
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 12/18] To skip GRO if buffer is external.
, xiaohui.xin
, (Sun Apr 25, 2:19 am)
[RFC][PATCH v4 13/18] Add header file for mp device.
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
[RFC][PATCH v4 14/18] Add basic func and special ioctl to ...
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
[RFC][PATCH v4 15/18] Manipulate external buffers in mp de ...
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
[RFC][PATCH v4 16/18] Export proto_ops to vhost-net driver.
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
[RFC][PATCH v4 17/18] Add a kconfig entry and make entry f ...
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
[RFC][PATCH v4 18/18] Provides multiple submits and async ...
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
[RFC][PATCH v4 00/18] Provide a zero-copy method on KVM vi ...
, xiaohui.xin
, (Sun Apr 25, 2:20 am)
Re: [RFC][PATCH v4 05/18] Add a function to indicate if de ...
, Changli Gao
, (Sun Apr 25, 2:33 am)
Re: [RFC][PATCH v4 05/18] Add a function to indicate if de ...
, Changli Gao
, (Sun Apr 25, 2:35 am)
Re: [RFC][PATCH v4 05/18] Add a function to indicate if de ...
, David Miller
, (Sun Apr 25, 2:51 am)
Re: [RFC][PATCH v4 05/18] Add a function to indicate if de ...
, David Miller
, (Sun Apr 25, 2:51 am)
Re: [RFC][PATCH v4 00/18] Provide a zero-copy method on KV ...
, David Miller
, (Sun Apr 25, 2:55 am)
Re: [RFC][PATCH v4 00/18] Provide a zero-copy method on KV ...
, Michael S. Tsirkin
, (Sun Apr 25, 5:14 am)
RE: [RFC][PATCH v4 00/18] Provide a zero-copy method on KV ...
, Xin, Xiaohui
, (Wed Apr 28, 6:33 pm)
RE: [RFC][PATCH v4 05/18] Add a function to indicate if de ...
, Xin, Xiaohui
, (Wed Apr 28, 6:38 pm)
RE: [RFC][PATCH v4 00/18] Provide a zero-copy method on KV ...
, Xin, Xiaohui
, (Sat May 8, 12:55 am)
Re: [RFC][PATCH v4 00/18] Provide a zero-copy method on KV ...
, Michael S. Tsirkin
, (Sun May 9, 2:26 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michael Moore
Re: underage models, pre teen models, lolita porn, young preteens, little lolitas
Alex Riesen
Re: [PATCH 4/7] lib: Introduce strnstr()
Thomas Gleixner
[ANNOUNCE] 2.6.31-rc6-rt2
Mathieu Desnoyers
Re: Linux 2.6.25-rc2
git
:
Blaisorblade
git-unpack-objects < pack file in repository doesn't work!
Matthieu Moy
Re: Cloning empty repositories, was Re: What is the idea for bare repositories?
Linus Torvalds
Re: Untracked working tree files
Peter Karlsson
Re: CRLF problems with Git on Win32
Johannes Schindelin
Re: [PATCH 4/4] git-rebase -i: New option to support rebase with merges
linux-netdev
:
Alan Menegotto
Re: Linux networking implementation and packet capture
Andrew Morton
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes
Timo Teräs
ip xfrm policy semantics
Jarek Poplawski
Re: [PATCH]: Fix queueing return values...
David Miller
Re: [PATCH 1/2] netdev: bfin_mac: enable bfin_mac net dev driver for BF51x
git-commits-head
:
Linux Kernel Mailing List
Blackfin: don't give CPU its own line in traps output
Linux Kernel Mailing List
No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List
x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List
MIPS: SMTC: Fix lockup in smtc_distribute_timer
Linux Kernel Mailing List
powerpc: gamecube/wii: usbgecko bootwrapper console support
openbsd-misc
:
Aaron Mason
Re: Defending OpenBSD Performance
Henning Brauer
Re: Defending OpenBSD Performance
Henning Brauer
Re: Defending OpenBSD Performance
Christiano Farina Haesbaert
Re: Defending OpenBSD Performance
Nick Holland
Re: 1 out of 3 hunks failed--saving rejects to kerberosV/src/lib/krb5/crypto.c.rej
Colocation donated by:
Syndicate