login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
April
»
23
Re: USBIP (staging) driver's dependency on drivers/usb/core internal headers
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Greg KH
Subject:
Re: USBIP (staging) driver's dependency on drivers/usb/core internal headers
Date: Friday, April 23, 2010 - 9:37 am
On Fri, Apr 23, 2010 at 06:31:28PM +0200, Eric Lescouet wrote:
quoted text
> Greg KH wrote: > >On Fri, Apr 23, 2010 at 11:52:26AM -0400, Alan Stern wrote: > >>On Fri, 23 Apr 2010, Greg KH wrote: > >> > >>>On Fri, Apr 23, 2010 at 12:44:11PM +0200, Eric Lescouet wrote: > >>>>Hi, > >>>> > >>>>The USBIP modules (and some others) have a direct dependency on the following headers: > >>>>- drivers/usb/core/hdc.h (struct usb_hcd and various routines) > >>>>- drivers/usb/core/hub.h (couple of constants) > >>>>Because those headers are not part of include/, it makes it quite difficult > >>>>to compile them as standalone modules (e.g.: against pre-compiled kernel). > >>>Then don't do that :) > >>> > >>>>hdc.c and hub.c are relatively self-contained and could be moved to e.g.: include/linux/usb/. > >>>> > >>>>What do you think? > >>>I think the code needs to be cleaned up and merged to the main part of > >>>the kernel tree, then this wouldn't be an issue, right? > >>I think moving hub.h into include/linux/usb would be a good > >>thing. However, if this is done then the file contents should > >>be rearranged slightly: > >> > >> Everything from the "Hub request types" comment through the > >> various HUB_TTTT_* definitions (except the line declaring > >> struct usb_device) should be extracted into a separate file. > >> This new file could be called ch11.h (because it contains > >> constants and structures from Chapter 11 of the USB 2.0 spec, > >> just as ch9.h contains information from Chapter 9) or it > >> could keep the name hub.h. It could even be exported as > >> a userspace header file. > >> > >> The remainder (not very much) should be merged into hcd.h. > >> > >>Once that's done, moving hcd.h into include/linux/usb would be a > >>reasonable thing to do as well. It is shared between usbcore > >>and the HCDs, so it really does belong in a more public > >>location. > > > >Ok, fair enough. Patches are always welcome :) > > > >thanks, > > > >greg k-h > > If I understand correctly, splitting hub.h into hub.h + ch11.h is > independent of the move. At the end the 2 (or 3 files) would end up > into include/linux/usb/. > correct? > > I've tried to move hub.h and hcd.h and to compile the kernel, already. > Changing the path of the #include directives in ~40 files did the trick.
40 files need to be changed? wow.
quoted text
> Would you like 2 patches (move and then split) or only 1?
Move and then split is fine. thanks, greg k-h --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
Re: USBIP (staging) driver's dependency on drivers/usb/cor ...
, Alan Stern
, (Fri Apr 23, 8:52 am)
Re: USBIP (staging) driver's dependency on drivers/usb/cor ...
, Greg KH
, (Fri Apr 23, 9:14 am)
Re: USBIP (staging) driver's dependency on drivers/usb/cor ...
, Eric Lescouet
, (Fri Apr 23, 9:31 am)
Re: USBIP (staging) driver's dependency on drivers/usb/cor ...
, Greg KH
, (Fri Apr 23, 9:37 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar
Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Jan Engelhardt
Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection
Dmitry Torokhov
Re: [2.6 patch] input/serio/hp_sdc.c section fix
Rafael J. Wysocki
[Bug #16380] Loop devices act strangely in 2.6.35
git
:
Steven Grimm
Using git as a general backup mechanism (was Re: Using GIT to store /etc)
Jeff King
Re: [PATCH] git-reset: allow --soft in a bare repo
Johannes Sixt
Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
Johannes Schindelin
Re: [PATCH] Uninstall rule for top level Makefile
Shawn O. Pearce
Re: [PATCH v2] Speed up bash completion loading
git-commits-head
:
Linux Kernel Mailing List
cgroups: clean up cgroup_pidlist_find() a bit
Linux Kernel Mailing List
sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List
IB/core: Add support for masked atomic operations
Linux Kernel Mailing List
V4L/DVB (8939): cx18: fix sparse warnings
Linux Kernel Mailing List
ipv6 mcast: Check address family of gf_group in getsockopt(MS_FILTER).
linux-netdev
:
Inaky Perez-Gonzalez
[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil
[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
linux
Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?
David Miller
Re: tun: Use netif_receive_skb instead of netif_rx
David Miller
Re: [net-next PATCH v2] llc enhancements
freebsd-current
:
Matthew Fleming
Re: [RFC] Outline of USB process integration in the kernel taskqueue system
illoai@gmail.com
Re: OT: 2d password
Hartmut Brandt
Re: problem with nss_ldap
Andrew Reilly
Re: FreeBSD's problems as seen by the BSDForen.de community
Max Laier
Re: Upcoming ABI Breakage in RELENG_7
Colocation donated by:
Syndicate