Home » Mailing list archives » linux-kernel » 2010 » April » 22

Re: [PATCH 1/2] mm: add context argument to shrinker callback

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin
Subject: Re: [PATCH 1/2] mm: add context argument to shrinker callback
Date: Thursday, April 22, 2010 - 9:57 am

On Thu, Apr 22, 2010 at 12:42:47PM -0400, Christoph Hellwig wrote:

I don't know. It's not really caused by not registering multiple
shrinkers. It seems to be caused more by the locking, which is not
going away when you have multiple shrinkers.

The XFS patch seems to be pinning the mount structure when it is
registered, so it would have no such locking/refcounting problems
using a private list AFAIKS.



I would say less useful, because shrinker structure cannot be used
by anything but the shrinker, wheras a private list can be used by
anything, including the applicable shrinker.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner, (Mon Apr 12, 5:24 pm)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, KOSAKI Motohiro, (Tue Apr 13, 1:17 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Christoph Hellwig, (Sat Apr 17, 5:15 pm)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin, (Mon Apr 19, 7:00 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner, (Mon Apr 19, 5:41 pm)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin, (Tue Apr 20, 1:38 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner, (Tue Apr 20, 3:32 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin, (Wed Apr 21, 1:40 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Christoph Hellwig, (Thu Apr 22, 9:32 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin, (Thu Apr 22, 9:38 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Christoph Hellwig, (Thu Apr 22, 9:42 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Nick Piggin, (Thu Apr 22, 9:57 am)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner, (Thu Apr 22, 6:58 pm)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Dave Chinner, (Tue Apr 27, 8:38 pm)
Re: [PATCH 1/2] mm: add context argument to shrinker callback, Avi Kivity, (Wed Apr 28, 2:39 am)