Re: [PATCH] Staging: Comedi: Drivers: Fix coding style issues in dt2801.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Joe Perches

Subject: Re: [PATCH] Staging: Comedi: Drivers: Fix coding style issues in dt2801.c

Date: Wednesday, April 21, 2010 - 9:36 pm

On Thu, 2010-04-22 at 06:13 +0200, Wolfram Sang wrote:
quoted text> What about dev_* in case there are more than one of those devices?

or netdev_<level>

quoted text> Also, KERN_INFO doesn't look right, KERN_WARN?

KERN_WARNING.  Maybe kernel.h should add:
#define pr_warn pr_warning 

so there would be symmetry between levels of
pr_<level>, dev_<level>, netdev_<level>, and netif_<level>


--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Staging: Comedi: Drivers: Fix coding style issues ..., Gustavo Silva, (Wed Apr 21, 8:46 pm)

Re: [PATCH] Staging: Comedi: Drivers: Fix coding style iss ..., Joe Perches, (Wed Apr 21, 9:00 pm)

Re: [PATCH] Staging: Comedi: Drivers: Fix coding style iss ..., Wolfram Sang, (Wed Apr 21, 9:13 pm)

Re: [PATCH] Staging: Comedi: Drivers: Fix coding style iss ..., Gustavo Silva, (Wed Apr 21, 9:23 pm)

Re: [PATCH] Staging: Comedi: Drivers: Fix coding style iss ..., Joe Perches, (Wed Apr 21, 9:36 pm)

Re: [PATCH] Staging: Comedi: Drivers: Fix coding style iss ..., Wolfram Sang, (Wed Apr 21, 11:31 pm)


linux-kernel:
Paul Turner	[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Matthew Garrett	Re: [PATCH] Enable speedstep for sonoma processors.
Mauro Carvalho Chehab	Re: [PATCH 1/2] media: Add timberdale video-in driver
Peter Zijlstra	[PATCH 23/30] netvm: skb processing
Greg Kroah-Hartman	[PATCH 21/28] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on
git:
Jan Hudec	Re: GIT push to sftp (feature request)
Steffen Prohaska	[PATCH 0/4] core.ignorecase
Johannes Schindelin	Re: Git checkout preserve timestamp?
Linus Torvalds	[PATCH 1/7] Make unpack_trees_options bit flags actual bitfields
Johan Herland	Re: What's cooking in git.git (Oct 2010, #01; Wed, 13)
linux-netdev:
David Miller	Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Richard Cochran	Re: [PATCH v3 3/3] ptp: Added a clock that uses the eTSEC found on the MPC85xx.
Jan Engelhardt	Re: [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div()
Herbert Xu	Re: [RFC PATCH 00/17] virtual-bus
Jeff Kirsher	Re: [net-next-2.6 PATCH] e1000e: don't inadvertently re-set INTX_DISABLE
git-commits-head:
Linux Kernel Mailing List	ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
Linux Kernel Mailing List	Use path_put() in a few places instead of {mnt,d}put()
Linux Kernel Mailing List	mv643xx_eth: use sw csum for big packets
Linux Kernel Mailing List	arm: fix HAVE_CLK merge goof
Linux Kernel Mailing List	arm: convert pcm037 platform to use smsc911x
freebsd-current:
David Wolfskill	"interrupt storm..."; seems associated with an0 NIC
Andriy Gapon	Re: letting glabel recognise a media change
Garrett Cooper	Re: Only display ACPI bootmenu key if ACPI is present
Pyun YongHyeon	CFT: msk(4) Rx checksum offloading support
FreeBSD Tinderbox	[head tinderbox] failure on sparc64/sparc64