Re: [PATCH] bfa: fix compilation warning in powerpc (resend)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Wednesday, April 21, 2010 - 4:12 pm

On Tue, 13 Apr 2010 12:22:29 -0700
Jing Huang <huangj@Brocade.com> wrote:


When fixing a warning, please quote that warning in the patch description!

<does a cross-build>

It seems that you're referring to this:

drivers/scsi/bfa/bfa_ioc.c: In function 'bfa_ioc_msgget':
drivers/scsi/bfa/bfa_ioc.c:1331: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_notify_hbfail':
drivers/scsi/bfa/bfa_ioc_ct.c:177: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c:180: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_pll_init':
drivers/scsi/bfa/bfa_ioc_ct.c:381: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_ownership_reset':
drivers/scsi/bfa/bfa_ioc_ct.c:421: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_cb.c: In function 'bfa_ioc_cb_notify_hbfail':
drivers/scsi/bfa/bfa_ioc_cb.c:99: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_cb.c: In function 'bfa_ioc_cb_ownership_reset':
drivers/scsi/bfa/bfa_ioc_cb.c:272: warning: value computed is not used



When fixing a bug, please fully describe the bug!

If this driver has "endian issues" on powerpc then it's quite possible
that this is a running-around-with-hair-on-fire,
must-backport-to-2.6.33.x bugfix.

But how would I know?  You didn't tell me!


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] bfa: fix compilation warning in powerpc (resend), Andrew Morton, (Wed Apr 21, 4:12 pm)