[PATCH] mfd: WM8350: remove incorrect kfree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rabin Vincent
Date: Wednesday, April 21, 2010 - 8:36 am

The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Rabin Vincent <rabin@rab.in>
---
 drivers/mfd/wm8350-i2c.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/wm8350-i2c.c b/drivers/mfd/wm8350-i2c.c
index 65830f5..5fe5de1 100644
--- a/drivers/mfd/wm8350-i2c.c
+++ b/drivers/mfd/wm8350-i2c.c
@@ -64,10 +64,8 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,
 	int ret = 0;
 
 	wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
-	if (wm8350 == NULL) {
-		kfree(i2c);
+	if (wm8350 == NULL)
 		return -ENOMEM;
-	}
 
 	i2c_set_clientdata(i2c, wm8350);
 	wm8350->dev = &i2c->dev;
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] mfd: WM8350: remove incorrect kfree, Rabin Vincent, (Wed Apr 21, 8:36 am)
Re: [PATCH] mfd: WM8350: remove incorrect kfree, Mark Brown, (Wed Apr 21, 10:42 am)
Re: [PATCH] mfd: WM8350: remove incorrect kfree, Samuel Ortiz, (Sun May 9, 2:10 pm)