Home » Mailing list archives » linux-kernel » 2010 » April » 21

[PATCH] kbuild: add *.rej pattern to .gitignore

Previous thread: [PATCH 2.6.34-rc1] proc: fix badness in fs/proc/generic.c by GuanJun He on Wednesday, April 21, 2010 - 4:09 am. (2 messages)

Next thread: Please pull logfs tree for fixes by Jörn Engel on Wednesday, April 21, 2010 - 5:19 am. (3 messages)
[view original message]
From: Guennadi Liakhovetski
Subject: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Wednesday, April 21, 2010 - 4:47 am

Tell git to ignore .rej files, generated by patch(1).

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
diff --git a/.gitignore b/.gitignore
index a2939fc..17ababa 100644
--- a/.gitignore
+++ b/.gitignore
@@ -74,5 +74,6 @@ GSYMS
 GTAGS
 
 *.orig
+*.rej
 *~
 \#*#
--


[ message continues ]
[view original message]
From: Américo Wang
Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Wednesday, April 21, 2010 - 8:28 am

NACK.


-- 
Live like a child, think like the god.
 
--


[ message continues ]
[view original message]
From: Guennadi Liakhovetski
Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Wednesday, April 21, 2010 - 8:31 am

Hm? I know I have to handle them, and I do handle them, but IMHO it's 
entirely valid and up to the user to leave them where they are. You could 
apply similar argument to *.orig or to *~ files. In other words, I'm not 
convinced.

Thanks

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--


[ message continues ]
[view original message]
From: Américo Wang
Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Wednesday, April 21, 2010 - 9:33 am

I am not the only people who is against this, there
was a discussion about this before, please search lkml
archive.

Thanks.
--


[ message continues ]
[view original message]
From: Michal Marek
Subject: Re: [PATCH] kbuild: add *.rej pattern to .gitignore
Date: Wednesday, April 21, 2010 - 1:22 pm

...and there is no point in starting the flamewar again. If you want to
ignore *.rej files, which is a perfectly valid personal preference, I
suggeest you add the pattern to .git/info/exclude.

hth,
Michal
--


[ message continues ]
Previous thread: [PATCH 2.6.34-rc1] proc: fix badness in fs/proc/generic.c by GuanJun He on Wednesday, April 21, 2010 - 4:09 am. (2 messages)

Next thread: Please pull logfs tree for fixes by Jörn Engel on Wednesday, April 21, 2010 - 5:19 am. (3 messages)