Re: [PATCH] Staging: batman-adv: fix checkpath.pl issues

Previous thread: [PATCH] perf: Fix perf probe build error by Frederic Weisbecker on Tuesday, April 20, 2010 - 5:01 pm. (2 messages)

Next thread: REFNO.:BMW/74-A0802742010 by BMW CUSTOMER SERVICE on Tuesday, April 20, 2010 - 5:47 pm. (1 message)
From: Mikal Sande
Date: Tuesday, April 20, 2010 - 5:49 pm

>From fc01d526b79f61248191493c7ac779def6b50281 Mon Sep 17 00:00:00 2001
From: Mikal Sande <mikal.sande@gmail.com>
Date: Wed, 21 Apr 2010 00:18:14 +0200
Subject: [PATCH] Staging: batman-adv: fix checkpath.pl issues
 This is a patch to all the .c files in batman-adv that fixes the checkpatch.pl issues
 Signed-off-by: Mikal Sande <mikal.sande@gmail.com>

---
 drivers/staging/batman-adv/device.c            |   16 ++++--
 drivers/staging/batman-adv/hard-interface.c    |   13 +++-
 drivers/staging/batman-adv/main.c              |   13 +++-
 drivers/staging/batman-adv/originator.c        |   10 ++-
 drivers/staging/batman-adv/proc.c              |   73 ++++++++++++++++-------
 drivers/staging/batman-adv/routing.c           |   44 ++++++++++----
 drivers/staging/batman-adv/send.c              |   26 +++++---
 drivers/staging/batman-adv/translation-table.c |   21 ++++---
 drivers/staging/batman-adv/vis.c               |   10 ++-
 9 files changed, 154 insertions(+), 72 deletions(-)

diff --git a/drivers/staging/batman-adv/device.c b/drivers/staging/batman-adv/device.c
index 2f61500..8a5de9f 100644
--- a/drivers/staging/batman-adv/device.c
+++ b/drivers/staging/batman-adv/device.c
@@ -68,7 +68,7 @@ int bat_device_setup(void)
 	batman_class = class_create(THIS_MODULE, "batman-adv");
 
 	if (IS_ERR(batman_class)) {
-		printk(KERN_ERR "batman-adv:Could not register class 'batman-adv' \n");
+		printk(KERN_ERR "batman-adv:Could not register class 'batman-adv'\n");
 		return 0;
 	}
 
@@ -111,7 +111,7 @@ int bat_device_open(struct inode *inode, struct file *file)
 	}
 
 	if (device_client_hash[i] != device_client) {
-		printk(KERN_ERR "batman-adv:Error - can't add another packet client: maximum number of clients reached \n");
+		printk(KERN_ERR "batman-adv: Error - can't add another packet client: maximum number of clients reached\n");
 		kfree(device_client);
 		return -EXFULL;
 	}
@@ -212,7 +212,9 @@ ssize_t bat_device_write(struct file *file, const char __user *buff,
 	unsigned long ...
From: Joe Perches
Date: Tuesday, April 20, 2010 - 6:06 pm

C doesn't use + for string concatenation.
Please compile test your changes before submitting them.


--

From: Sven Eckelmann
Date: Tuesday, April 20, 2010 - 11:32 pm

Your patch doesn't apply anymore. See
1270341625-28764-1-git-send-email-luisbg@ubuntu.com and follow ups [1].

Best regards,
	Sven Eckelmann

[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2010-April/002476.html
Previous thread: [PATCH] perf: Fix perf probe build error by Frederic Weisbecker on Tuesday, April 20, 2010 - 5:01 pm. (2 messages)

Next thread: REFNO.:BMW/74-A0802742010 by BMW CUSTOMER SERVICE on Tuesday, April 20, 2010 - 5:47 pm. (1 message)