Re: [PATCH 1/5] Add a global synchronization point for pvclock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeremy Fitzhardinge
Date: Tuesday, April 20, 2010 - 12:42 pm

On 04/20/2010 11:54 AM, Avi Kivity wrote:

People are reporting weirdnesses that "clocksource=jiffies" apparently
resolves.  Xen and KVM are faced with the same hardware constraints, and
it wouldn't surprise me if there were small measurable
non-monotonicities in the PV clock under Xen.  May as well be safe.

Of course, it kills any possibility of being able to usefully export
this interface down to usermode.

My main concern about this kind of simple fix is that if there's a long
term systematic drift between different CPU's tscs, then this will
somewhat mask the problem while giving really awful time measurement on
the "slow" CPU(s).  In that case it really needs to adjust the scaling
factor to correct for the drift (*not* update the offset).  But if we're
definitely only talking about fixed, relatively small time offsets then
it is fine.

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5] pv clock misc fixes, Glauber Costa, (Thu Apr 15, 11:37 am)
[PATCH 1/5] Add a global synchronization point for pvclock, Glauber Costa, (Thu Apr 15, 11:37 am)
[PATCH 2/5] change msr numbers for kvmclock, Glauber Costa, (Thu Apr 15, 11:37 am)
[PATCH 3/5] Try using new kvm clock msrs, Glauber Costa, (Thu Apr 15, 11:37 am)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Fri Apr 16, 1:36 pm)
Re: [PATCH 2/5] change msr numbers for kvmclock, Avi Kivity, (Sat Apr 17, 11:51 am)
Re: [PATCH 3/5] Try using new kvm clock msrs, Avi Kivity, (Sat Apr 17, 11:55 am)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Mon Apr 19, 9:11 am)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Mon Apr 19, 9:18 am)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Mon Apr 19, 9:19 am)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Tue Apr 20, 11:23 am)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Tue Apr 20, 12:42 pm)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Fri Apr 23, 12:22 pm)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Fri Apr 23, 2:35 pm)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Mon Oct 25, 4:30 pm)
Re: [PATCH 1/5] Add a global synchronization point for pvclock, Jeremy Fitzhardinge, (Tue Oct 26, 10:04 am)