login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
April
»
20
Re: [PATCH] RCU: don't turn off lockdep when find suspicious rcu_dereference_check() usage
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Paul E. McKenney
Subject:
Re: [PATCH] RCU: don't turn off lockdep when find suspicious rcu_dereference_check() usage
Date: Tuesday, April 20, 2010 - 6:28 am
On Tue, Apr 20, 2010 at 08:31:56AM -0400, Eric Paris wrote:
quoted text
> On Tue, 2010-04-20 at 16:23 +0800, Lai Jiangshan wrote: > > > [PATCH] RCU: don't turn off lockdep when find suspicious rcu_dereference_check() usage > > > > When suspicious rcu_dereference_check() usage is detected, lockdep is still > > available actually, so we should not call debug_locks_off() in > > lockdep_rcu_dereference(). > > > > For get rid of too much "suspicious rcu_dereference_check() usage" > > output when the "if(!debug_locks_off())" statement is removed. This patch uses > > static variable '__warned's for very usage of "rcu_dereference*()". > > > > One variable per usage, so, Now, we can get multiple complaint > > when we detect multiple different suspicious rcu_dereference_check() usage. > > > > Requested-by: Eric Paris <eparis@redhat.com> > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > > Although mine was a linux-next kernel and it doesn't appear that I have > rcu_dereference_protected() at all, so I dropped that bit of the patch, > it worked great! I got 4 more complaints to harass people with. Feel > free to add my tested by if you care to. > > Tested-by: Eric Paris <eparis@redhat.com>
Very nice!!! Queued for urgent, thank you Lai and Eric!!! Thanx, Paul --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
INFO: suspicious rcu_dereference_check() usage - include/l ...
, Miles Lane
, (Sun Mar 7, 6:26 pm)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Paul E. McKenney
, (Wed Mar 10, 8:28 pm)
Re: INFO: suspicious rcu_dereference_check() usage - incl ...
, Eric Paris
, (Mon Apr 12, 11:44 am)
Re: INFO: suspicious rcu_dereference_check() usage - incl ...
, Peter Zijlstra
, (Mon Apr 12, 11:47 am)
Re: INFO: suspicious rcu_dereference_check() usage - incl ...
, Peter Zijlstra
, (Wed Apr 14, 3:47 am)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Paul E. McKenney
, (Wed Apr 14, 9:03 am)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Paul E. McKenney
, (Thu Apr 15, 8:47 am)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Lai Jiangshan
, (Sun Apr 18, 8:45 pm)
Re: INFO: suspicious rcu_dereference_check() usage - incl ...
, Eric Paris
, (Mon Apr 19, 11:26 am)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Paul E. McKenney
, (Mon Apr 19, 4:01 pm)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Eric Paris
, (Mon Apr 19, 6:25 pm)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Paul E. McKenney
, (Mon Apr 19, 8:04 pm)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Peter Zijlstra
, (Tue Apr 20, 12:21 am)
[PATCH] RCU: don't turn off lockdep when find suspicious r ...
, Lai Jiangshan
, (Tue Apr 20, 1:23 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Peter Zijlstra
, (Tue Apr 20, 1:36 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Eric Paris
, (Tue Apr 20, 5:31 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Tue Apr 20, 6:28 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Tue Apr 20, 6:52 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Tue Apr 20, 8:38 am)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Li Zefan
, (Tue Apr 20, 6:05 pm)
Re: INFO: suspicious rcu_dereference_check() usage - inclu ...
, Paul E. McKenney
, (Tue Apr 20, 8:14 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Borislav Petkov
, (Tue Apr 20, 11:04 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Wed Apr 21, 2:35 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Wed Apr 21, 2:45 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Wed Apr 21, 2:48 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Eric Dumazet
, (Wed Apr 21, 2:57 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Wed Apr 21, 3:14 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Eric W. Biederman
, (Wed Apr 21, 4:26 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Vivek Goyal
, (Thu Apr 22, 7:56 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Thu Apr 22, 9:01 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Fri Apr 23, 5:50 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Fri Apr 23, 12:42 pm)
[PATCH v2.6.34-rc5 01/12] rcu: Fix RCU lockdep splat in se ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 02/12] rcu: fix RCU lockdep splat on fr ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 03/12] rcu: leave lockdep enabled after ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 04/12] NFSv4: Fix the locking in nfs_in ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 05/12] NFS: Fix RCU issues in the NFSv4 ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 06/12] KEYS: Fix an RCU warning
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 07/12] KEYS: Fix an RCU warning in the ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 08/12] cgroup: Fix an RCU warning in cg ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 09/12] cgroup: Fix an RCU warning in al ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 10/12] sched: Fix an RCU warning in pri ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 11/12] cgroup: Check task_lock in task_ ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
[PATCH v2.6.34-rc5 12/12] memcg: css_id() must be called u ...
, Paul E. McKenney
, (Fri Apr 23, 12:43 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Fri Apr 23, 3:59 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Fri Apr 23, 10:35 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Sat Apr 24, 7:34 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Sat Apr 24, 7:36 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Johannes Berg
, (Sun Apr 25, 12:45 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, David Miller
, (Sun Apr 25, 12:49 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Sun Apr 25, 8:49 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Sun Apr 25, 1:20 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Sun Apr 25, 7:07 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Mon Apr 26, 9:09 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Eric W. Biederman
, (Mon Apr 26, 11:35 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Mon Apr 26, 9:27 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Tue Apr 27, 9:22 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Eric Dumazet
, (Tue Apr 27, 9:33 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Tue Apr 27, 10:58 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Tue Apr 27, 4:31 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, David Miller
, (Tue Apr 27, 4:42 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Tue Apr 27, 4:52 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Wed Apr 28, 2:37 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Sat May 1, 10:26 am)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Sat May 1, 2:55 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Miles Lane
, (Sat May 1, 7:00 pm)
Re: [PATCH] RCU: don't turn off lockdep when find suspicio ...
, Paul E. McKenney
, (Sat May 1, 9:11 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
swhiteho
[PATCH 42/51] [GFS2] Move inode deletion out of blocking_cb
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Matthew
Re: Linux 2.6.25
Alex Riesen
Re: [PATCH 4/7] lib: Introduce strnstr()
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
git
:
Mike Miller
git message
David Bremner
Commit f5bbc322 to git broke pre-commit hooks which read stdin
Stefan Richter
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Jeff King
Re: [PATCH] t7004: test that "git-tag -u" implies "-s"
Christian MICHON
Re: VCS comparison table
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Badalian Vyacheslav
Re: tc filter flow hash question
Parav Pandit
ip6 route output() and ip_route_output_key() by drivers
Jarek Poplawski
Re: tc filter flow hash question
git-commits-head
:
Linux Kernel Mailing List
i915: Don't whine when pci_enable_msi() fails.
Linux Kernel Mailing List
usb: musb: fix hanging when rmmod gadget driver
Linux Kernel Mailing List
[ARM] 4671/1: ep93xx: remove obsolete gpio_line_* operations
Linux Kernel Mailing List
Staging: wlan-ng: Move wlan_mkprintstr() and wlan_hexchar() macros into prism2sta.c
Linux Kernel Mailing List
NFSv4: Move error handling out of the delegation generic code
openbsd-misc
:
Vikas N Kumar
Re: Singularity OS
Marco Peereboom
Re: OpenBSD culture?
ropers
Re: Real men don't attack straw men
"RALOVICH, Kristóf"
Re: thinkpad windows refund
Kevin
Re: uvm_mapent_alloc: out of static map entries on 4.3 i386
Colocation donated by:
Syndicate