Home » Mailing list archives » linux-kernel » 2010 » April » 20

[PATCH] x86: correctly wire up the newuname system call

Previous thread: [BUGFIX] [PATCH v2] x86: update all PGDs for direct mapping changes on 64bit. by Haicheng Li on Monday, April 19, 2010 - 8:28 pm. (3 messages)

Next thread: none
[view original message]
From: Christoph Hellwig
Subject: [PATCH] x86: correctly wire up the newuname system call
Date: Monday, April 19, 2010 - 8:31 pm

Before commit e28cbf22933d0c0ccaf3c4c27a1a263b41f73859 64-bit x86 had
a private implementation of sys_uname which was just called sys_uname,
which other architectures used for the old uname.  Due to some merge
issues with the uname refactoring patches we ended up calling the
old uname version for both the old and new system call slots, which
lead to the domainname filed never be set which caused failures with
libnss_nis.

Reported-by: Andy Isaacson <adi@hexapodia.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/arch/x86/ia32/ia32entry.S
===================================================================
--- linux-2.6.orig/arch/x86/ia32/ia32entry.S	2010-04-19 20:21:11.919003961 -0700
+++ linux-2.6/arch/x86/ia32/ia32entry.S	2010-04-19 20:21:19.902005565 -0700
@@ -626,7 +626,7 @@ ia32_sys_call_table:
 	.quad stub32_sigreturn
 	.quad stub32_clone		/* 120 */
 	.quad sys_setdomainname
-	.quad sys_uname
+	.quad sys_newuname
 	.quad sys_modify_ldt
 	.quad compat_sys_adjtimex
 	.quad sys32_mprotect		/* 125 */
--


[ message continues ]
[view original message]
From: Andy Isaacson
Subject: Re: [PATCH] x86: correctly wire up the newuname system call
Date: Tuesday, April 20, 2010 - 7:50 am

Yes, that's the same patch I arrived at and fixes the issue for me.

Tested-by: Andy Isaacson <adi@hexapodia.org>

Thanks,
-andy
--


[ message continues ]
Previous thread: [BUGFIX] [PATCH v2] x86: update all PGDs for direct mapping changes on 64bit. by Haicheng Li on Monday, April 19, 2010 - 8:28 pm. (3 messages)

Next thread: none