Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to block devices

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Anton Blanchard

Subject: Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to block devices

Date: Monday, April 19, 2010 - 7:26 pm

Hi,

quoted text> Actually you can just drop this call entirely.  sync_blockdev is an
> overcomplicated alias for filemap_write_and_wait on the  block device
> inode, which is exactl what we did just before calling into ->fsync
> 
> It might be worth to still drop i_mutex for the cache flush, though.

Thanks for the feedback Jan + Christoph. New patch on the way.

Anton
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Fix regression in O_DIRECT|O_SYNC writes to block ..., Anton Blanchard, (Wed Apr 14, 9:40 pm)

Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to bl ..., Jan Kara, (Thu Apr 15, 1:47 am)

Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to bl ..., Jens Axboe, (Thu Apr 15, 3:04 am)

Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to bl ..., Christoph Hellwig, (Thu Apr 15, 3:42 am)

Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to bl ..., Jan Kara, (Thu Apr 15, 6:34 am)

Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to bl ..., Anton Blanchard, (Mon Apr 19, 7:26 pm)

[PATCH] Fix regression in O_DIRECT|O_SYNC writes to block ..., Anton Blanchard, (Mon Apr 19, 7:30 pm)

Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to bl ..., Jan Kara, (Thu Apr 22, 12:25 pm)


linux-kernel:
Frederic Weisbecker	[PATCH v2] struct sort_entry has a callback named snprintf that turns an entry int...
FUJITA Tomonori	Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Jens Axboe	Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bo...
Andrew Morton	Re: [PATCH v3 0/4] Introduce hardware spinlock framework
Ingo Molnar	Re: [GIT PULL] time.c - respin
git:
Junio C Hamano	Re: git-svnimport
Michal Sojka	[PATCHv5 1/2] filter-branch: Fix to allow replacing submodules with another content
Johannes Schindelin	Re: [PATCH] Fix approxidate("never") to always return 0
Junio C Hamano	Re: Fwd: git status options feature suggestion
A Large Angry SCM	Re: [RFC] origin link for cherry-pick and revert
linux-netdev:
Arnaldo Carvalho de Melo	Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker	[PATCH 1/5] dccp: Initialisation framework for feature negotiation
Ursula Braun	[patch 2/8] [PATCH] af_iucv: sync sk shutdown flag if iucv path is quiesced
Daniel Lezcano	getsockopt(TCP_DEFER_ACCEPT) value change
David Miller	Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
git-commits-head:
Linux Kernel Mailing List	ARM: S3C64XX: DMA: Callback with correct buffer pointer
Linux Kernel Mailing List	sata_mv: drop unncessary EH callback resetting
Linux Kernel Mailing List	timer: Try to survive timer callback preempt_count leak
Linux Kernel Mailing List	powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List	ARM: 5670/1: bcmring: add default configuration for bcmring arch
openbsd-misc:
Rene Maroufi	smtpd: Aliases only work with for local alias aliases
Stephen J. Bevan	GRE over IPsec
Christophe Rioux	Implementation example of snmp
Darrin Chandler	Re: strange output on openbsd C code
Nick Holland	Re: booting openbsd on eee without cd-rom