Home » Mailing list archives » linux-kernel » 2010 » April » 2

[tip:perf/core] x86,kgdb: Always initialize the hw breakpoint attribute

Previous thread: [PATCH] x86,kgdb: Always initialize the hw breakpoint attribute by Jason Wessel on Tuesday, March 30, 2010 - 11:39 am. (2 messages)

Next thread: Re: Linux 2.6.34-rc3 by Larry Finger on Tuesday, March 30, 2010 - 12:17 pm. (6 messages)
[view original message]
From: Jason Wessel
Subject: [PATCH 1/1] x86,kgdb: Always initialize the hw breakpoint attribute
Date: Tuesday, March 30, 2010 - 12:05 pm

It is required to call hw_breakpoint_init() on an attr before using it
in any other calls.  This fixes the problem where kgdb will sometimes
fail to initialize on x86_64.

CC: Ingo Molnar <mingo@elte.hu>
CC: stable@kernel.org
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 arch/x86/kernel/kgdb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index bfba601..b2258ca 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -618,8 +618,8 @@ int kgdb_arch_init(void)
 	 * portion of kgdb because this operation requires mutexs to
 	 * complete.
 	 */
+	hw_breakpoint_init(&attr);
 	attr.bp_addr = (unsigned long)kgdb_arch_init;
-	attr.type = PERF_TYPE_BREAKPOINT;
 	attr.bp_len = HW_BREAKPOINT_LEN_1;
 	attr.bp_type = HW_BREAKPOINT_W;
 	attr.disabled = 1;
-- 
1.5.4.3

--


[ message continues ]
[view original message]
From: Frederic Weisbecker
Subject: Re: [PATCH 1/1] x86,kgdb: Always initialize the hw breakpoint attribute
Date: Tuesday, March 30, 2010 - 12:15 pm

--


[ message continues ]
[view original message]
From: tip-bot for Jason Wessel
Subject: [tip:perf/core] x86,kgdb: Always initialize the hw breakpoint attribute
Date: Friday, April 2, 2010 - 12:06 pm

Commit-ID:  ab310b5edb8b601bcb02491ed6f7676da4fd1757
Gitweb:     http://git.kernel.org/tip/ab310b5edb8b601bcb02491ed6f7676da4fd1757
Author:     Jason Wessel <jason.wessel@windriver.com>
AuthorDate: Tue, 30 Mar 2010 14:05:07 -0500
Committer:  Frederic Weisbecker <fweisbec@gmail.com>
CommitDate: Thu, 1 Apr 2010 08:26:32 +0200

x86,kgdb: Always initialize the hw breakpoint attribute

It is required to call hw_breakpoint_init() on an attr before using it
in any other calls.  This fixes the problem where kgdb will sometimes
fail to initialize on x86_64.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: 2.6.33 <stable@kernel.org>
LKML-Reference: <1269975907-27602-1-git-send-email-jason.wessel@windriver.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 arch/x86/kernel/kgdb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index bfba601..b2258ca 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -618,8 +618,8 @@ int kgdb_arch_init(void)
 	 * portion of kgdb because this operation requires mutexs to
 	 * complete.
 	 */
+	hw_breakpoint_init(&attr);
 	attr.bp_addr = (unsigned long)kgdb_arch_init;
-	attr.type = PERF_TYPE_BREAKPOINT;
 	attr.bp_len = HW_BREAKPOINT_LEN_1;
 	attr.bp_type = HW_BREAKPOINT_W;
 	attr.disabled = 1;
--


[ message continues ]
Previous thread: [PATCH] x86,kgdb: Always initialize the hw breakpoint attribute by Jason Wessel on Tuesday, March 30, 2010 - 11:39 am. (2 messages)

Next thread: Re: Linux 2.6.34-rc3 by Larry Finger on Tuesday, March 30, 2010 - 12:17 pm. (6 messages)