Re: [PATCHv3] drivers/net/usb: Add new driver ipheth

Previous thread: Pending patches for 802.11 not marked stable or which requires a manual backport by Luis R. Rodriguez on Friday, April 2, 2010 - 10:36 am. (1 message)

Next thread: none
From: =?UTF-8?B?IkwuIEFsYmVydG8gR2ltw6luZXoi?=
Date: Friday, April 2, 2010 - 11:23 am

Hi Oliver,

Just like with Ben's comments I still have a couple of doubts about your

I understand that usb_clear_halt is only needed when the device has
transmitted data, and as it is "open" time, we can assume that no
transmissions ere made, so we don't need to clear anything (aka: remove

Well, I have no clue about this one. I think that upstream developers
should take a look into this (Dario, Daniel, could you?) since I don't
have the knowledge to decide what to do about it.

But I assume that as with the previous one, we have just opened the

Does usb_get_infdata always return not NULL? I haven't found anything
about it (just manual pages for the function, but can't spot if it
cannot return NULL). We disconnected the device, but I understand that
the kernel still has the information and the allocated memory, so the

Why?

Thanks a lot in advance.


Best regards,
-- 
L. Alberto Giménez
JabberID agimenez@jabber.sysvalve.es
GnuPG key ID 0x3BAABDE1
--

From: =?UTF-8?B?IkwuIEFsYmVydG8gR2ltw6luZXoi?=
Date: Monday, April 5, 2010 - 11:51 am

Heh, I thought that you meant that the whole struct was redundant, and
that puzzled me a little bit. Now everything is clear (my fault for not
realizing the redundant initialization to 0).

Regards,
-- 
L. Alberto Giménez
JabberID agimenez@jabber.sysvalve.es
GnuPG key ID 0x3BAABDE1
--

Previous thread: Pending patches for 802.11 not marked stable or which requires a manual backport by Luis R. Rodriguez on Friday, April 2, 2010 - 10:36 am. (1 message)

Next thread: none