[patch] cx231xx: improve error handling

Previous thread: [PATCH 1/2] nilfs2: Combine nilfs_btree_alloc_path() and nilfs_btree_init_path() by Li Hong on Friday, April 2, 2010 - 3:42 am. (4 messages)

Next thread: [patch] cx88: improve error handling by Dan Carpenter on Friday, April 2, 2010 - 4:31 am. (1 message)
From: Dan Carpenter
Date: Friday, April 2, 2010 - 4:30 am

Return -EINVAL if we don't find the control id.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c
index d4f546f..5a74ef8 100644
--- a/drivers/media/video/cx231xx/cx231xx-video.c
+++ b/drivers/media/video/cx231xx/cx231xx-video.c
@@ -1901,9 +1901,12 @@ static int radio_queryctrl(struct file *file, void *priv,
 	if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
 		return -EINVAL;
 	if (c->id == V4L2_CID_AUDIO_MUTE) {
-		for (i = 0; i < CX231XX_CTLS; i++)
+		for (i = 0; i < CX231XX_CTLS; i++) {
 			if (cx231xx_ctls[i].v.id == c->id)
 				break;
+		}
+		if (i == CX231XX_CTLS)
+			return -EINVAL;
 		*c = cx231xx_ctls[i].v;
 	} else
 		*c = no_ctl;
--

Previous thread: [PATCH 1/2] nilfs2: Combine nilfs_btree_alloc_path() and nilfs_btree_init_path() by Li Hong on Friday, April 2, 2010 - 3:42 am. (4 messages)

Next thread: [patch] cx88: improve error handling by Dan Carpenter on Friday, April 2, 2010 - 4:31 am. (1 message)